Skip to content

skb_list_walk_safe refactoring for net/*'s skb_gso_segment usage

Jason A. Donenfeld netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8net: skbuff: disambiguate argument and member for skb_list_walk_safe helperinclude/linux/skbuff.h+3 -30 replies
2/8net: udp: use skb_list_walk_safe helper for gso segmentsnet/ipv4/udp.c net/ipv6/udp.c+2 -40 replies
3/8net: xfrm: use skb_list_walk_safe helper for gso segmentsnet/xfrm/xfrm_device.c net/xfrm/xfrm_output.c+7 -170 replies
4/8net: openvswitch: use skb_list_walk_safe helper for gso segmentsnet/openvswitch/datapath.c+4 -70 replies
5/8net: sched: use skb_list_walk_safe helper for gso segmentsnet/sched/sch_cake.c net/sched/sch_tbf.c+2 -60 replies
6/8net: ipv4: use skb_list_walk_safe helper for gso segmentsnet/ipv4/ip_output.c+3 -50 replies
7/8net: netfilter: use skb_list_walk_safe helper for gso segmentsnet/netfilter/nfnetlink_queue.c+3 -50 replies
8/8net: mac80211: use skb_list_walk_safe helper for gso segmentsnet/mac80211/tx.c+5 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/8] skb_list_walk_safe refactoring for net/*'s skb_gso_segment usage

This patchset adjusts all return values of skb_gso_segment in net/* to use the new skb_list_walk_safe helper.

First we fix a minor bug in the helper macro that didn't come up in the last patchset's uses. Then we adjust several cases throughout net/. The xfrm changes were a bit hairy, but doable. Reading and thinking about the code in mac80211 indicates a memory leak, which the commit addresses. All the other cases were pretty trivial.

Jason A. Donenfeld (8):
net: skbuff: disambiguate argument and member for skb_list_walk_safe
helper
net: udp: use skb_list_walk_safe helper for gso segments
net: xfrm: use skb_list_walk_safe helper for gso segments
net: openvswitch: use skb_list_walk_safe helper for gso segments
net: sched: use skb_list_walk_safe helper for gso segments
net: ipv4: use skb_list_walk_safe helper for gso segments
net: netfilter: use skb_list_walk_safe helper for gso segments
net: mac80211: use skb_list_walk_safe helper for gso segments

 include/linux/skbuff.h          |  6 +++---
 net/ipv4/ip_output.c            |  8 +++-----
 net/ipv4/udp.c                  |  3 +--
 net/ipv6/udp.c                  |  3 +--
 net/mac80211/tx.c               | 13 +++++--------
 net/netfilter/nfnetlink_queue.c |  8 +++-----
 net/openvswitch/datapath.c      | 11 ++++-------
 net/sched/sch_cake.c            |  4 +---
 net/sched/sch_tbf.c             |  4 +---
 net/xfrm/xfrm_device.c          | 15 ++++-----------
 net/xfrm/xfrm_output.c          |  9 +++------
 11 files changed, 29 insertions(+), 55 deletions(-)
Signature · 1 line
2.24.1