Skip to content

Fix the regression for the thunderx gpio

Kevin Hao linux-gpio oe-kbuild-all 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Revert "gpio: thunderx: Switch to GPIOLIB_IRQCHIP"drivers/gpio/Kconfig drivers/gpio/gpio-thunderx.c+107 -570 replies
2/4gpiolib: Add support for the irqdomain which doesn't use irq_fwspec as argdrivers/gpio/gpio-tegra186.c drivers/gpio/gpiolib.c drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +2 more+49 -340 replies
3/4gpiolib: Add the support for the msi parent domaindrivers/gpio/gpiolib.c+6 -00 replies
4/4gpio: thunderx: Switch to GPIOLIB_IRQCHIPdrivers/gpio/Kconfig drivers/gpio/gpio-thunderx.c+78 -1000 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Fix the regression for the thunderx gpio

Hi Linus,

Since the commit a7fc89f9d5fc ("gpio: thunderx: Switch to GPIOLIB_IRQCHIP"), the thunderx gpio doesn't work anymore. I noticed that you have submitted a patch [1] to fix the " irq_domain_push_irq: -22" error, but the kernel would panic after applying that fix because the hwirq passed to the msi irqdomain is still not correct. It seems that we need more codes to make the thunderx gpio work with the GPIOLIB_IRQCHIP. So I would prefer to revert the commit a7fc89f9d5fc first to make the thunderx gpio to work on the 5.4.x and 5.5 at least. We can then do more test for GPIOLIB_IRQCHIP switching (which the patch 2 ~ 4 do) before merging them.

[1] https://patchwork.ozlabs.org/patch/1210180/

Kevin Hao (4):
Revert "gpio: thunderx: Switch to GPIOLIB_IRQCHIP"
gpiolib: Add support for the irqdomain which doesn't use irq_fwspec as
arg
gpiolib: Add the support for the msi parent domain
gpio: thunderx: Switch to GPIOLIB_IRQCHIP

 drivers/gpio/gpio-tegra186.c             | 13 ++++++--
 drivers/gpio/gpio-thunderx.c             | 36 +++++++++++++++++++---
 drivers/gpio/gpiolib.c                   | 51 ++++++++++++++++++++++----------
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c |  2 +-
 drivers/pinctrl/qcom/pinctrl-ssbi-gpio.c |  2 +-
 include/linux/gpio/driver.h              | 21 +++++--------
 6 files changed, 87 insertions(+), 38 deletions(-)
Signature · 1 line
2.14.4