livepatch/samples/selftest: Clean up show variables handling
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | livepatch/sample: Use the right type for the leaking data pointersamples/ samples/ samples/ | +10 | 0 replies | |
| 2/4 | livepatch/selftest: Clean up shadow variable names and typelib/ | +52 | 0 replies | |
| 3/4 | livepatch/samples/selftest: Use klp_shadow_alloc() API correctlylib/ samples/ | +36 | 0 replies | |
| 4/4 | livepatch: Handle allocation failure in the sample of shadow variable APIsamples/ | +16 | 0 replies |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Joe Lawrence | Miroslav Benes | Kamalesh Babulal |
|---|---|---|---|
| Series | R-b | A-b | R-b |
| 1/4 | |||
| 2/4 | |||
| 3/4 | |||
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/4] livepatch/samples/selftest: Clean up show variables handling
Dan Carpenter reported suspicious allocations of shadow variables in the sample module, see
https://lkml.kernel.org/r/[email protected]
The code did not cause a real problem. But it was indeed misleading and semantically wrong. I got confused several times when cleaning it. So I decided to split the change into few steps. I hope that it will help reviewers and future readers.
The changes of the sample module are basically the same as in the RFC. In addition, there is a clean up of the module used by the selftest.
Petr Mladek (4):
livepatch/sample: Use the right type for the leaking data pointer livepatch/selftest: Clean up shadow variable names and type livepatch/samples/selftest: Use klp_shadow_alloc() API correctly
livepatch: Handle allocation failure in the sample of shadow variable
API
lib/livepatch/test_klp_shadow_vars.c | 119 +++++++++++++++++------------- samples/livepatch/livepatch-shadow-fix1.c | 39 ++++++---- samples/livepatch/livepatch-shadow-fix2.c | 4 +- samples/livepatch/livepatch-shadow-mod.c | 4 +- 4 files changed, 99 insertions(+), 67 deletions(-)
Signature · 1 line
2.16.4