mm/migrate.c: cleanup on do_pages_move()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 20 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | mm/migrate.c: skip node check if done in last roundmm/ | +11 | 5 replies | |
| 2/8 | mm/migrate.c: not necessary to check start and imm/ | +3 | 3 replies | |
| 3/8 | mm/migrate.c: reform the last call on do_move_pages_to_node()mm/ | +6 | 2 replies | |
| 4/8 | mm/migrate.c: wrap do_move_pages_to_node() and store_status()mm/ | +19 | 1 reply | |
| 5/8 | mm/migrate.c: check pagelist in move_pages_and_store_status()mm/ | +3 | 1 reply | |
| 6/8 | mm/migrate.c: handle same node and add failure in the same waymm/ | +8 | 1 reply | |
| 7/8 | mm/migrate.c: move page on next iterationmm/ | +9 | 5 replies | |
| 8/8 | mm/migrate.c: use break instead of goto out_flushmm/ | +7 | 2 replies |
Reviews trailers per patch
4 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Michal Hocko |
|---|---|
| 1/8 | |
| 2/8 | A-b |
| 3/8 | |
| 4/8 | A-b |
| 5/8 | A-b |
| 6/8 | A-b |
| 7/8 | |
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/8] mm/migrate.c: cleanup on do_pages_move()
The logic in do_pages_move() is a little mess for audience to read and has some potential error on handling the return value. Especially there are three calls on do_move_pages_to_node() and store_status() with almost the same form.
This patch set tries to make the code a little friendly for audience by consolidate the calls and remove some unnecessary repeat code.
After this, we can do a better fix.
Wei Yang (8):
mm/migrate.c: skip node check if done in last round mm/migrate.c: not necessary to check start and i mm/migrate.c: reform the last call on do_move_pages_to_node() mm/migrate.c: wrap do_move_pages_to_node() and store_status() mm/migrate.c: check pagelist in move_pages_and_store_status() mm/migrate.c: handle same node and add failure in the same way mm/migrate.c: move page on next iteration mm/migrate.c: use break instead of goto out_flush
mm/migrate.c | 90 ++++++++++++++++++++++++++++------------------------ 1 file changed, 48 insertions(+), 42 deletions(-)
Signature · 1 line
2.17.1