Skip to content

scsi: support bypass device busy check for some high end HBA with SSD

Ming Lei linux-block linux-scsi 1 version Applied

Status from this message: Applied to 5.7/scsi-queue. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 20 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/6scsi: mpt3sas: don't use .device_busy in device reset routinedrivers/scsi/mpt3sas/mpt3sas_scsih.c+31 -11 reply
2/6scsi: remove .for_blk_mqdrivers/scsi/virtio_scsi.c include/scsi/scsi_host.h+0 -45 replies
3/6scsi: sd: register request queue after sd_revalidate_disk is donedrivers/scsi/sd.c+2 -11 reply
4/6block: freeze queue for updating QUEUE_FLAG_NONROTblock/blk-sysfs.c drivers/scsi/sd.c+17 -11 reply
5/6scsi: core: don't limit per-LUN queue depth for SSD when HBA needsdrivers/scsi/scsi_lib.c include/scsi/scsi_host.h+31 -612 replies
6/6scsi: megaraid: set flag of no_device_queue_for_ssddrivers/scsi/megaraid/megaraid_sas_base.c+1 -00 replies

Reviews trailers per patch

2 of 6 patches have a Reviewed-by or Acked-by.

PatchHannes ReineckeBart Van AsscheChristoph Hellwig
1/6
2/6R-b R-b
3/6R-b
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/6] scsi: support bypass device busy check for some high end HBA with SSD

Hi,

SCSI's per-LUN queue depth is usually for improving IO merge and balancing IO load among LUNs. blk-mq has provides fair driver tag allocation and managed IRQ balances interrupt load among queues, meantime IO merge doesn't play a big role for SSD, and NVMe doesn't apply per-namespace queue depth.

This patchset tries to don't apply per-LUN queue depth for some high end HBA in case of SSD, then we can avoid the expensive atomic operation on sdev->device_busy. We do understand that this shared counter affects IOPS a lot.

Thanks,
Ming

Ming Lei (6):
scsi: mpt3sas: don't use .device_busy in device reset routine
scsi: remove .for_blk_mq
scsi: sd: register request queue after sd_revalidate_disk is done
block: freeze queue for updating QUEUE_FLAG_NONROT
scsi: core: don't limit per-LUN queue depth for SSD when HBA needs
scsi: megaraid: set flag of no_device_queue_for_ssd

 block/blk-sysfs.c                         | 14 +++++++++-
 drivers/scsi/megaraid/megaraid_sas_base.c |  1 +
 drivers/scsi/mpt3sas/mpt3sas_scsih.c      | 32 ++++++++++++++++++++-
 drivers/scsi/scsi_lib.c                   | 34 +++++++++++++++++++----
 drivers/scsi/sd.c                         |  7 ++++-
 drivers/scsi/virtio_scsi.c                |  1 -
 include/scsi/scsi_host.h                  |  4 +--
 7 files changed, 81 insertions(+), 12 deletions(-)
Cc Sathya Prakash <[email protected]>
Cc Chaitra P B <[email protected]>
Cc Suganath Prabu Subramani <[email protected]>
Cc Kashyap Desai <[email protected]>
Cc Sumit Saxena <[email protected]>
Cc Shivasharan S <[email protected]>
Cc Ewan D. Milne <[email protected]>
Cc Hannes Reinecke <[email protected]>
Cc Bart Van Assche <[email protected]>
Signature · 1 line
2.20.1