Skip to content

drm/rockchip: Fix unbind/bind

Ezequiel Garcia dri-devel linux-arm-kernel linux-rockchip lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5component: Add an API to cleanup before unbinddrivers/base/component.c include/linux/component.h+16 -30 replies
2/5drm/rockchip: Fix the device unbind orderdrivers/gpu/drm/rockchip/rockchip_drm_drv.c+12 -80 replies
3/5drm/rockchip: vop: Fix CRTC unbinddrivers/gpu/drm/rockchip/rockchip_drm_vop.c+20 -360 replies
4/5drm/rockchip: lvds: Fix component unbinddrivers/gpu/drm/rockchip/rockchip_lvds.c+10 -100 replies
5/5drm/rockchip: rk3066_hdmi: Cleanup component unbinddrivers/gpu/drm/rockchip/rk3066_hdmi.c+2 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] drm/rockchip: Fix unbind/bind

This series is an attempt to fix the unbind/bind crash (due to an use-after-free bug) found on rockchip-drm driver.

The problem lies in the way the driver uses the component API. Currently, rockchip_drm_unbind calls component_unbind_all before drm_mode_config_cleanup, the former releasing the memory where the DRM objects are embedded.

The series goal is basically to fix all the components, making proper use of the respective .destroy hooks, making sure there are no use-after-free or double-free issues.

The first patch is likely the most controversial, which is required because component_bind_all will call component_unbind without calling drm_mode_config_cleanup, if any component fails to bind. As mentioned above, this is problematic in the DRM framework.

Thanks!
Ezequiel

Ezequiel Garcia (5):
component: Add an API to cleanup before unbind drm/rockchip: Fix the device unbind order drm/rockchip: vop: Fix CRTC unbind drm/rockchip: lvds: Fix component unbind drm/rockchip: rk3066_hdmi: Cleanup component unbind

 drivers/base/component.c                    |  9 +++-
 drivers/gpu/drm/rockchip/rk3066_hdmi.c      |  8 +--
 drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 20 +++++---
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 56 ++++++++-------------
 drivers/gpu/drm/rockchip/rockchip_lvds.c    | 20 ++++----
 include/linux/component.h                   | 10 +++-
 6 files changed, 60 insertions(+), 63 deletions(-)
Signature · 1 line
2.25.0