Skip to content

qemu-img: Fix convert -n -B for backing-less targets

Max Reitz qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2qemu-img: Fix convert -n -B for backing-less targetsqemu-img.c+1 -10 replies
2/2iotests: Test convert -n -B to backing-less targettests/qemu-iotests/122 tests/qemu-iotests/122.out+19 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJohn Snow
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] qemu-img: Fix convert -n -B for backing-less targets

Hi,

When reviewing David’s series to add --target-is-zero convert, I looked for a case to show that the current implementation will crash if -n --target-is-zero is used together with -B. It then turned out that -B will always crash when combined with -n and the target image does not have a backing file set in its image header.

This series fixes that.

Max Reitz (2):
qemu-img: Fix convert -n -B for backing-less targets
iotests: Test convert -n -B to backing-less target

 qemu-img.c                 |  2 +-
 tests/qemu-iotests/122     | 14 ++++++++++++++
 tests/qemu-iotests/122.out |  5 +++++
 3 files changed, 20 insertions(+), 1 deletion(-)
Signature · 1 line
2.24.1