Skip to content

cleanup on do_pages_move()

Wei Yang linux-mm lkml 4 versions – Applied

Status from this message: [merged] mm-migratec-unify-not-queued-for-migration-handling-in-do_pages_move.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest4 patches 1 replyApplied 4/4
  2. v44 patches 0 repliesSuperseded
  3. v34 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v24 patches11 repliesSuperseded

Changes in v5 from the cover letter

: rebase on top of latest upstream, "linux/pipe_fs_i.h: fix kernel-doc
warnings after @wait was split"

Patches in v5 All 4 applied

#Subject and filesSizeRepliesApplied
1/4mm/migrate.c: no need to check for i > start in do_pages_move()mm/migrate.c+3 -50 repliesApplied
2/4mm/migrate.c: wrap do_move_pages_to_node() and store_status()mm/migrate.c+29 -320 repliesApplied
3/4mm/migrate.c: check pagelist in move_pages_and_store_status()mm/migrate.c+3 -60 repliesApplied
4/4mm/migrate.c: unify "not queued for migration" handling in do_pages_move()mm/migrate.c+6 -80 repliesApplied

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMichal HockoDavid Hildenbrand
1/4A-b R-b
2/4A-b R-b
3/4A-b R-b
4/4A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [Patch v5 0/4] cleanup on do_pages_move()

The logic in do_pages_move() is a little mess for audience to read and has some potential error on handling the return value. Especially there are three calls on do_move_pages_to_node() and store_status() with almost the same form.

This patch set tries to make the code a little friendly for audience by consolidate the calls.

v5:
: rebase on top of latest upstream, "linux/pipe_fs_i.h: fix kernel-doc
warnings after @wait was split"
v4:
* rephrase changelog based on suggestion from David Hildenbrand
* trivial change on code style and comment
v3:
* rebase on top of Yang Shi's fix "mm: move_pages: report the number of non-attempted pages"
v2:
* remove some unnecessary cleanup

Wei Yang (4):
mm/migrate.c: no need to check for i > start in do_pages_move() mm/migrate.c: wrap do_move_pages_to_node() and store_status() mm/migrate.c: check pagelist in move_pages_and_store_status() mm/migrate.c: unify "not queued for migration" handling in

    do_pages_move()
 mm/migrate.c | 88 +++++++++++++++++++++++-----------------------------
 1 file changed, 39 insertions(+), 49 deletions(-)
Signature · 1 line
2.17.1