Skip to content

Fix crashes on early shutdown during bitmaps postcopy

Vladimir Sementsov-Ogievskiy qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7migration/block-dirty-bitmap: refactor incoming state to be one structmigration/block-dirty-bitmap.c+43 -342 replies
2/7migration/block-dirty-bitmap: rename finish_lock to just lockmigration/block-dirty-bitmap.c+6 -61 reply
3/7migration/block-dirty-bitmap: simplify dirty_bitmap_load_completemigration/block-dirty-bitmap.c+4 -210 replies
4/7migration/block-dirty-bitmap: keep bitmap state for all bitmapsmigration/block-dirty-bitmap.c+38 -213 replies
5/7migration/block-dirty-bitmap: cancel migration on shutdownmigration/block-dirty-bitmap.c migration/migration.c migration/migration.h+48 -40 replies
6/7migration: handle to_src_file on target only for ram postcopymigration/savevm.c+13 -60 replies
7/7qemu-iotests/199: add early shutdown case to bitmaps postcopytests/qemu-iotests/199 tests/qemu-iotests/199.out+13 -30 replies

Reviews trailers per patch

1 of 7 patches has a Reviewed-by or Acked-by.

PatchJuan Quintela
1/7
2/7R-b
3/7
4/7
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] Fix crashes on early shutdown during bitmaps postcopy

Hi all!

Patches 5 and 6 fixes two crashes, triggered by new test case in patch 7.

Vladimir Sementsov-Ogievskiy (7):
migration/block-dirty-bitmap: refactor incoming state to be one struct migration/block-dirty-bitmap: rename finish_lock to just lock migration/block-dirty-bitmap: simplify dirty_bitmap_load_complete migration/block-dirty-bitmap: keep bitmap state for all bitmaps migration/block-dirty-bitmap: cancel migration on shutdown
migration: handle to_src_file on target only for ram postcopy qemu-iotests/199: add early shutdown case to bitmaps postcopy

 migration/migration.h          |   1 +
 migration/block-dirty-bitmap.c | 171 +++++++++++++++++++++------------
 migration/migration.c          |   7 ++
 migration/savevm.c             |  19 ++--
 tests/qemu-iotests/199         |  12 ++-
 tests/qemu-iotests/199.out     |   4 +-
 6 files changed, 142 insertions(+), 72 deletions(-)
Signature · 1 line
2.21.0