Skip to content

platform/x86: intel_pmc_ipc: Cleanups

Mika Westerberg lkml platform-driver-x86 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9platform/x86: intel_pmc_ipc: Make intel_pmc_gcr_update() staticarch/x86/include/asm/intel_pmc_ipc.h drivers/platform/x86/intel_pmc_ipc.c+1 -80 replies
2/9platform/x86: intel_pmc_ipc: Make intel_pmc_ipc_simple_command() staticarch/x86/include/asm/intel_pmc_ipc.h drivers/platform/x86/intel_pmc_ipc.c+1 -80 replies
3/9platform/x86: intel_pmc_ipc: Make intel_pmc_ipc_raw_cmd() staticarch/x86/include/asm/intel_pmc_ipc.h drivers/platform/x86/intel_pmc_ipc.c+2 -110 replies
4/9platform/x86: intel_pmc_ipc: Drop intel_pmc_gcr_read() and intel_pmc_gcr_write()arch/x86/include/asm/intel_pmc_ipc.h drivers/platform/x86/intel_pmc_ipc.c+0 -710 replies
5/9platform/x86: intel_pmc_ipc: Drop ipc_data_readb()drivers/platform/x86/intel_pmc_ipc.c+0 -50 replies
6/9platform/x86: intel_pmc_ipc: Get rid of unnecessary includesdrivers/platform/x86/intel_pmc_ipc.c+0 -100 replies
7/9platform/x86: intel_pmc_ipc: Use octal permissions in sysfs attributesdrivers/platform/x86/intel_pmc_ipc.c+2 -50 replies
8/9platform/x86: intel_pmc_ipc: Propagate error from kstrtoul()drivers/platform/x86/intel_pmc_ipc.c+3 -20 replies
9/9platform/x86: intel_pmc_ipc: Switch to use driver->dev_groupsdrivers/platform/x86/intel_pmc_ipc.c+7 -100 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchAndy Shevchenko
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b
6/9R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] platform/x86: intel_pmc_ipc: Cleanups

Hi,

This is another independent cleanup series that I split out from my SCU/PMC IPC rework patch set [1] as suggested by Greg. This removes code that is not used anywhere and makes certain functions static as they are not called outside of the driver. We also make the driver to use driver->dev_groups to expose sysfs attributes.

[1] https://lkml.org/lkml/2020/1/21/678

Mika Westerberg (9):
platform/x86: intel_pmc_ipc: Make intel_pmc_gcr_update() static platform/x86: intel_pmc_ipc: Make intel_pmc_ipc_simple_command() static platform/x86: intel_pmc_ipc: Make intel_pmc_ipc_raw_cmd() static platform/x86: intel_pmc_ipc: Drop intel_pmc_gcr_read() and intel_pmc_gcr_write() platform/x86: intel_pmc_ipc: Drop ipc_data_readb()
platform/x86: intel_pmc_ipc: Get rid of unnecessary includes platform/x86: intel_pmc_ipc: Use octal permissions in sysfs attributes platform/x86: intel_pmc_ipc: Propagate error from kstrtoul() platform/x86: intel_pmc_ipc: Switch to use driver->dev_groups

 arch/x86/include/asm/intel_pmc_ipc.h |  32 --------
 drivers/platform/x86/intel_pmc_ipc.c | 114 ++++-----------------------
 2 files changed, 16 insertions(+), 130 deletions(-)
Signature · 1 line
2.24.1