Skip to content

tests/acceptance/virtio_seg_max_adjust: Restrict it to Linux/X86

Philippe Mathieu-Daudé qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to my python-next tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest29 patches 41 repliesApplied
  2. v16 patches 7 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/29hw/core: Allow setting 'virtio-blk-device.scsi' property on OSX hosthw/core/machine.c+2 -12 replies
2/29accel/accel: Make TYPE_ACCEL abstractaccel/accel.c+1 -02 replies
3/29python/qemu: Add binutils::binary_get_version()python/qemu/binutils.py tests/acceptance/core_scripts.py+69 -02 replies
4/29tests/acceptance: Use 'version-min' tag to verify QEMU binary versiontests/acceptance/avocado_qemu/__init__.py+18 -05 replies
5/29tests/acceptance: Restrict X86CPUModelAliases test to QEMU >= 4.1tests/acceptance/x86_cpu_model_versions.py+1 -00 replies
6/29python/qemu: Add binutils::binary_get_arch()python/qemu/binutils.py tests/acceptance/core_scripts.py+26 -01 reply
7/29tests/acceptance: Use the 'arch' tag to verify QEMU binary targettests/acceptance/avocado_qemu/__init__.py+9 -01 reply
8/29python/qemu: Add binutils::binary_get_machines()python/qemu/binutils.py tests/acceptance/core_scripts.py+24 -01 reply
9/29tests/acceptance: Use 'machine' tag to check if available in QEMU binarytests/acceptance/avocado_qemu/__init__.py+10 -33 replies
10/29python/qemu: Add binutils::binary_get_qom_implementations()python/qemu/binutils.py tests/acceptance/core_scripts.py+30 -02 replies
11/29python/qemu: Add binutils::binary_get_accels()python/qemu/binutils.py tests/acceptance/core_scripts.py+20 -01 reply
12/29python/qemu/accel: Use binutils::binary_get_accels()python/qemu/accel.py+4 -221 reply
13/29python/qemu: Add binutils::binary_get_devices()python/qemu/binutils.py tests/acceptance/core_scripts.py+17 -01 reply
14/29tests/acceptance: Use 'device' tags to check availability in QEMU binarytests/acceptance/avocado_qemu/__init__.py+11 -00 replies
15/29tests: rename virtio_seg_max_adjust to virtio_check_paramstests/acceptance/virtio_check_params.py+0 -02 replies
16/29tests/acceptance/virtio_check_params: Only remove listed machinestests/acceptance/virtio_check_params.py+5 -40 replies
17/29tests/acceptance/virtio_check_params: Improve exception loggingtests/acceptance/virtio_check_params.py+6 -22 replies
18/29tests/acceptance/virtio_check_params: List machine being testedtests/acceptance/virtio_check_params.py+4 -02 replies
19/29tests/acceptance/virtio_check_params: Only test Xen as superusertests/acceptance/virtio_check_params.py+2 -02 replies
20/29tests/acceptance/virtio_check_params: Skip test if arch is not supportedtests/acceptance/virtio_check_params.py+23 -140 replies
21/29tests/acceptance/virtio_check_params: Kludge to skip tests on MIPStests/acceptance/virtio_check_params.py+3 -00 replies
22/29tests/acceptance/virtio_check_params: Support the s390x architecturetests/acceptance/virtio_check_params.py+2 -00 replies
23/29tests/acceptance/virtio_check_params: Support the ppc architecturetests/acceptance/virtio_check_params.py+7 -00 replies
24/29tests/acceptance/virtio_check_params: Default to -nodefaultstests/acceptance/virtio_check_params.py+1 -01 reply
25/29tests/acceptance/virtio_check_params: Require a virtio-scsi-pci devicetests/acceptance/virtio_check_params.py+3 -00 replies
26/29tests/acceptance/boot_linux_console: Do not use VGA on Clipper machinetests/acceptance/boot_linux_console.py+1 -11 reply
27/29tests/acceptance/migration: Default to -nodefaultstests/acceptance/migration.py+3 -12 replies
28/29tests/acceptance/version: Default to -nodefaultstests/acceptance/version.py+1 -02 replies
29/29MAINTAINERS: Add Acceptance tests reviewersMAINTAINERS+6 -02 replies

Reviews trailers per patch

19 of 29 patches have a Reviewed-by or Acked-by.

PatchCornelia HuckThomas HuthEduardo HabkostWainer dos Santos MoschettaLiam Merwick
1/29R-b
2/29R-b
3/29
4/29
5/29
6/29R-b
7/29R-b
8/29R-b
9/29R-b
10/29R-b
11/29R-b
12/29R-b
13/29R-b
14/29
15/29A-b
16/29R-b
17/29R-b
18/29R-b
19/29A-b
20/29
21/29
22/29
23/29
24/29R-b
25/29
26/29R-b
27/29R-b R-b
28/29R-b R-b
29/29

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/29] tests/acceptance/virtio_seg_max_adjust: Restrict it to Linux/X86

Currently our CI is mostly restricted to Linux/X86.
We want to have more, but until there we have to run these tests manually, which is why we didn't noticed earlier this test was failing on OSX.

This series contains the patches I used to debug why the virtio_seg_max_adjust had broken the OSX CI, but then I kept testing on other archs, thus added more patches...

Currently our CI is mostly restricted to Linux/X86.
We want to have more, but until there we have to run these tests manually, which is why we didn't noticed earlier some tests are failing (on OSX, using --without-default-devices, ...).

Tested on Linux/FreeBSD/OSX, X86/Aarch64.

Regards,

Phil.

Supersedes: <[email protected]> "tests/acceptance/virtio_seg_max_adjust: Restrict it to Linux/X86"

Denis Plotnikov (1):
tests: rename virtio_seg_max_adjust to virtio_check_params

Philippe Mathieu-Daudé (28):
hw/core: Allow setting 'virtio-blk-device.scsi' property on OSX host accel/accel: Make TYPE_ACCEL abstract
python/qemu: Add binutils::binary_get_version() tests/acceptance: Use 'version-min' tag to verify QEMU binary version tests/acceptance: Restrict X86CPUModelAliases test to QEMU >= 4.1 python/qemu: Add binutils::binary_get_arch() tests/acceptance: Use the 'arch' tag to verify QEMU binary target python/qemu: Add binutils::binary_get_machines() tests/acceptance: Use 'machine' tag to check if available in QEMU
binary
python/qemu: Add binutils::binary_get_qom_implementations() python/qemu: Add binutils::binary_get_accels() python/qemu/accel: Use binutils::binary_get_accels() python/qemu: Add binutils::binary_get_devices() tests/acceptance: Use 'device' tags to check availability in QEMU
binary
tests/acceptance/virtio_check_params: Only remove listed machines tests/acceptance/virtio_check_params: Improve exception logging tests/acceptance/virtio_check_params: List machine being tested tests/acceptance/virtio_check_params: Only test Xen as superuser tests/acceptance/virtio_check_params: Skip test if arch is not
supported
tests/acceptance/virtio_check_params: Kludge to skip tests on MIPS tests/acceptance/virtio_check_params: Support the s390x architecture tests/acceptance/virtio_check_params: Support the ppc architecture tests/acceptance/virtio_check_params: Default to -nodefaults tests/acceptance/virtio_check_params: Require a virtio-scsi-pci device tests/acceptance/boot_linux_console: Do not use VGA on Clipper machine tests/acceptance/migration: Default to -nodefaults tests/acceptance/version: Default to -nodefaults
MAINTAINERS: Add Acceptance tests reviewers

 accel/accel.c                                 |   1 +
 hw/core/machine.c                             |   3 +-
 MAINTAINERS                                   |   6 +
 python/qemu/accel.py                          |  26 +----
 python/qemu/binutils.py                       | 107 ++++++++++++++++++
 tests/acceptance/avocado_qemu/__init__.py     |  51 ++++++++-
 tests/acceptance/boot_linux_console.py        |   2 +-
 tests/acceptance/core_scripts.py              |  79 +++++++++++++
 tests/acceptance/migration.py                 |   4 +-
 tests/acceptance/version.py                   |   1 +
 ...g_max_adjust.py => virtio_check_params.py} |  70 +++++++++---
 tests/acceptance/x86_cpu_model_versions.py    |   1 +
 12 files changed, 306 insertions(+), 45 deletions(-)
 create mode 100644 python/qemu/binutils.py
 create mode 100644 tests/acceptance/core_scripts.py
 rename tests/acceptance/{virtio_seg_max_adjust.py => virtio_check_params.py} (64%)
Signature · 1 line
2.21.1