Skip to content

dax/pmem: Provide a dax operation to zero page range

Vivek Goyal dm-devel linux-fsdevel linux-nvdimm linux-s390 nvdimm 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest6 patches 10 repliesIn review
  2. v58 patches 43 repliesSuperseded
  3. v47 patches 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v37 patches12 repliesSuperseded
v2 RFC5 patches18 repliesSuperseded
v1 RFC1 patch6 repliesSuperseded

Changes in v6 from the cover letter

- Dan Williams preferred ->zero_page_range() to only accept PAGE_SIZE aligned request and clear poison only on page size aligned zeroing. So I changed it accordingly.

- Dropped all the modifications which were required to support arbitrary range zeroing with-in a page.

- This patch series also fixes the issue where "truncate -s 512 foo.txt" will fail if first sector of file is poisoned. Currently it succeeds and filesystem expectes whole of the filesystem block to be free of poison at the end of the operation.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6pmem: Add functions for reading/writing page to/from pmemdrivers/nvdimm/pmem.c+50 -363 replies
2/6dax, pmem: Add a dax operation zero_page_rangedrivers/dax/super.c drivers/nvdimm/pmem.c include/linux/dax.h+35 -01 reply
3/6s390,dcssblk,dax: Add dax zero_page_range operation to dcssblk driverdrivers/s390/block/dcssblk.c+15 -00 replies
4/6dm,dax: Add dax zero_page_range operationdrivers/md/dm-linear.c drivers/md/dm-log-writes.c drivers/md/dm-stripe.c +2 more+91 -03 replies
5/6dax: Use new dax zero page method for zeroing a pagefs/dax.c+23 -300 replies
6/6dax,iomap: Add helper dax_iomap_zero() to zero a rangefs/dax.c fs/iomap/buffered-io.c include/linux/dax.h+12 -300 replies

Reviews trailers per patch

5 of 6 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigGerald SchaeferPankaj GuptaMike Snitzer
1/6R-b R-b
2/6R-b
3/6R-b
4/6A-b
5/6
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/6] dax/pmem: Provide a dax operation to zero page range

Hi,

This is V6 of patches. These patches are also available at.

Changes since V5:

- Dan Williams preferred ->zero_page_range() to only accept PAGE_SIZE aligned request and clear poison only on page size aligned zeroing. So I changed it accordingly.

- Dropped all the modifications which were required to support arbitrary range zeroing with-in a page.

- This patch series also fixes the issue where "truncate -s 512 foo.txt" will fail if first sector of file is poisoned. Currently it succeeds and filesystem expectes whole of the filesystem block to be free of poison at the end of the operation.

Christoph, I have dropped your Reviewed-by tag on 1-2 patches because these patches changed substantially. Especially signature of of dax zero_page_range() helper.

Thanks
Vivek

Vivek Goyal (6):
pmem: Add functions for reading/writing page to/from pmem dax, pmem: Add a dax operation zero_page_range s390,dcssblk,dax: Add dax zero_page_range operation to dcssblk driver dm,dax: Add dax zero_page_range operation
dax: Use new dax zero page method for zeroing a page dax,iomap: Add helper dax_iomap_zero() to zero a range

 drivers/dax/super.c           | 20 ++++++++
 drivers/md/dm-linear.c        | 18 +++++++
 drivers/md/dm-log-writes.c    | 17 ++++++
 drivers/md/dm-stripe.c        | 23 +++++++++
 drivers/md/dm.c               | 30 +++++++++++
 drivers/nvdimm/pmem.c         | 97 ++++++++++++++++++++++-------------
 drivers/s390/block/dcssblk.c  | 15 ++++++
 fs/dax.c                      | 59 ++++++++++-----------
 fs/iomap/buffered-io.c        |  9 +---
 include/linux/dax.h           | 21 +++-----
 include/linux/device-mapper.h |  3 ++
 11 files changed, 221 insertions(+), 91 deletions(-)
Signature · 1 line
2.20.1