Skip to content

Add Cortina Access basic DM drivers

Tom Rini u-boot 4 versions New

Get series with b4
b4 am 20200124195215.GW26536@bill-the-cat

Versions newest first · linked by author and title

  1. v2 Latest posting 4/40 of 7 patches 0 repliesNew
  2. v2 posting 3/40 of 7 patches 0 repliesSuperseded
  3. v2 posting 2/40 of 7 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v2 posting 1/40 of 7 patches0 repliesSuperseded

Patches in v2 posting 4/4 No applies recorded yet

None of the 7 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/7] Add Cortina Access basic DM drivers
Quoted 4 lines · Alex Nemirovsky

one last thing, since we are moving SoC code out of the board tree. would you prefer each SoC specific header directly in top level include directory or within nclude/cortina subdirectory? i.e. include/ca7774.h vs include/cortina/ca7774.h?

Inside of arch/arm/include/asm/mach-caxxxx/ you can split things how you think makes the most sense. There's many other examples to look at here.

Quoted 42 lines
Quoted 41 lines · Tom Rini
Quoted 3 lines · Alex Nemirovsky

Sounds good Tom. We will send the next series with the ARMv8 low_level.S moved to arch/mach-caxxxx/ Thanks for you guidance. Did you see anything else in 2nd series that needs modified before we send series 3 or can we assume those are fine to avoid sending another series after this issues is fixed in series 3?

That was all I noticed, thanks again.

Quoted 27 lines
Quoted 26 lines · Tom Rini
Quoted 12 lines · Alex Nemirovsky

Looking inside
grep -h CA board/cortina/common/armv8/lowlevel_init.S #if defined(CONFIG_SOC_CA7774)
#if defined(CONFIG_SOC_CA8277B)

as we understand it, the alternative would lead to maintaining duplicate but slightly different code for each ARM based SoC in arch/arm/mach-ca7774
arch/arm/mach-ca8277B
arch/arm/mach-ca7742
arch/arm/mach-ca8279
arch/arm/mach-caXnnn

Quoted 3 lines

correct? or should we simply create a arch/arm/mach-caxxxx, arch/mips/mach-caxxxx, arch/xtensa/mach-axxxx, arch/riscv/mach-caxxxx, etc to maintain similar changes to each arch related custom code which varies slightly for each SoC variation within each architecture?
What’s best to avoid maintaining duplicate code across SoC variations within the same ISA family?

I would hope we can get by with arch/arm/mach-caxxxx or so and board/cortina/common/. How are you handling common code in the linux kernel?

Signature · 1 line
Tom
Signature · 1 line
Tom
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200124/b4f76a3b/attachment.sig>