Skip to content

mptcp: fix sockopt crash and lockdep splats

Florian Westphal netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4mptcp: defer freeing of cached ext until last momentnet/mptcp/protocol.c+4 -20 replies
2/4mptcp: fix panic on user pointer accessnet/mptcp/protocol.c+22 -180 replies
3/4mptcp: avoid a lockdep splat when mcast group was joinednet/mptcp/protocol.c+6 -20 replies
4/4mptcp: handle tcp fallback when using syn cookiesinclude/linux/tcp.h net/ipv4/syncookies.c net/ipv4/tcp_input.c +2 more+14 -30 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchChristoph Paasch
1/4
2/4
3/4
4/4T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/4] mptcp: fix sockopt crash and lockdep splats

Christoph Paasch reported a few bugs and lockdep splats triggered by syzkaller.

One patch fixes a crash in set/getsockopt.
Two patches fix lockdep splats related to the order in which RTNL and socket lock are taken.

Last patch fixes out-of-bounds access when TCP syncookies are used.

Change since last iteration on mptcp-list:
- add needed refcount in patch 2
- call tcp_get/setsockopt directly in patch 2

Other patches unchanged except minor amends to commit messages.

 include/linux/tcp.h   |  2 --
 net/ipv4/syncookies.c |  4 ++++
 net/ipv4/tcp_input.c  |  3 +++
 net/ipv6/syncookies.c |  3 +++
 net/mptcp/protocol.c  | 54 ++++++++++++++++++++++++++++++++----------------------
 net/mptcp/subflow.c   |  5 ++++-
 6 files changed, 46 insertions(+), 25 deletions(-)