Skip to content

RFC devlink direct region reading

Jacob Keller netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest0 of 13 patches 3 repliesIn review

Patches in v1 No applies recorded yet

None of the 13 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchJakub Kicinski
SeriesR-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 00/13] devlink direct region reading

As per the previous discussions about supporting devlink region snapshot triggers and direct region writes, this is an RFC patch series to implement these changes. I fully expect to need revisions to this series, and the ice driver changes will need to go through the normal intel-wired-lan queue process.

The final patches implement support for directly reading from a region without a snapshot. In order to have context on how and why this is implemented, the ice driver is modified to support devlink and expose a region. The series can be broken down into multiple parts or stages, as described below.

The first 4 patches modify devlink regions to support a new devlink_region_ops structure, and then implement a new op for requesting that the driver capture an immediate snapshot. Support for that is then implemented in the netdevsim driver. This was previously discussed on the list:

https://lore.kernel.org/netdev/[email protected]/

The only major change is to convert to using an operation in the devlink_region_ops structure instead of passing the pointer as an argument to devlink_region_create. This makes it easier for regions to support additional operations in the future.

Following this section is 3 patches to the ice driver implementing a function to easily read portions of the NVM contents as flat addressable memory. The current .get_eeprom function is updated to support reading from the entire NVM.

There is a patch to add devlinkm_alloc as a devres based managed allocation for the devlink_alloc call.

Following this are 4 patches to implement basic devlink support for the ice driver. This includes a simple .get_info handler.

Finally, the last 3 patches implement a new region in the ice driver for accessing the shadow RAM. This region will support the immediate trigger operation as well as a new read operation that enables directly reading from the shadow RAM without a region.

I expect that this series is not yet ready to land and am sending it primarily as a discussion point on the changes to the devlink core code. I expect feedback and the need to change and improve the implementation.

It's likely that the actual submissions can be broken up into smaller series, for example the basic ice devlink support going first followed by a separate series for the region changes.

I've also submitted iproute2 patches for implementing the ability to request snapshots and read from the region directly.

Jacob Keller (12):
devlink: prepare to support region operations
devlink: add functions to take snapshot while locked
devlink: add operation to take an immediate snapshot
netdevsim: support taking immediate snapshot via devlink
ice: use __le16 types for explicitly Little Endian values
ice: create function to read a section of the NVM and Shadow RAM
ice: enable initial devlink support for function zero
ice: add basic handler for devlink .info_get
ice: add board identifier info to devlink .info_get
ice: add a devlink region to dump shadow RAM contents
devlink: support directly reading from region memory
ice: support direct read of the shadow ram region

Jesse Brandeburg (1):
ice: implement full NVM read from ETHTOOL_GEEPROM

 drivers/net/ethernet/intel/Kconfig            |   1 +
 drivers/net/ethernet/intel/ice/Makefile       |   1 +
 drivers/net/ethernet/intel/ice/ice.h          |   7 +
 .../net/ethernet/intel/ice/ice_adminq_cmd.h   |   3 +
 drivers/net/ethernet/intel/ice/ice_common.c   |  61 +++
 drivers/net/ethernet/intel/ice/ice_common.h   |   5 +-
 drivers/net/ethernet/intel/ice/ice_devlink.c  | 427 ++++++++++++++++++
 drivers/net/ethernet/intel/ice/ice_devlink.h  |  20 +
 drivers/net/ethernet/intel/ice/ice_ethtool.c  |  37 +-
 drivers/net/ethernet/intel/ice/ice_main.c     |  22 +
 drivers/net/ethernet/intel/ice/ice_nvm.c      | 211 +++------
 drivers/net/ethernet/intel/ice/ice_nvm.h      |   7 +
 drivers/net/ethernet/intel/ice/ice_type.h     |   1 +
 drivers/net/ethernet/mellanox/mlx4/crdump.c   |  25 +-
 drivers/net/netdevsim/dev.c                   |  44 +-
 include/net/devlink.h                         |  28 +-
 include/uapi/linux/devlink.h                  |   2 +
 net/core/devlink.c                            | 246 +++++++---
 18 files changed, 918 insertions(+), 230 deletions(-)
 create mode 100644 drivers/net/ethernet/intel/ice/ice_devlink.c
 create mode 100644 drivers/net/ethernet/intel/ice/ice_devlink.h
Signature · 1 line
2.25.0.rc1