Skip to content

ata: kill ATA_DEBUG

Hannes Reinecke linux-ide linux-renesas-soc oe-kbuild-all 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest40 patches 7 repliesIn review
  2. v146 patches 49 repliesSuperseded

Changes to v1 from the cover letter

- Included reviews from Bartlomiej
- Merged patches

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/40libata: drop BPRINTK()include/linux/libata.h+0 -20 replies
2/40libata.h: whitespace and indentation fixesinclude/linux/libata.h+26 -150 replies
3/40libata-transport: Whitespace cleanupdrivers/ata/libata-transport.c+7 -70 replies
4/40libata: move ata_{port,link,dev}_dbg to standard dev_XXX() macrosdrivers/ata/ahci.c drivers/ata/libata-acpi.c drivers/ata/libata-core.c +1 more+43 -1175 replies
5/40libata: move __func__ into ata_{port,link,dev}_dbg() helperdrivers/ata/libata-acpi.c drivers/ata/libata-core.c drivers/ata/libata-sff.c +1 more+14 -170 replies
6/40libata: remove pointless debugging messagesdrivers/ata/acard-ahci.c drivers/ata/ahci.c drivers/ata/libahci.c +3 more+0 -210 replies
7/40ata_piix: remove debugging messagesdrivers/ata/ata_piix.c+0 -30 replies
8/40libata-core: remove pointless debugging messagesdrivers/ata/libata-core.c+0 -50 replies
9/40libata: Add ata_port_classify() helperdrivers/ata/libahci.c drivers/ata/libata-core.c drivers/ata/libata-sff.c +4 more+63 -200 replies
10/40libata: move ata_dump_id() to dynamic debuggingdrivers/ata/libata-core.c+10 -280 replies
11/40libata: sanitize ATA_HORKAGE_DUMP_IDdrivers/ata/libata-core.c+2 -20 replies
12/40sata_mv: replace DPRINTK with 'pci_dump' module parameterdrivers/ata/sata_mv.c+49 -390 replies
13/40sata_mv: kill 'port' argument in mv_dump_all_regs()drivers/ata/sata_mv.c+7 -170 replies
14/40sata_sx4: move DPRINTK to VPRINTKdrivers/ata/sata_sx4.c+1 -10 replies
15/40libata: add reset tracepointsdrivers/ata/libata-eh.c include/trace/events/libata.h+114 -30 replies
16/40libata: drop DPRINTK() calls in resetdrivers/ata/ahci.c drivers/ata/ahci_qoriq.c drivers/ata/libahci.c +6 more+1 -570 replies
17/40libata: tracepoints for bus-master DMAdrivers/ata/libata-core.c drivers/ata/libata-sff.c include/trace/events/libata.h+123 -50 replies
18/40libata: drop debugging statements for bus-master DMAdrivers/ata/libata-sff.c drivers/ata/pata_octeon_cf.c drivers/ata/pata_pdc202xx_old.c +3 more+7 -440 replies
19/40pata_octeon_cf: add bmdma tracepoints and drop DPRINTK() callsdrivers/ata/pata_octeon_cf.c+4 -30 replies
20/40pata_arasan_cf: use generic tracepointsdrivers/ata/pata_arasan_cf.c+3 -00 replies
21/40sata_dwc_460ex: use generic tracepointsdrivers/ata/sata_dwc_460ex.c+4 -350 replies
22/40sata_nv: use generic tracepointsdrivers/ata/sata_nv.c+3 -80 replies
23/40libata-sff: tracepoints for HSM state machinedrivers/ata/libata-sff.c drivers/ata/libata-trace.c include/trace/events/libata.h+130 -70 replies
24/40libata-sff: add tracepoints for ata_sff_flush_pio_task()drivers/ata/libata-sff.c include/trace/events/libata.h+26 -40 replies
25/40libata-scsi: drop DPRINTK calls for cdb translationdrivers/ata/libata-scsi.c+3 -170 replies
26/40libata: add tracepoints for ATA error handlingdrivers/ata/libata-eh.c include/trace/events/libata.h+67 -30 replies
27/40libata: drop DPRINTK() calls during ATA error handlingdrivers/ata/libata-eh.c drivers/ata/libata-pmp.c+0 -200 replies
28/40libata-eh: remove DPRINTK() calls for request sensedrivers/ata/libata-eh.c+0 -40 replies
29/40pata_octeon_cf: move DPRINTK to VPRINTKdrivers/ata/pata_octeon_cf.c+2 -20 replies
30/40pdc_adma: move DPRINTK to VPRINTKdrivers/ata/pdc_adma.c+1 -10 replies
31/40sata_rcar: move DPRINTK to VPRINTKdrivers/ata/sata_rcar.c+1 -10 replies
32/40sata_qstor: move DPRINTK to VPRINTKdrivers/ata/sata_qstor.c+1 -10 replies
33/40pata_pdc2027x: Replace PDPRINTK() with standard ata loggingdrivers/ata/pata_pdc2027x.c+36 -450 replies
34/40sata_nv: move DPRINTK to ata debuggingdrivers/ata/sata_nv.c+7 -70 replies
35/40sata_fsl: move DPRINTK to ata debuggingdrivers/ata/sata_fsl.c+46 -441 reply
36/40libata-core: move DPRINTK to ata debuggingdrivers/ata/libata-core.c+11 -90 replies
37/40libata: remove DPRINTK() macroinclude/linux/libata.h+0 -20 replies
38/40libata: kill ATA_MSG_INFOdrivers/ata/libata-core.c include/linux/libata.h+3 -50 replies
39/40libata: kill ATA_MSG_CTLdrivers/ata/libata-core.c include/linux/libata.h+2 -50 replies
40/40libata: remove references to ATA_DEBUGdrivers/ata/libata-core.c include/linux/libata.h+0 -70 replies

Reviews trailers per patch

38 of 40 patches have a Reviewed-by or Acked-by.

PatchBartlomiej Zolnierkiewicz
1/40R-b
2/40R-b
3/40R-b
4/40R-b
5/40R-b
6/40R-b
7/40R-b
8/40R-b
9/40R-b
10/40R-b
11/40R-b
12/40R-b
13/40R-b
14/40R-b
15/40R-b
16/40R-b
17/40
18/40R-b
19/40R-b
20/40R-b
21/40R-b
22/40R-b
23/40
24/40R-b
25/40R-b
26/40R-b
27/40R-b
28/40R-b
29/40R-b
30/40R-b
31/40R-b
32/40R-b
33/40R-b
34/40R-b
35/40R-b
36/40R-b
37/40R-b
38/40R-b
39/40R-b
40/40R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCHv3 00/40] ata: kill ATA_DEBUG

Hi all,

this is a rewrite of an earlier patchset titled 'ata: move DPRINTK to dynamic debugging'.
The overall idea is that it's really tiresome to having to recompile the kernel every time one wants or needs to debug ata issues, especially as the kernel already provides mechanism for dynamic debugging messages.

At the same time dynamic debugging does increase the load on the logging subsystem, and things like printk() are poorly suited for high-speed logging.

So this patchset does several things:
- cleans up the logging messages by removing duplicate or pointless messages
- Converts I/O and error handling related messages to tracepoints
- Moves all remaining messages over to dynamic debugging

With that ATA_DEBUG can be killed.

Note, I'll be preparing an additional patchset for killing off ATA_VERBOSE_DEBUG, too, but wanted to get this one out first before it becomes too large.

As usual, comments and reviews are welcome.

Changes to v1:
- Included reviews from Bartlomiej
- Merged patches

Changes to v2:
- Included reviews from Barlomiej

Hannes Reinecke (40):
libata: drop BPRINTK()
libata.h: whitespace and indentation fixes
libata-transport: Whitespace cleanup
libata: move ata_{port,link,dev}_dbg to standard dev_XXX() macros
libata: move __func__ into ata_{port,link,dev}_dbg() helper
libata: remove pointless debugging messages
ata_piix: remove debugging messages
libata-core: remove pointless debugging messages
libata: Add ata_port_classify() helper
libata: move ata_dump_id() to dynamic debugging
libata: sanitize ATA_HORKAGE_DUMP_ID
sata_mv: replace DPRINTK with 'pci_dump' module parameter
sata_mv: kill 'port' argument in mv_dump_all_regs()
sata_sx4: move DPRINTK to VPRINTK
libata: add reset tracepoints
libata: drop DPRINTK() calls in reset
libata: tracepoints for bus-master DMA
libata: drop debugging statements for bus-master DMA
pata_octeon_cf: add bmdma tracepoints and drop DPRINTK() calls
pata_arasan_cf: use generic tracepoints
sata_dwc_460ex: use generic tracepoints
sata_nv: use generic tracepoints
libata-sff: tracepoints for HSM state machine
libata-sff: add tracepoints for ata_sff_flush_pio_task()
libata-scsi: drop DPRINTK calls for cdb translation
libata: add tracepoints for ATA error handling
libata: drop DPRINTK() calls during ATA error handling
libata-eh: remove DPRINTK() calls for request sense
pata_octeon_cf: move DPRINTK to VPRINTK
pdc_adma: move DPRINTK to VPRINTK
sata_rcar: move DPRINTK to VPRINTK
sata_qstor: move DPRINTK to VPRINTK
pata_pdc2027x: Replace PDPRINTK() with standard ata logging
sata_nv: move DPRINTK to ata debugging
sata_fsl: move DPRINTK to ata debugging
libata-core: move DPRINTK to ata debugging
libata: remove DPRINTK() macro
libata: kill ATA_MSG_INFO
libata: kill ATA_MSG_CTL
libata: remove references to ATA_DEBUG

 drivers/ata/acard-ahci.c        |   4 -
 drivers/ata/ahci.c              |  12 +-
 drivers/ata/ahci_qoriq.c        |   4 -
 drivers/ata/ata_piix.c          |   3 -
 drivers/ata/libahci.c           |  15 +-
 drivers/ata/libata-acpi.c       |  62 +++----
 drivers/ata/libata-core.c       | 229 +++++++++---------------
 drivers/ata/libata-eh.c         |  47 ++---
 drivers/ata/libata-pmp.c        |   8 -
 drivers/ata/libata-scsi.c       |  20 +--
 drivers/ata/libata-sff.c        |  76 ++++----
 drivers/ata/libata-trace.c      |  29 ++++
 drivers/ata/libata-transport.c  |  14 +-
 drivers/ata/pata_arasan_cf.c    |   3 +
 drivers/ata/pata_octeon_cf.c    |  23 +--
 drivers/ata/pata_pdc2027x.c     |  81 ++++-----
 drivers/ata/pata_pdc202xx_old.c |   2 -
 drivers/ata/pata_sil680.c       |   1 -
 drivers/ata/pdc_adma.c          |   2 +-
 drivers/ata/sata_dwc_460ex.c    |  57 +-----
 drivers/ata/sata_fsl.c          | 102 +++++------
 drivers/ata/sata_inic162x.c     |   2 +-
 drivers/ata/sata_mv.c           | 110 ++++++------
 drivers/ata/sata_nv.c           |  29 ++--
 drivers/ata/sata_qstor.c        |   2 +-
 drivers/ata/sata_rcar.c         |   8 +-
 drivers/ata/sata_sil24.c        |   5 +-
 drivers/ata/sata_sx4.c          |   2 +-
 include/linux/libata.h          | 105 +++++------
 include/trace/events/libata.h   | 377 ++++++++++++++++++++++++++++++++++++++++
 30 files changed, 809 insertions(+), 625 deletions(-)
Signature · 1 line
2.16.4