Skip to content

vfs: have syncfs() return error when there are writeback errors

Jeff Layton linux-api linux-fsdevel lkml 6 versions – Applied

Status from this message: [merged] buffer-record-blockdev-write-errors-in-super_block-that-it-backs.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest posting 2/22 patches 2 repliesApplied 2/2
  2. v6 posting 1/22 patches 1 replySuperseded
  3. v52 patches 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v4 posting 2/22 patches4 repliesSuperseded
v4 posting 1/22 patches1 replySuperseded
v33 patches11 repliesSuperseded

Changes in v6 from the cover letter

- use READ_ONCE to ensure that compiler doesn't optimize away local var

Patches in v6 posting 2/2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2vfs: track per-sb writeback errors and report them to syncfsdrivers/dax/device.c fs/file_table.c fs/open.c +3 more+27 -50 repliesApplied
2/2buffer: record blockdev write errors in super_block that it backsfs/buffer.c+7 -00 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJan Kara
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 RESEND 0/2] vfs: have syncfs() return error when there are writeback errors

Just a resend since this hasn't been picked up yet. No real changes from the last set (other than adding Jan's Reviewed-bys). Latest cover letter follows:

--------------------------8<----------------------------

v6:
- use READ_ONCE to ensure that compiler doesn't optimize away local var

The only difference from v5 is the change to use READ_ONCE to fetch the bd_super pointer, to ensure that the compiler doesn't refetch it afterward. Many thanks to Jan K. for the explanation!

Jeff Layton (2):
vfs: track per-sb writeback errors and report them to syncfs
buffer: record blockdev write errors in super_block that it backs

 drivers/dax/device.c    |  1 +
 fs/buffer.c             |  7 +++++++
 fs/file_table.c         |  1 +
 fs/open.c               |  3 +--
 fs/sync.c               |  6 ++++--
 include/linux/fs.h      | 16 ++++++++++++++++
 include/linux/pagemap.h |  5 ++++-
 7 files changed, 34 insertions(+), 5 deletions(-)
Signature · 1 line
2.26.1