mlx: fix build with -fno-common (gcc 10)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest3 patches 1 replyIn review
- v23 patches 0 repliesSuperseded
- v13 patches 2 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | common/mlx5: split glue initializationdrivers/ | +47 | 0 replies | |
| 2/3 | common/mlx5: fix build with -fno-commondrivers/ drivers/ | +4 | 0 replies | |
| 3/3 | net/mlx4: fix build with -fno-commondrivers/ drivers/ drivers/ | +6 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Matan Azrad |
|---|---|
| 1/3 | A-b |
| 2/3 | A-b |
| 3/3 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [dpdk-dev] [PATCH v3 0/3] mlx: fix build with -fno-common (gcc 10)
In GCC 10, -fno-common will be the default.
There are 2 ways of solving issues:
- add -fcommon
- stop allocating variables in .h files
In this patchset, the variables are declared extern, because it is cleaner anyway.
v2: do not initialize global variables and Cc stable
v3: fix rebase
Thomas Monjalon (3):
common/mlx5: split glue initialization
common/mlx5: fix build with -fno-common
net/mlx4: fix build with -fno-common
drivers/common/mlx5/mlx5_common.c | 82 +++++++++++++++++++------------ drivers/common/mlx5/mlx5_glue.h | 2 +- drivers/net/mlx4/mlx4.c | 4 ++ drivers/net/mlx4/mlx4_glue.h | 2 +- drivers/net/mlx4/mlx4_rxtx.h | 2 +- 5 files changed, 57 insertions(+), 35 deletions(-)
Signature · 1 line
2.26.0