blk-mq/scsi: tracking device queue depth via sbitmap
Status from this message: Applied to 5.13/scsi-queue, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v8 Latest13 patches 1 replyApplied
- v713 patches 4 repliesSuperseded
- v613 patches 1 replySuperseded
Earlier versions · 6
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v5 posting 2/2 | 13 patches | 1 reply | Superseded | |
| v5 posting 1/2 | 9 of 13 patches | 1 reply | Superseded | |
| v4 | 12 patches | 19 replies | Superseded | |
| v3 | 12 patches | 14 replies | Superseded | |
| v2 | 10 patches | 0 replies | Superseded | |
| v1 | 10 patches | 4 replies | Superseded |
Changes in v8 from the cover letter
- fix handling for device_blocked, only patch 13 is changed
- rebase on latest for-5.12/block, only patch 10 is changed
Patches in v8 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | sbitmap: remove sbitmap_clear_bit_unlockinclude/ | +0 | 0 replies | |
| 2/13 | sbitmap: maintain allocation round_robin in sbitmapblock/ block/ drivers/ +2 more | +29 | 0 replies | |
| 3/13 | sbitmap: add helpers for updating allocation hintlib/ | +54 | 0 replies | |
| 4/13 | sbitmap: move allocation hint into sbitmapblock/ block/ drivers/ +2 more | +96 | 0 replies | |
| 5/13 | sbitmap: export sbitmap_weightinclude/ lib/ | +16 | 0 replies | |
| 6/13 | sbitmap: add helper of sbitmap_calculate_shiftinclude/ lib/ | +21 | 0 replies | |
| 7/13 | blk-mq: add callbacks for storing & retrieving budget tokendrivers/ include/ include/ | +29 | 0 replies | |
| 8/13 | blk-mq: return budget token from .get_budget callbackblock/ block/ block/ +2 more | +72 | 0 replies | |
| 9/13 | scsi: put hot fields of scsi_host_template into one cachelineinclude/ | +39 | 0 replies | |
| 10/13 | megaraid_sas: v2 replace sdev_busy with local counterdrivers/ drivers/ | +41 | 0 replies | |
| 11/13 | scsi: add scsi_device_busy() to read sdev->device_busydrivers/ drivers/ drivers/ +3 more | +11 | 0 replies | |
| 12/13 | scsi: make sure sdev->queue_depth is <= max(shost->can_queue, 1024)drivers/ | +11 | 0 replies | |
| 13/13 | scsi: replace sdev->device_busy with sbitmapdrivers/ drivers/ drivers/ +3 more | +50 | 0 replies |
Reviews trailers per patch
All 13 patches have a Reviewed-by or Acked-by.
| Patch | Hannes Reinecke | Sumanesh Samanta | Johannes Thumshirn | Christoph Hellwig |
|---|---|---|---|---|
| 1/13 | R-b | T-b | R-b | |
| 2/13 | R-b | T-b | ||
| 3/13 | R-b | T-b | ||
| 4/13 | R-b | T-b | ||
| 5/13 | R-b | T-b | ||
| 6/13 | R-b | T-b | ||
| 7/13 | R-b | T-b | ||
| 8/13 | R-b | T-b | ||
| 9/13 | R-b | T-b | R-b | |
| 10/13 | R-b | |||
| 11/13 | R-b | T-b | ||
| 12/13 | R-b | T-b | ||
| 13/13 | R-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH V8 00/13] blk-mq/scsi: tracking device queue depth via sbitmap
Hi,
scsi uses one global atomic variable to track queue depth for each LUN/request queue. This way can't scale well when there is lots of CPU cores and the disk is very fast. Broadcom guys has complained that their high end HBA can't reach top performance because .device_busy is operated in IO path.
Replace the atomic variable sdev->device_busy with sbitmap for tracking scsi device queue depth.
Test on scsi_debug shows this way improve IOPS > 20%. Meantime the IOPS difference is just ~1% compared with bypassing .device_busy on scsi_debug via patches[1]
The 1st 6 patches moves percpu allocation hint into sbitmap, since the improvement by doing percpu allocation hint on sbitmap is observable. Meantime export helpers for SCSI.
Patch 7 and 8 prepares for the conversion by returning budget token from .get_budget callback, meantime passes the budget token to driver via 'struct blk_mq_queue_data' in .queue_rq().
The last four patches changes SCSI for switching to track device queue depth via sbitmap.
The patchset have been tested by Broadcom, and obvious performance boost can be observed on megaraid_sas.
V8:
- fix handling for device_blocked, only patch 13 is changed
- rebase on latest for-5.12/block, only patch 10 is changed
V7:
- fix build failure on drivers/vhost/scsi.c, only patch 2 & 4 are changed
V6:
- rebase on for-5.12/block
V5:
- add comment on sbitmap_weight()
- add patch 'megaraid_sas: v2 replace sdev_busy with local counter' for fixing build failure
V4:
- limit max sdev->queue_depth as max(1024, shost->can_queue)
- simplify code for moving per-cpu allocation hint into sbitmap
V3:
- rebase on both for-5.10/block and 5.10/scsi-queue.
V2:
- fix one build failure
Kashyap Desai (1):
megaraid_sas: v2 replace sdev_busy with local counter
Ming Lei (12):
sbitmap: remove sbitmap_clear_bit_unlock
sbitmap: maintain allocation round_robin in sbitmap
sbitmap: add helpers for updating allocation hint
sbitmap: move allocation hint into sbitmap
sbitmap: export sbitmap_weight
sbitmap: add helper of sbitmap_calculate_shift
blk-mq: add callbacks for storing & retrieving budget token
blk-mq: return budget token from .get_budget callback
scsi: put hot fields of scsi_host_template into one cacheline
scsi: add scsi_device_busy() to read sdev->device_busy
scsi: make sure sdev->queue_depth is <= max(shost->can_queue, 1024)
scsi: replace sdev->device_busy with sbitmap
block/blk-mq-sched.c | 17 +- block/blk-mq.c | 38 ++-- block/blk-mq.h | 25 ++- block/kyber-iosched.c | 3 +- drivers/message/fusion/mptsas.c | 2 +- drivers/scsi/megaraid/megaraid_sas.h | 2 + drivers/scsi/megaraid/megaraid_sas_fusion.c | 47 ++++- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 2 +- drivers/scsi/scsi.c | 13 ++ drivers/scsi/scsi_lib.c | 71 ++++--- drivers/scsi/scsi_priv.h | 3 + drivers/scsi/scsi_scan.c | 23 ++- drivers/scsi/scsi_sysfs.c | 4 +- drivers/scsi/sg.c | 2 +- drivers/vhost/scsi.c | 4 +- include/linux/blk-mq.h | 13 +- include/linux/sbitmap.h | 85 +++++--- include/scsi/scsi_cmnd.h | 2 + include/scsi/scsi_device.h | 8 +- include/scsi/scsi_host.h | 72 ++++--- lib/sbitmap.c | 210 +++++++++++--------- 21 files changed, 432 insertions(+), 214 deletions(-)
Signature · 1 line
2.29.2