Skip to content

one way barrier for split vring idx

Joyce Kong dpdk-dev 5 versions – Applied

Status from this message: Applied to dpdk-next-virtio/master.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 3 repliesApplied
  2. v42 patches 7 repliesApplied
  3. v32 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v22 patches4 repliesSuperseded
v12 patches0 repliesSuperseded

Changes in v5 from the cover letter

Fix the compling issue when 'CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=y' is enabled.

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/2virtio: one way barrier for split vring used idxdrivers/net/virtio/virtio_ethdev.c drivers/net/virtio/virtio_ring.h drivers/net/virtio/virtio_rxtx.c +6 more+58 -482 replies
2/2virtio: one way barrier for split vring avail idxdrivers/net/virtio/virtqueue.h lib/librte_vhost/virtio_net.c+23 -110 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchGavin HuMaxime Coquelin
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [dpdk-dev] [PATCH v5 0/2] one way barrier for split vring idx

This patchset replaces the two-way barriers with C11 one-way barriers for split vring idx, when the frontend and backend are implemented in software.

By doing PVP benchmarking, the test result of 2c1q showed the throughput increased 20% with the 0.001% of acceptable loss rate on Thunderx2 platform.[1]

By doing vhost-user + virtio-user case benchmarking, 4% performance gain was measured on Thunderx2 platform by 2c1q RFC2544 test of 0.001% loss, and 4.7% performance was improved on Dell platform by 1c1q RFC2544 test of zero packet loss.[2]

[1]https://doc.dpdk.org/guides/howto/pvp_reference_benchmark.html [2]https://doc.dpdk.org/dts/test_plans/pvp_multi_paths_performance_test_plan.html
PVP test with virtio 1.0 normal path

v5:
Fix the compling issue when 'CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=y' is enabled.

v4:
Remove some duplicated code comment.

v3:
Modify some style error.

v2:
Add test performance statistics.

Joyce Kong (2):
virtio: one way barrier for split vring used idx
virtio: one way barrier for split vring avail idx

 drivers/net/virtio/virtio_ethdev.c            |  7 +--
 drivers/net/virtio/virtio_ring.h              |  2 +-
 drivers/net/virtio/virtio_rxtx.c              | 35 ++++-------
 drivers/net/virtio/virtio_rxtx_simple_neon.c  |  5 +-
 drivers/net/virtio/virtio_rxtx_simple_sse.c   |  4 +-
 .../net/virtio/virtio_user/virtio_user_dev.c  |  8 ++-
 drivers/net/virtio/virtqueue.c                |  2 +-
 drivers/net/virtio/virtqueue.h                | 58 ++++++++++++++++---
 lib/librte_vhost/virtio_net.c                 | 19 +++---
 9 files changed, 81 insertions(+), 59 deletions(-)
Signature · 1 line
2.17.1