Skip to content

efi/x86: Some mixed mode fixes

Ard Biesheuvel linux-efi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3efi/x86: align GUIDs to their size in the mixed mode runtime wrapperarch/x86/platform/efi/efi_64.c+21 -42 replies
2/3efi/x86: remove support for EFI time and counter services in mixed modearch/x86/platform/efi/efi_64.c+5 -760 replies
3/3efi/x86: Handle by-ref arguments covering multiple pages in mixed modearch/x86/platform/efi/efi_64.c+26 -190 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchHans de Goede
1/3T-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] efi/x86: Some mixed mode fixes

Hans reports that v5.6-rc1 triggers a WARN() when booting in mixed mode, which appears to be due to the fact that a GUID argument allocated on the vmap'ed stack and passed by reference to the EFI runtime services is no longer aligned to its size, which is what the mixed mode runtime wrappers expect.

Let's fix this in a way that doesn't burden the caller, and copy the GUID into a suitably aligned buffer in the runtime wrappers. (#1)

Then, patches #2 and #3 are additional cleanup and correctness fixes for the mixed mode runtime wrappers.

Cc Hans de Goede <[email protected]>
Cc Arvind Sankar <[email protected]>
Cc Andy Lutomirski <[email protected]>

Ard Biesheuvel (3):
efi/x86: align GUIDs to their size in the mixed mode runtime wrapper efi/x86: remove support for EFI time and counter services in mixed
mode
efi/x86: Handle by-ref arguments covering multiple pages in mixed mode

 arch/x86/platform/efi/efi_64.c | 151 +++++++-------------
 1 file changed, 52 insertions(+), 99 deletions(-)
Signature · 1 line
2.17.1