Skip to content

RFC barrier fix and optimization for mlx5 on aarch64

Gavin Hu dpdk-dev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6net/mlx5: relax the barrier for UAR writedrivers/net/mlx5/mlx5_rxtx.h+1 -10 replies
2/6net/mlx5: use cio barrier before the BF WQEdrivers/net/mlx5/mlx5_rxtx.h+1 -10 replies
3/6net/mlx5: add missing barrierdrivers/net/mlx5/mlx5_rxq.c+2 -10 replies
4/6net/mlx5: add descriptive comment for a barrierdrivers/net/mlx5/mlx5_rxtx.h+5 -00 replies
5/6net/mlx5: non-cacheable mapping defaulted for aarch64drivers/net/mlx5/mlx5_txq.c+4 -00 replies
6/6net/mlx5: relaxed ordering for multi-packet RQ buffer refcntdrivers/net/mlx5/mlx5_rxq.c drivers/net/mlx5/mlx5_rxtx.c drivers/net/mlx5/mlx5_rxtx.h+11 -90 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPhil YangGavin HuSteve CapperRuifeng WangJerin JacobDavid ChristensenAjit KhapardeKonstantin AnanyevAlexander KozyrevHonnappa NagarahalliViacheslav Ovsiienko
SeriesR-b R-b R-b R-b R-b T-b T-b T-b T-b A-b A-b A-b A-b A-b A-b A-b R-b R-b A-b A-b A-b A-b A-b A-b R-b A-b
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 11 reviewers.

Read the v1 thread

Cover letter [dpdk-dev] [PATCH RFC v1 0/6] barrier fix and optimization for mlx5 on aarch64

Using just sufficient barriers really matters to performance. Insufficient barriers will cause issues while barriers stronger than required, especially in the fast path is a performance killer.

In the joint preliminary testing between Arm and Ampere, 8%~13% performance was measured.

Gavin Hu (5):
net/mlx5: relax the barrier for UAR write net/mlx5: use cio barrier before the BF WQE net/mlx5: add missing barrier
net/mlx5: add descriptive comment for a barrier net/mlx5: non-cacheable mapping defaulted for aarch64

Phil Yang (1):
net/mlx5: relaxed ordering for multi-packet RQ buffer refcnt

 drivers/net/mlx5/mlx5_rxq.c  |  5 +++--
 drivers/net/mlx5/mlx5_rxtx.c | 16 +++++++++-------
 drivers/net/mlx5/mlx5_rxtx.h | 11 ++++++++---
 drivers/net/mlx5/mlx5_txq.c  |  4 ++++
 4 files changed, 24 insertions(+), 12 deletions(-)
Signature · 1 line
2.17.1