Skip to content

Documentation/litmus-tests: Add litmus tests for atomic APIs

Boqun Feng linux-arch linux-doc lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 7 repliesIn review
  2. v35 patches 13 repliesApplied
  3. v2 RFC4 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v1 RFC3 patches24 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4tools/memory-model: Add an exception for limitations on _unless() familytools/memory-model/README+7 -30 replies
2/4Documentation/litmus-tests: Introduce atomic directoryDocumentation/litmus-tests/atomic/README+4 -00 replies
3/4Documentation/litmus-tests/atomic: Add a test for atomic_set()Documentation/atomic_t.txt Documentation/litmus-tests/atomic/Atomic-RMW-ops-are-atomic-WRT-atomic_set.litmus Documentation/litmus-tests/atomic/README+38 -71 reply
4/4Documentation/litmus-tests/atomic: Add a test for smp_mb__after_atomic()Documentation/atomic_t.txt Documentation/litmus-tests/atomic/Atomic-RMW+mb__after_atomic-is-stronger-than-acquire.litmus Documentation/litmus-tests/atomic/README+42 -50 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndrea ParriAlan SternJoel Fernandes (Google)Boqun Feng
SeriesR-b A-b
1/4A-b
2/4A-b A-b
3/4A-b A-b
4/4A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 0/4] Documentation/litmus-tests: Add litmus tests for atomic APIs

A recent discussion raises up the requirement for having test cases for atomic APIs:

	https://lore.kernel.org/lkml/[email protected]/

, and since we already have a way to generate a test module from a litmus test with klitmus[1]. It makes sense that we add more litmus tests for atomic APIs. And based on the previous discussion, I create a new directory Documentation/atomic-tests and put these litmus tests here.

This patchset starts the work by adding the litmus tests which are already used in atomic_t.txt, and also improve the atomic_t.txt to make it consistent with the litmus tests.

Previous version:
v1: https://lore.kernel.org/linux-doc/[email protected]/
v2: https://lore.kernel.org/lkml/[email protected]/
v3: https://lore.kernel.org/linux-doc/[email protected]/

Changes since v3:

* Merge two patches on atomic-set litmus test into one as per
Alan. (Alan, you have acked only one of the two patches, so I don't add you acked-by for the combined patch).

* Move the atomic litmus tests into litmus-tests/atomic to align
with Joel's recent patches on RCU litmus tests.

I think we still haven't reach to a conclusion for the difference of atomic_add_unless() in herdtools, and I'm currently reading the source code of herd to resovle this. This is just an updated version to resolve ealier comments and react on Joel's RCU litmus tests.

Regards,
Boqun

[1]: http://diy.inria.fr/doc/litmus.html#klitmus

Boqun Feng (4):
tools/memory-model: Add an exception for limitations on _unless()
family
Documentation/litmus-tests: Introduce atomic directory Documentation/litmus-tests/atomic: Add a test for atomic_set() Documentation/litmus-tests/atomic: Add a test for

    smp_mb__after_atomic()
 Documentation/atomic_t.txt                    | 24 +++++++-------
 ...ter_atomic-is-stronger-than-acquire.litmus | 32 +++++++++++++++++++
 ...c-RMW-ops-are-atomic-WRT-atomic_set.litmus | 24 ++++++++++++++
 Documentation/litmus-tests/atomic/README      | 16 ++++++++++
 tools/memory-model/README                     | 10 ++++--
 5 files changed, 91 insertions(+), 15 deletions(-)
 create mode 100644 Documentation/litmus-tests/atomic/Atomic-RMW+mb__after_atomic-is-stronger-than-acquire.litmus
 create mode 100644 Documentation/litmus-tests/atomic/Atomic-RMW-ops-are-atomic-WRT-atomic_set.litmus
 create mode 100644 Documentation/litmus-tests/atomic/README
Signature · 1 line
2.25.1