RFC net: atlantic: MACSec support for AQC devices
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 RFC Latest16 patches 1 replyIn review
- v1 RFC18 patches 8 repliesSuperseded
Changes in v2 from the cover letter
- Split out patch for updating the SCI upon MAC address change.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/16 | net: introduce the MACSEC netdev featureinclude/ net/ | +4 | 0 replies | |
| 2/16 | net: add a reference to MACsec ops in net_deviceinclude/ | +9 | 0 replies | |
| 3/16 | net: macsec: allow to reference a netdev from a MACsec contextinclude/ | +4 | 0 replies | |
| 4/16 | net: macsec: add support for offloading to the MACdrivers/ include/ tools/ | +13 | 0 replies | |
| 5/16 | net: macsec: init secy pointer in macsec_contextdrivers/ | +15 | 0 replies | |
| 6/16 | net: macsec: allow multiple macsec devices with offloaddrivers/ | +1 | 0 replies | |
| 7/16 | net: macsec: support multicast/broadcast when offloadingdrivers/ | +38 | 0 replies | |
| 8/16 | net: macsec: add support for getting offloaded statsdrivers/ include/ | +235 | 0 replies | |
| 9/16 | net: macsec: report real_dev features when HW offloading is enableddrivers/ | +22 | 0 replies | |
| 10/16 | net: atlantic: MACSec offload skeletondrivers/ drivers/ drivers/ +7 more | +383 | 0 replies | |
| 11/16 | net: atlantic: MACSec egress offload HW bindingsdrivers/ drivers/ drivers/ +2 more | +1689 | 0 replies | |
| 12/16 | net: atlantic: MACSec egress offload implementationdrivers/ drivers/ | +677 | 0 replies | |
| 13/16 | net: atlantic: MACSec ingress offload HW bindingsdrivers/ drivers/ drivers/ +1 more | +1852 | 0 replies | |
| 14/16 | net: atlantic: MACSec ingress offload implementationdrivers/ drivers/ | +462 | 0 replies | |
| 15/16 | net: atlantic: MACSec offload statistics HW bindingsdrivers/ drivers/ drivers/ | +806 | 0 replies | |
| 16/16 | net: atlantic: MACSec offload statistics implementationdrivers/ drivers/ drivers/ +2 more | +766 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [RFC v2 00/16] net: atlantic: MACSec support for AQC devices
This RFC patchset introduces MACSec HW offloading support in Marvell(Aquantia) AQC atlantic driver.
This implementation is a joint effort of Marvell developers on top of the work started by Antoine Tenart.
RFC v2:
- Split out patch for updating the SCI upon MAC address change.
Sent as a net tree fix;
- Improved changelog for "net: macsec: add support for getting offloaded
stats" patch (patch 0008 in this series); - Don't fallback to s/w stats when offloading is enabled;
- Removed the "enable HW offloading by default" patch. Separate patch will be submitted to enable specifying the desired offload upon macsec device creation (upon ip link add);
- Accommodated comments related to "MACSec offload skeleton" patch.
v1: https://patchwork.ozlabs.org/cover/1238082/
Several patches introduce backward-incompatible changes and are subject for discussion/drop:
1) patch 0007:
multicast/broadcast when offloading is needed to handle ARP requests, because they have broadcast destination address;
With this patch we also match and encrypt/decrypt packets between macsec hw and realdev based on device's mac address.
This can potentially be used to support multiple macsec offloaded interfaces on top of one realdev.
However in some environments this could lead to problems, e.g. the 'bridge over macsec' configuration will expect the packets with unknown src MAC should come through macsec.
The patch is questionable, we've used it because our current hw setup and requirements both assume that the decryption is done based on mac address match only.
This could be changed by encrypting/decripting all the traffic (except control).
2) patch 0009:
real_dev features are now propagated to macsec device (when HW offloading is enabled), otherwise feature set might lead to HW reconfiguration during MACSec configuration.
Also, HW offloaded macsec should be able to keep LRO LSO features, since they are transparent for macsec engine (at least in our hardware).
Antoine Tenart (4):
net: introduce the MACSEC netdev feature
net: add a reference to MACsec ops in net_device
net: macsec: allow to reference a netdev from a MACsec context
net: macsec: add support for offloading to the MAC
Dmitry Bogdanov (8):
net: macsec: init secy pointer in macsec_context
net: macsec: allow multiple macsec devices with offload
net: macsec: add support for getting offloaded stats
net: atlantic: MACSec offload skeleton
net: atlantic: MACSec egress offload HW bindings
net: atlantic: MACSec egress offload implementation
net: atlantic: MACSec offload statistics HW bindings
net: atlantic: MACSec offload statistics implementation
Mark Starovoytov (4):
net: macsec: support multicast/broadcast when offloading
net: macsec: report real_dev features when HW offloading is enabled
net: atlantic: MACSec ingress offload HW bindings
net: atlantic: MACSec ingress offload implementation
drivers/net/ethernet/aquantia/Kconfig | 1 + .../net/ethernet/aquantia/atlantic/Makefile | 7 +- .../ethernet/aquantia/atlantic/aq_ethtool.c | 160 +- .../net/ethernet/aquantia/atlantic/aq_hw.h | 6 + .../ethernet/aquantia/atlantic/aq_macsec.c | 1840 +++++++++++ .../ethernet/aquantia/atlantic/aq_macsec.h | 138 + .../net/ethernet/aquantia/atlantic/aq_nic.c | 21 +- .../net/ethernet/aquantia/atlantic/aq_nic.h | 6 +- .../ethernet/aquantia/atlantic/aq_pci_func.c | 5 + .../aquantia/atlantic/hw_atl/hw_atl_utils.h | 51 +- .../atlantic/hw_atl/hw_atl_utils_fw2x.c | 69 + .../atlantic/macsec/MSS_Egress_registers.h | 78 + .../atlantic/macsec/MSS_Ingress_registers.h | 82 + .../aquantia/atlantic/macsec/macsec_api.c | 2938 +++++++++++++++++ .../aquantia/atlantic/macsec/macsec_api.h | 328 ++ .../aquantia/atlantic/macsec/macsec_struct.h | 919 ++++++ drivers/net/macsec.c | 447 ++- include/linux/netdev_features.h | 3 + include/linux/netdevice.h | 9 + include/net/macsec.h | 29 +- include/uapi/linux/if_link.h | 1 + net/ethtool/common.c | 1 + tools/include/uapi/linux/if_link.h | 1 + 23 files changed, 6962 insertions(+), 178 deletions(-) create mode 100644 drivers/net/ethernet/aquantia/atlantic/aq_macsec.c create mode 100644 drivers/net/ethernet/aquantia/atlantic/aq_macsec.h create mode 100644 drivers/net/ethernet/aquantia/atlantic/macsec/MSS_Egress_registers.h create mode 100644 drivers/net/ethernet/aquantia/atlantic/macsec/MSS_Ingress_registers.h create mode 100644 drivers/net/ethernet/aquantia/atlantic/macsec/macsec_api.c create mode 100644 drivers/net/ethernet/aquantia/atlantic/macsec/macsec_api.h create mode 100644 drivers/net/ethernet/aquantia/atlantic/macsec/macsec_struct.h
Signature · 1 line
2.17.1