Skip to content

x86/resctrl: Misc cleanup

James Morse lkml 5 versions – Applied

Status from this message: The following commit has been merged into the x86/cache branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest10 patches 2 repliesApplied
  2. v410 patches 2 repliesSuperseded
  3. v310 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v210 patches9 repliesSuperseded
v110 patches10 repliesSuperseded

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/10x86/resctrl: Nothing uses struct mbm_state chunks_bwarch/x86/kernel/cpu/resctrl/internal.h arch/x86/kernel/cpu/resctrl/monitor.c+1 -40 replies
2/10x86/resctrl: Remove max_delayarch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/internal.h+4 -70 replies
3/10x86/resctrl: Fix stale commentarch/x86/kernel/cpu/resctrl/rdtgroup.c+1 -10 replies
4/10x86/resctrl: use container_of() in delayed_work handlersarch/x86/kernel/cpu/resctrl/monitor.c+2 -110 replies
5/10x86/resctrl: Include pid.hinclude/linux/resctrl.h+2 -00 replies
6/10x86/resctrl: Use is_closid_match() in more placesarch/x86/kernel/cpu/resctrl/rdtgroup.c+14 -160 replies
7/10x86/resctrl: Add arch_needs_linear to explain AMD/Intel MBA differencearch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/ctrlmondata.c arch/x86/kernel/cpu/resctrl/internal.h+12 -10 replies
8/10x86/resctrl: Merge AMD/Intel parse_bw() callsarch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/ctrlmondata.c arch/x86/kernel/cpu/resctrl/internal.h+5 -610 replies
9/10x86/resctrl: Add arch_has_{sparse,empty}_bitmaps to explain CAT differencesarch/x86/kernel/cpu/resctrl/core.c arch/x86/kernel/cpu/resctrl/ctrlmondata.c arch/x86/kernel/cpu/resctrl/internal.h+22 -390 replies
10/10cacheinfo: Move resctrl's get_cache_id() to the cacheinfo header filearch/x86/kernel/cpu/resctrl/core.c include/linux/cacheinfo.h+23 -150 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchReinette ChatreBabu Moger
1/10R-b
2/10R-b
3/10R-b
4/10R-b
5/10R-b
6/10R-b
7/10R-b R-b
8/10R-b R-b
9/10R-b R-b
10/10R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/10] x86/resctrl: Misc cleanup

Hello!

These are the miscellaneous cleanup patches that floated to the top of the MPAM tree.

The only interesting thing are the patches to make the AMD/Intel differences something resctrl understands, instead of just 'happening' because of the different function pointers.
This will become more important once MPAM support is added. parse_bw() and friends are what enforces resctrl's ABI. Allowing an architecture/platform to provide a subtly different function here would be bad for user-space.

MPAM would set arch_has_sparse_bitmaps and arch_has_empty_bitmap, but not arch_needs_linear.

Since [v4], its just been rebased (retested) and had the tags collected.

Since [v3], some spurious brackets have disappears, comments have moved to the correct order, and tags collected.

Since [v2], arch_has_empty_bitmap has been added, and some typos fixed.

Since [v1], I've picked up all the review feedback and collected the tags.

Nothing in this series should change any behaviour.

Thanks,

James

[v4] https://lore.kernel.org/lkml/[email protected]/
[v3] https://lore.kernel.org/lkml/[email protected]/
[v2] https://lore.kernel.org/lkml/[email protected]/
[v1] https://lore.kernel.org/lkml/[email protected]/

James Morse (10):
x86/resctrl: Nothing uses struct mbm_state chunks_bw x86/resctrl: Remove max_delay
x86/resctrl: Fix stale comment
x86/resctrl: use container_of() in delayed_work handlers x86/resctrl: Include pid.h
x86/resctrl: Use is_closid_match() in more places x86/resctrl: Add arch_needs_linear to explain AMD/Intel MBA difference x86/resctrl: Merge AMD/Intel parse_bw() calls
x86/resctrl: Add arch_has_{sparse,empty}_bitmaps to explain CAT
differences
cacheinfo: Move resctrl's get_cache_id() to the cacheinfo header file

 arch/x86/kernel/cpu/resctrl/core.c        | 45 +++++------
 arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 92 ++++-------------------
 arch/x86/kernel/cpu/resctrl/internal.h    | 21 ++----
 arch/x86/kernel/cpu/resctrl/monitor.c     | 16 +---
 arch/x86/kernel/cpu/resctrl/rdtgroup.c    | 32 ++++----
 include/linux/cacheinfo.h                 | 21 ++++++
 include/linux/resctrl.h                   |  2 +
 7 files changed, 80 insertions(+), 149 deletions(-)
Signature · 1 line
2.20.1