efi: clean up contents of struct efi
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest18 patches 13 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/18 | efi: drop handling of 'boot_info' configuration tablearch/ drivers/ include/ | +0 | 0 replies | |
| 2/18 | efi/ia64: move HCDP and MPS table handling into IA64 arch codearch/ arch/ drivers/ +2 more | +24 | 0 replies | |
| 3/18 | efi: move UGA and PROP table handling to x86 codearch/ drivers/ include/ | +31 | 0 replies | |
| 4/18 | efi: make rng_seed table handling local to efi.cdrivers/ include/ | +10 | 0 replies | |
| 5/18 | efi: move mem_attr_table out of struct efiarch/ drivers/ drivers/ +1 more | +11 | 0 replies | |
| 6/18 | efi: make memreserve table handling local to efi.cdrivers/ include/ | +6 | 0 replies | |
| 7/18 | efi: merge EFI system table revision and vendor checksarch/ arch/ drivers/ +2 more | +83 | 0 replies | |
| 8/18 | efi/ia64: use existing helpers to locate ESI tablearch/ arch/ | +10 | 0 replies | |
| 9/18 | efi/ia64: use local variable for EFI system table addressarch/ | +6 | 0 replies | |
| 10/18 | efi/ia64: switch to efi_config_parse_tables()arch/ | +4 | 0 replies | |
| 11/18 | efi: make efi_config_init() x86 onlyarch/ drivers/ include/ | +30 | 0 replies | |
| 12/18 | efi: clean up config_parse_tables()arch/ arch/ drivers/ +2 more | +32 | 2 replies | |
| 13/18 | efi/x86: remove runtime table address from kexec EFI setup dataarch/ arch/ arch/ | +1 | 0 replies | |
| 14/18 | efi/x86: make fw_vendor, config_table and runtime sysfs nodes x86 specificarch/ arch/ arch/ +4 more | +59 | 0 replies | |
| 15/18 | efi/x86: merge assignments of efi.runtime_versionarch/ | +2 | 0 replies | |
| 16/18 | efi: add 'runtime' pointer to struct efiarch/ arch/ arch/ +6 more | +49 | 8 replies | |
| 17/18 | efi/arm: drop unnecessary references to efi.systabdrivers/ drivers/ | +14 | 0 replies | |
| 18/18 | efi/x86: drop 'systab' member from struct efiarch/ include/ | +41 | 0 replies |
Reviews trailers per patch
None of the 18 patches has a Reviewed-by or Acked-by.
| Patch | Tony Luck |
|---|---|
| Series | T-b |
| 1/18 | |
| 2/18 | |
| 3/18 | |
| 4/18 | |
| 5/18 | |
| 6/18 | |
| 7/18 | |
| 8/18 | |
| 9/18 | |
| 10/18 | |
| 11/18 | |
| 12/18 | |
| 13/18 | |
| 14/18 | |
| 15/18 | |
| 16/18 | |
| 17/18 | |
| 18/18 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/18] efi: clean up contents of struct efi
The generic r/w singleton object 'struct efi efi' is currently being used as a dumping ground for memory addresses of firmware tables that only have significance for a single architecture, or only at boot time [whereas struct efi is an object with indefinite lifetime, and which is exported to modules]
Since we're expecting a new arrival that does affect all architectures, which will need to be added to struct efi as well, let's do a cleanup pass, and move out all the per-arch pieces and other stuff that does not need to live in a global r/w struct.
As a side effect, I ran into some other things that can be refactored so that more code is shared between architectures, or made x86 specific if it is something that should maybe not have existed in the first place, and x86 is the only architecture where we cannot remove it for compatibility reasons.
Finally, we get rid of the struct efi::systab member, which we only need at runtime to get at the 'runtime' pointer, so let's store that instead. This allows us to drop some ugly handling of the remapped systab address, which we cannot discover as easily as the remapped 'runtime' pointer.
Ard Biesheuvel (18):
efi: drop handling of 'boot_info' configuration table efi/ia64: move HCDP and MPS table handling into IA64 arch code
efi: move UGA and PROP table handling to x86 code
efi: make rng_seed table handling local to efi.c
efi: move mem_attr_table out of struct efi
efi: make memreserve table handling local to efi.c
efi: merge EFI system table revision and vendor checks efi/ia64: use existing helpers to locate ESI table efi/ia64: use local variable for EFI system table address efi/ia64: switch to efi_config_parse_tables()
efi: make efi_config_init() x86 only
efi: clean up config_parse_tables()
efi/x86: remove runtime table address from kexec EFI setup data efi/x86: make fw_vendor, config_table and runtime sysfs nodes x86
specific
efi/x86: merge assignments of efi.runtime_version
efi: add 'runtime' pointer to struct efi
efi/arm: drop unnecessary references to efi.systab efi/x86: drop 'systab' member from struct efi
arch/ia64/kernel/efi.c | 55 ++-- arch/ia64/kernel/esi.c | 21 +- arch/x86/include/asm/efi.h | 6 +- arch/x86/kernel/asm-offsets_32.c | 5 + arch/x86/kernel/kexec-bzimage64.c | 5 +- arch/x86/platform/efi/efi.c | 262 ++++++++++---------- arch/x86/platform/efi/efi_32.c | 13 +- arch/x86/platform/efi/efi_64.c | 14 +- arch/x86/platform/efi/efi_stub_32.S | 21 +- arch/x86/platform/efi/quirks.c | 2 +- drivers/firmware/efi/arm-init.c | 68 ++--- drivers/firmware/efi/arm-runtime.c | 18 -- drivers/firmware/efi/efi.c | 237 ++++++++---------- drivers/firmware/efi/memattr.c | 13 +- drivers/firmware/efi/runtime-wrappers.c | 4 +- drivers/firmware/pcdp.c | 8 +- include/linux/efi.h | 76 +++--- 17 files changed, 379 insertions(+), 449 deletions(-)
Signature · 1 line
2.17.1