Skip to content

xen/rcu: let rcu work better with core scheduling

Juergen Gross xen-devel 8 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v8 Latest5 patches 5 repliesIn review
  2. v75 patches 9 repliesSuperseded
  3. v64 patches 12 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v54 patches4 repliesSuperseded
v46 patches16 repliesSuperseded
v36 patches3 repliesSuperseded
v24 patches22 repliesSuperseded
v12 patches13 repliesSuperseded

Changes in v8 from the cover letter

- fine tuning of barriers in patch 2

Patches in v8 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5xen: introduce smp_mb__[after|before]_atomic() barriersxen/include/asm-arm/system.h xen/include/asm-x86/system.h+6 -00 replies
2/5xen/rcu: don't use stop_machine_run() for rcu_barrier()xen/common/rcupdate.c xen/include/xen/rcupdate.h+82 -280 replies
3/5xen: don't process rcu callbacks when holding a rcu_read_lock()xen/common/softirq.c+10 -25 replies
4/5xen/rcu: add assertions to debug buildxen/common/rcupdate.c xen/common/softirq.c xen/include/xen/rcupdate.h+39 -40 replies
5/5xen/rcu: add per-lock counter in debug buildsxen/include/xen/rcupdate.h+33 -130 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchJan BeulichJulien GrallIgor Druzhinin
1/5A-b A-b
2/5R-b Partially-based-on-patch-by
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v8 thread

Cover letter [Xen-devel] [PATCH v8 0/5] xen/rcu: let rcu work better with core scheduling

Today the RCU handling in Xen is affecting scheduling in several ways. It is raising sched softirqs without any real need and it requires tasklets for rcu_barrier(), which interacts badly with core scheduling.

This small series repairs those issues.

Additionally some ASSERT()s are added for verification of sane rcu handling. In order to avoid those triggering right away the obvious violations are fixed. This includes making rcu locking functions type safe.

Changes in V8:
- fine tuning of barriers in patch 2

Changes in V7:
- new patch 1
- added some barriers in patch 1

Changes in V6:
- added memory barrier in patch 1
- drop cpu_map_lock only at the end of rcu_barrier()
- re-add prempt_disable() in patch 3

Changes in V5:
- dropped already committed patches 1 and 4
- fixed race
- rework blocking of rcu processing with held rcu locks

Changes in V4:
- patch 5: use barrier()

Changes in V3:
- type safe locking functions (functions instead of macros)
- per-lock debug additions
- new patches 4 and 6
- fixed races

Changes in V2:
- use get_cpu_maps() in rcu_barrier() handling
- avoid recursion in rcu_barrier() handling
- new patches 3 and 4

Juergen Gross (5):
xen: introduce smp_mb__[after|before]_atomic() barriers xen/rcu: don't use stop_machine_run() for rcu_barrier()
xen: don't process rcu callbacks when holding a rcu_read_lock() xen/rcu: add assertions to debug build
xen/rcu: add per-lock counter in debug builds

 xen/common/rcupdate.c        | 110 ++++++++++++++++++++++++++++++++-----------
 xen/common/softirq.c         |  14 +++++-
 xen/include/asm-arm/system.h |   3 ++
 xen/include/asm-x86/system.h |   3 ++
 xen/include/xen/rcupdate.h   |  77 +++++++++++++++++++++++++-----
 5 files changed, 165 insertions(+), 42 deletions(-)
Signature · 1 line
2.16.4