Skip to content

Fix error handling during bitmap postcopy

Vladimir Sementsov-Ogievskiy qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest21 patches 3 repliesIn review
  2. v321 patches 16 repliesSuperseded
  3. v222 patches 56 repliesApplied

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21qemu-iotests/199: fix styletests/qemu-iotests/199+7 -60 replies
2/21qemu-iotests/199: drop extra constraintstests/qemu-iotests/199+1 -20 replies
3/21qemu-iotests/199: better catch postcopy timetests/qemu-iotests/199+57 -150 replies
4/21qemu-iotests/199: improve performance: set bitmap by discardtests/qemu-iotests/199+20 -110 replies
5/21qemu-iotests/199: change discard patternstests/qemu-iotests/199+26 -180 replies
6/21qemu-iotests/199: increase postcopy periodtests/qemu-iotests/199+39 -190 replies
7/21migration/block-dirty-bitmap: fix dirty_bitmap_mig_before_vm_startmigration/block-dirty-bitmap.c+1 -10 replies
8/21migration/block-dirty-bitmap: rename state structure typesmigration/block-dirty-bitmap.c+37 -330 replies
9/21migration/block-dirty-bitmap: rename dirty_bitmap_mig_cleanupmigration/block-dirty-bitmap.c+4 -40 replies
10/21migration/block-dirty-bitmap: move mutex init to dirty_bitmap_mig_initmigration/block-dirty-bitmap.c migration/migration.c migration/migration.h+1 -80 replies
11/21migration/block-dirty-bitmap: refactor state global variablesmigration/block-dirty-bitmap.c+99 -800 replies
12/21migration/block-dirty-bitmap: rename finish_lock to just lockmigration/block-dirty-bitmap.c+6 -60 replies
13/21migration/block-dirty-bitmap: simplify dirty_bitmap_load_completemigration/block-dirty-bitmap.c+4 -210 replies
14/21migration/block-dirty-bitmap: keep bitmap state for all bitmapsmigration/block-dirty-bitmap.c+43 -210 replies
15/21migration/block-dirty-bitmap: relax error handling in incoming partmigration/block-dirty-bitmap.c+127 -371 reply
16/21migration/block-dirty-bitmap: cancel migration on shutdownmigration/block-dirty-bitmap.c migration/migration.c migration/migration.h+31 -00 replies
17/21migration/savevm: don't worry if bitmap migration postcopy failedmigration/savevm.c+32 -50 replies
18/21qemu-iotests/199: prepare for new test-cases additiontests/qemu-iotests/199+23 -130 replies
19/21qemu-iotests/199: check persistent bitmapstests/qemu-iotests/199+15 -10 replies
20/21qemu-iotests/199: add early shutdown case to bitmaps postcopytests/qemu-iotests/199 tests/qemu-iotests/199.out+26 -20 replies
21/21qemu-iotests/199: add source-killed case to bitmaps postcopytests/qemu-iotests/199 tests/qemu-iotests/199.out+17 -20 replies

Reviews trailers per patch

All 21 patches have a Reviewed-by or Acked-by.

PatchAndrey ShinkevichEric BlakeDr. David Alan Gilbert
1/21R-b T-b
2/21R-b T-b
3/21R-b T-b
4/21R-b T-b
5/21R-b T-b
6/21R-b T-b
7/21R-b R-b
8/21R-b R-b
9/21R-b R-b
10/21R-b R-b
11/21R-b
12/21R-b
13/21R-b
14/21R-b
15/21R-b
16/21R-b
17/21R-b R-b R-b
18/21R-b
19/21R-b
20/21R-b T-b
21/21R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 for-5.1 00/21] Fix error handling during bitmap postcopy

v4:

01: typo in commit msg
07: reword commit msg, add Eric's r-b
10: add Dr. David's r-b
15: add check for buf_size
use g_autofree (and fix introduced in v3)
use QEMU_LOCK_GUARD
17: fix commit msg, add Eric's r-b
20-21: add Eric's t-b

Original idea of bitmaps postcopy migration is that bitmaps are non critical data, and their loss is not serious problem. So, using postcopy method on any failure we should just drop unfinished bitmaps and continue guest execution.

However, it doesn't work so. It crashes, fails, it goes to postcopy-recovery feature. It does anything except for behavior we want. These series fixes at least some problems with error handling during bitmaps migration postcopy.

Vladimir Sementsov-Ogievskiy (21):
qemu-iotests/199: fix style
qemu-iotests/199: drop extra constraints
qemu-iotests/199: better catch postcopy time qemu-iotests/199: improve performance: set bitmap by discard qemu-iotests/199: change discard patterns qemu-iotests/199: increase postcopy period migration/block-dirty-bitmap: fix dirty_bitmap_mig_before_vm_start migration/block-dirty-bitmap: rename state structure types migration/block-dirty-bitmap: rename dirty_bitmap_mig_cleanup migration/block-dirty-bitmap: move mutex init to dirty_bitmap_mig_init migration/block-dirty-bitmap: refactor state global variables migration/block-dirty-bitmap: rename finish_lock to just lock migration/block-dirty-bitmap: simplify dirty_bitmap_load_complete migration/block-dirty-bitmap: keep bitmap state for all bitmaps migration/block-dirty-bitmap: relax error handling in incoming part migration/block-dirty-bitmap: cancel migration on shutdown migration/savevm: don't worry if bitmap migration postcopy failed qemu-iotests/199: prepare for new test-cases addition qemu-iotests/199: check persistent bitmaps qemu-iotests/199: add early shutdown case to bitmaps postcopy qemu-iotests/199: add source-killed case to bitmaps postcopy

 migration/migration.h          |   3 +-
 migration/block-dirty-bitmap.c | 470 +++++++++++++++++++++------------
 migration/migration.c          |  15 +-
 migration/savevm.c             |  37 ++-
 tests/qemu-iotests/199         | 250 ++++++++++++++----
 tests/qemu-iotests/199.out     |   4 +-
 6 files changed, 545 insertions(+), 234 deletions(-)
Signature · 1 line
2.21.0