Fix error handling during bitmap postcopy
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest21 patches 3 repliesIn review
- v321 patches 16 repliesSuperseded
- v222 patches 56 repliesApplied
Patches in v4 No applies recorded yet
Reviews trailers per patch
All 21 patches have a Reviewed-by or Acked-by.
| Patch | Andrey Shinkevich | Eric Blake | Dr. David Alan Gilbert |
|---|---|---|---|
| 1/21 | R-b | T-b | |
| 2/21 | R-b | T-b | |
| 3/21 | R-b | T-b | |
| 4/21 | R-b | T-b | |
| 5/21 | R-b | T-b | |
| 6/21 | R-b | T-b | |
| 7/21 | R-b | R-b | |
| 8/21 | R-b | R-b | |
| 9/21 | R-b | R-b | |
| 10/21 | R-b | R-b | |
| 11/21 | R-b | ||
| 12/21 | R-b | ||
| 13/21 | R-b | ||
| 14/21 | R-b | ||
| 15/21 | R-b | ||
| 16/21 | R-b | ||
| 17/21 | R-b | R-b | R-b |
| 18/21 | R-b | ||
| 19/21 | R-b | ||
| 20/21 | R-b | T-b | |
| 21/21 | R-b | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 for-5.1 00/21] Fix error handling during bitmap postcopy
v4:
01: typo in commit msg
07: reword commit msg, add Eric's r-b
10: add Dr. David's r-b
15: add check for buf_size
use g_autofree (and fix introduced in v3)
use QEMU_LOCK_GUARD
17: fix commit msg, add Eric's r-b
20-21: add Eric's t-b
Original idea of bitmaps postcopy migration is that bitmaps are non critical data, and their loss is not serious problem. So, using postcopy method on any failure we should just drop unfinished bitmaps and continue guest execution.
However, it doesn't work so. It crashes, fails, it goes to postcopy-recovery feature. It does anything except for behavior we want. These series fixes at least some problems with error handling during bitmaps migration postcopy.
Vladimir Sementsov-Ogievskiy (21):
qemu-iotests/199: fix style
qemu-iotests/199: drop extra constraints
qemu-iotests/199: better catch postcopy time qemu-iotests/199: improve performance: set bitmap by discard qemu-iotests/199: change discard patterns qemu-iotests/199: increase postcopy period migration/block-dirty-bitmap: fix dirty_bitmap_mig_before_vm_start migration/block-dirty-bitmap: rename state structure types migration/block-dirty-bitmap: rename dirty_bitmap_mig_cleanup migration/block-dirty-bitmap: move mutex init to dirty_bitmap_mig_init migration/block-dirty-bitmap: refactor state global variables migration/block-dirty-bitmap: rename finish_lock to just lock migration/block-dirty-bitmap: simplify dirty_bitmap_load_complete migration/block-dirty-bitmap: keep bitmap state for all bitmaps migration/block-dirty-bitmap: relax error handling in incoming part migration/block-dirty-bitmap: cancel migration on shutdown migration/savevm: don't worry if bitmap migration postcopy failed qemu-iotests/199: prepare for new test-cases addition qemu-iotests/199: check persistent bitmaps qemu-iotests/199: add early shutdown case to bitmaps postcopy qemu-iotests/199: add source-killed case to bitmaps postcopy
migration/migration.h | 3 +- migration/block-dirty-bitmap.c | 470 +++++++++++++++++++++------------ migration/migration.c | 15 +- migration/savevm.c | 37 ++- tests/qemu-iotests/199 | 250 ++++++++++++++---- tests/qemu-iotests/199.out | 4 +- 6 files changed, 545 insertions(+), 234 deletions(-)
Signature · 1 line
2.21.0