Skip to content

do not store GPU address in TTM

Nirmoy Das dri-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest8 patches 16 repliesIn review
  2. v57 of 8 patches 1 replySuperseded
  3. v48 patches 11 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v38 patches11 repliesSuperseded
v28 patches0 repliesSuperseded
v18 patches21 repliesSuperseded

Changes in v6 from the cover letter

* rebase to drm-misc-next
* removed acked for vmwgfx as there was a small conflict

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/amdgpu: move ttm bo->offset to amdgpu_bodrivers/gpu/drm/amd/amdgpu/amdgpu_object.c drivers/gpu/drm/amd/amdgpu/amdgpu_object.h drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +2 more+48 -110 replies
2/8drm/radeon: don't use ttm bo->offsetdrivers/gpu/drm/radeon/radeon.h drivers/gpu/drm/radeon/radeon_object.h drivers/gpu/drm/radeon/radeon_ttm.c+17 -40 replies
3/8drm/vmwgfx: don't use ttm bo->offsetdrivers/gpu/drm/vmwgfx/vmwgfx_bo.c drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c +1 more+4 -60 replies
4/8drm/nouveau: don't use ttm bo->offset v3drivers/gpu/drm/nouveau/dispnv04/crtc.c drivers/gpu/drm/nouveau/dispnv04/disp.c drivers/gpu/drm/nouveau/dispnv04/overlay.c +12 more+36 -240 replies
5/8drm/qxl: don't use ttm bo->offsetdrivers/gpu/drm/qxl/qxl_drv.h drivers/gpu/drm/qxl/qxl_kms.c drivers/gpu/drm/qxl/qxl_object.h +1 more+4 -210 replies
6/8drm/vram-helper: don't use ttm bo->offset v4drivers/gpu/drm/drm_gem_vram_helper.c+10 -18 replies
7/8drm/bochs: use drm_gem_vram_offset to get bo offset v2drivers/gpu/drm/bochs/bochs_kms.c+6 -10 replies
8/8drm/ttm: do not keep GPU dependent addressesdrivers/gpu/drm/ttm/ttm_bo.c include/drm/ttm/ttm_bo_api.h include/drm/ttm/ttm_bo_driver.h+0 -100 replies

Reviews trailers per patch

5 of 8 patches have a Reviewed-by or Acked-by.

PatchHuang RuiChristian KönigDaniel VetterGerd Hoffmann
1/8A-b R-b
2/8Reviewed-and-tested-by
3/8
4/8
5/8A-b A-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v6 thread

Cover letter [RESEND] [PATCH v6 0/8] do not store GPU address in TTM

With this patch series I am trying to remove GPU address dependency in TTM and moving GPU address calculation to individual drm drivers. This cleanup will simplify introduction of drm_mem_region/domain work started by Brian Welty[1].

It would be nice if someone test this for nouveau. Rest of the drivers are already tested.

v2:
* set bo->offset = 0 for drm/nouveau if bo->mem.mm_node == NULL

v3:
* catch return value of drm_gem_vram_offset() in drm/bochs
* introduce drm_gem_vram_pg_offset() in vram helper
* improve nbo->offset calculation for nouveau

v4:
* minor coding style fixes in amdgpu and radeon
* remove unnecessary kerneldoc for internal function

v5:
* rebase on top of drm-misc-next
* fix return value of drm_gem_vram_pg_offset()
* add a comment in drm_gem_vram_pg_offset() to clearify why we return 0.

v6:
* rebase to drm-misc-next
* removed acked for vmwgfx as there was a small conflict

Nirmoy Das (8):
drm/amdgpu: move ttm bo->offset to amdgpu_bo drm/radeon: don't use ttm bo->offset drm/vmwgfx: don't use ttm bo->offset drm/nouveau: don't use ttm bo->offset v3 drm/qxl: don't use ttm bo->offset drm/vram-helper: don't use ttm bo->offset v4 drm/bochs: use drm_gem_vram_offset to get bo offset v2 drm/ttm: do not keep GPU dependent addresses

 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c  | 23 ++++++++++++++--
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.h  |  1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c     | 30 ++++++++++++++++-----
 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h     |  1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c |  4 +--
 drivers/gpu/drm/bochs/bochs_kms.c           |  7 ++++-
 drivers/gpu/drm/drm_gem_vram_helper.c       | 11 +++++++-
 drivers/gpu/drm/nouveau/dispnv04/crtc.c     |  6 ++---
 drivers/gpu/drm/nouveau/dispnv04/disp.c     |  3 ++-
 drivers/gpu/drm/nouveau/dispnv04/overlay.c  |  6 ++---
 drivers/gpu/drm/nouveau/dispnv50/base507c.c |  2 +-
 drivers/gpu/drm/nouveau/dispnv50/core507d.c |  2 +-
 drivers/gpu/drm/nouveau/dispnv50/ovly507e.c |  2 +-
 drivers/gpu/drm/nouveau/dispnv50/wndw.c     |  2 +-
 drivers/gpu/drm/nouveau/dispnv50/wndwc37e.c |  2 +-
 drivers/gpu/drm/nouveau/nouveau_abi16.c     |  8 +++---
 drivers/gpu/drm/nouveau/nouveau_bo.c        |  8 ++++++
 drivers/gpu/drm/nouveau/nouveau_bo.h        |  3 +++
 drivers/gpu/drm/nouveau/nouveau_chan.c      |  2 +-
 drivers/gpu/drm/nouveau/nouveau_dmem.c      |  2 +-
 drivers/gpu/drm/nouveau/nouveau_fbcon.c     |  2 +-
 drivers/gpu/drm/nouveau/nouveau_gem.c       | 10 +++----
 drivers/gpu/drm/qxl/qxl_drv.h               |  6 ++---
 drivers/gpu/drm/qxl/qxl_kms.c               |  5 ++--
 drivers/gpu/drm/qxl/qxl_object.h            |  5 ----
 drivers/gpu/drm/qxl/qxl_ttm.c               |  9 -------
 drivers/gpu/drm/radeon/radeon.h             |  1 +
 drivers/gpu/drm/radeon/radeon_object.h      | 16 ++++++++++-
 drivers/gpu/drm/radeon/radeon_ttm.c         |  4 +--
 drivers/gpu/drm/ttm/ttm_bo.c                |  7 -----
 drivers/gpu/drm/vmwgfx/vmwgfx_bo.c          |  4 +--
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c     |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c        |  2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c  |  2 --
 include/drm/ttm/ttm_bo_api.h                |  2 --
 include/drm/ttm/ttm_bo_driver.h             |  1 -
 36 files changed, 125 insertions(+), 78 deletions(-)

--
2.27.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel