Skip to content

usb: gadget: aspeed: allow to customize vhub device

[email protected] linux-arm-kernel linux-aspeed linux-devicetree linux-usb lkml openbmc 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 5 repliesIn review
  2. v12 patches 4 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6usb: gadget: aspeed: support multiple language stringsdrivers/usb/gadget/udc/aspeed-vhub/core.c drivers/usb/gadget/udc/aspeed-vhub/hub.c drivers/usb/gadget/udc/aspeed-vhub/vhub.h+131 -170 replies
2/6usb: gadget: add "usb_validate_langid" functiondrivers/usb/gadget/configfs.c drivers/usb/gadget/usbstring.c include/linux/usb/gadget.h+28 -130 replies
3/6usb: gadget: aspeed: allow to set usb strings in device treedrivers/usb/gadget/udc/aspeed-vhub/hub.c+57 -10 replies
4/6usb: gadget: aspeed: allow to set device IDs in device treedrivers/usb/gadget/udc/aspeed-vhub/hub.c+21 -00 replies
5/6usb: gadget: aspeed: fixup usb1 device descriptor at init timedrivers/usb/gadget/udc/aspeed-vhub/hub.c+8 -110 replies
6/6dt-bindings: usb: document aspeed vhub device ID/string propertiesDocumentation/devicetree/bindings/usb/aspeed,usb-vhub.yaml+68 -05 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/6] usb: gadget: aspeed: allow to customize vhub device

From: Tao Ren <[email protected]>

This patch series allows people to customize aspeed-usb-vhub device IDs and strings via device tree.

Patch #1 converts the single "usb_gadget_strings" instance to a list of "usb_gadget_strings" so it's more convenient to support miltiple languages.

Patch #2 moves LANGID validation code from configfs.c to usbstring.c so it can be used by aspeed-vhub driver.

Patch #3 initializes aspeed-vhub strings with default, or from device tree if according device tree properties are defined.

Patch #4 overrides aspeed-vhub's device IDs if according properties are defined in device tree.

Patch #5 moves fixup-usb1-dev-desc logic from get-descriptor handler to vhub-init time so the descriptor is patched only once.

Patch #6 documents new device tree properties in dt-binding document.

Tao Ren (6):
usb: gadget: aspeed: support multiple language strings
usb: gadget: add "usb_validate_langid" function
usb: gadget: aspeed: allow to set usb strings in device tree
usb: gadget: aspeed: allow to set device IDs in device tree
usb: gadget: aspeed: fixup usb1 device descriptor at init time
dt-bindings: usb: document aspeed vhub device ID/string properties

 .../bindings/usb/aspeed,usb-vhub.yaml         |  68 +++++
 drivers/usb/gadget/configfs.c                 |  14 +-
 drivers/usb/gadget/udc/aspeed-vhub/core.c     |   4 +-
 drivers/usb/gadget/udc/aspeed-vhub/hub.c      | 236 ++++++++++++++++--
 drivers/usb/gadget/udc/aspeed-vhub/vhub.h     |   4 +-
 drivers/usb/gadget/usbstring.c                |  24 ++
 include/linux/usb/gadget.h                    |   3 +
 7 files changed, 312 insertions(+), 41 deletions(-)
Signature · 1 line
2.17.1