perf report: Support annotation of code without symbols
Status from this message: The following commit has been merged into the perf/urgent branch of tip:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest3 patches 8 repliesApplied
- v42 patches 2 repliesSuperseded
- v32 patches 12 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 2 patches | 4 replies | Superseded | |
| v1 | 2 patches | 6 replies | Superseded |
Changes in v5 from the cover letter
---
Separate the hotkey 'a' implementation to a new patch "perf report: Support hotkey 'a' on address for annotation"
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | perf util: Print al_addr when symbol is not foundtools/ | +4 | 0 replies | |
| 2/3 | perf report: Support interactive annotation of code without symbolstools/ tools/ | +38 | 6 replies | |
| 3/3 | perf report: Support hotkey 'a' on address for annotationtools/ | +36 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Ravi Bangoria | Jiri Olsa |
|---|---|---|
| Series | T-b | A-b |
| 1/3 | ||
| 2/3 | ||
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v5 0/3] perf report: Support annotation of code without symbols
For perf report on stripped binaries it is currently impossible to do annotation. The annotation state is all tied to symbols, but there are either no symbols, or symbols are not covering all the code.
We should support the annotation functionality even without symbols.
The first patch uses al_addr to print because it's easy to dump the instructions from this address in binary for branch mode.
The second patch supports the annotation on stripped binary.
The third patch supports the hotkey 'a' on address for annotation.
v5:
---
Separate the hotkey 'a' implementation to a new patch "perf report: Support hotkey 'a' on address for annotation"
v4:
---
1. Support the hotkey 'a'. When we press 'a' on address, now it supports the annotation.
2. Change the patch title from
"Support interactive annotation of code without symbols" to "perf report: Support interactive annotation of code without symbols"
v3:
---
Keep just the ANNOTATION_DUMMY_LEN, and remove the opts->annotate_dummy_len since it's the "maybe in future we will provide" feature.
v2:
---
Fix a crash issue when annotating an address in "unknown" object.
Jin Yao (3):
perf util: Print al_addr when symbol is not found
perf report: Support interactive annotation of code without symbols perf report: Support hotkey 'a' on address for annotation
tools/perf/ui/browsers/hists.c | 90 +++++++++++++++++++++++++++------- tools/perf/util/annotate.h | 1 + tools/perf/util/sort.c | 6 ++- 3 files changed, 78 insertions(+), 19 deletions(-)
Signature · 1 line
2.17.1