Skip to content

ceph: don't request caps for idle open files

Yan, Zheng ceph-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest7 patches 1 replyIn review
  2. v46 patches 4 repliesSuperseded
  3. v36 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v24 patches15 repliesSuperseded
v14 patches10 repliesSuperseded

Changes in v5 from the cover letter

- add patch 7, improve how to calculate dir's wanted caps

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ceph: always renew caps if mds_wanted is insufficientfs/ceph/caps.c fs/ceph/mds_client.c fs/ceph/super.h+21 -330 replies
2/7ceph: consider inode's last read/write when calculating wanted capsfs/ceph/caps.c fs/ceph/file.c fs/ceph/inode.c +3 more+147 -630 replies
3/7ceph: remove delay check logic from ceph_check_caps()fs/ceph/caps.c fs/ceph/file.c fs/ceph/inode.c +1 more+44 -1260 replies
4/7ceph: simplify calling of ceph_get_fmode()fs/ceph/caps.c fs/ceph/file.c fs/ceph/inode.c +1 more+10 -480 replies
5/7ceph: update i_requested_max_size only when sending cap msg to auth mdsfs/ceph/caps.c+2 -10 replies
6/7ceph: check all mds' caps after page writebackfs/ceph/caps.c fs/ceph/inode.c+2 -20 replies
7/7ceph: calculate dir's wanted caps according to recent diropsfs/ceph/caps.c fs/ceph/dir.c fs/ceph/mds_client.c+46 -160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/7] ceph: don't request caps for idle open files

This series make cephfs client not request caps for open files that idle for a long time. For the case that one active client and multiple standby clients open the same file, this increase the possibility that mds issues exclusive caps to the active client.

Yan, Zheng (7):
ceph: always renew caps if mds_wanted is insufficient
ceph: consider inode's last read/write when calculating wanted caps
ceph: remove delay check logic from ceph_check_caps()
ceph: simplify calling of ceph_get_fmode()
ceph: update i_requested_max_size only when sending cap msg to auth mds
ceph: check all mds' caps after page writeback
ceph: calculate dir's wanted caps according to recent dirops

 fs/ceph/caps.c               | 360 ++++++++++++++++-------------------
 fs/ceph/dir.c                |  21 +-
 fs/ceph/file.c               |  45 ++---
 fs/ceph/inode.c              |  21 +-
 fs/ceph/ioctl.c              |   2 +
 fs/ceph/mds_client.c         |  16 +-
 fs/ceph/super.h              |  37 ++--
 include/linux/ceph/ceph_fs.h |   1 +
 8 files changed, 243 insertions(+), 260 deletions(-)

changes since v2
- make __ceph_caps_file_wanted() more readable
- add patch 5 and 6, which fix hung write during testing patch 1~4

changes since v3
- don't queue delayed cap check for snap inode
- initialize ci->{last_rd,last_wr} to jiffies - 3600 * HZ
- make __ceph_caps_file_wanted() check inode type

changes since v4
- add patch 7, improve how to calculate dir's wanted caps

Signature · 1 line
2.21.1