global exec/memory/dma APIs cleanup
Get series with b4
b4 am [email protected]Versions newest first
- v3 Latest19 of 20 patches 15 repliesIn review
19 of 20 patches are in this archive. The cover letter announces 20.
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/20 | scripts/git.orderfile: Display Cocci scripts before code modificationsscripts/ | +3 | 3 replies | |
| 2/20 | hw: Remove unnecessary cast when calling dma_memory_read()hw/ hw/ hw/ +1 more | +25 | 3 replies | |
| 3/20 | exec: Let qemu_ram_*() functions take a const pointer argumentexec.c hw/ include/ +1 more | +10 | 3 replies | |
| 4/20 | exec: Rename ram_ptr variableexec.c | +10 | 0 replies | |
| 5/20 | exec: Let flatview API take void pointer argumentsexec.c include/ | +9 | 0 replies | |
| 6/20 | exec: Let the address_space API use void pointer argumentsexec.c include/ | +12 | 0 replies | |
| 7/20 | hw/net: Avoid casting non-const pointer, use address_space_write()hw/ hw/ scripts/ | +17 | 0 replies | |
| 8/20 | Remove unnecessary cast when using the address_space APIhw/ hw/ hw/ +9 more | +54 | 1 reply | |
| 9/20 | exec: Let the cpu_[physical]_memory API use void pointer argumentsexec.c include/ include/ | +7 | 0 replies | |
| 10/20 | Remove unnecessary cast when using the cpu_[physical]_memory APIhw/ hw/ hw/ +2 more | +31 | 0 replies | |
| 11/20 | hw/ide/internal: Remove unused DMARestartFunc typedefinclude/ | +0 | 1 reply | |
| 12/20 | hw/ide: Let the DMAIntFunc prototype use a boolean 'is_write' argumenthw/ hw/ hw/ +3 more | +8 | 1 reply | |
| 13/20 | hw/virtio: Let virtqueue_map_iovec() use a boolean 'is_write' argumenthw/ | +4 | 0 replies | |
| 14/20 | hw/virtio: Let vhost_memory_map() use a boolean 'is_write' argumenthw/ | +4 | 0 replies | |
| 15/20 | exec: Let address_space_unmap() use a boolean 'is_write' argumentexec.c include/ | +3 | 0 replies | |
| 16/20 | Let address_space_rw() calls pass a boolean 'is_write' argumentexec.c hw/ hw/ +4 more | +41 | 0 replies | |
| 17/20 | Avoid address_space_rw() with a constant is_write argumentaccel/ dma-helpers.c exec.c +10 more | +119 | 0 replies | |
| 18/20 | exec: Let cpu_[physical]_memory API use a boolean 'is_write' argumentexec.c include/ include/ | +9 | 0 replies | |
| 19/20 | Let cpu_[physical]_memory() calls pass a boolean 'is_write' argumenthw/ hw/ hw/ +14 more | +43 | 3 replies |
Reviews trailers per patch
7 of 19 patches have a Reviewed-by or Acked-by.
| Patch | Peter Maydell | Philippe Mathieu-Daudé | Edgar E. Iglesias | Laurent Vivier | Cédric Le Goater | Christian Borntraeger | Cornelia Huck | Alistair Francis | David Gibson | Eric Blake | Paul Durrant | Michael S. Tsirkin | John Snow |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1/20 | R-b | R-b | R-b | ||||||||||
| 2/20 | |||||||||||||
| 3/20 | R-b | ||||||||||||
| 4/20 | |||||||||||||
| 5/20 | |||||||||||||
| 6/20 | |||||||||||||
| 7/20 | |||||||||||||
| 8/20 | A-b | ||||||||||||
| 9/20 | |||||||||||||
| 10/20 | |||||||||||||
| 11/20 | A-b | ||||||||||||
| 12/20 | A-b | ||||||||||||
| 13/20 | |||||||||||||
| 14/20 | |||||||||||||
| 15/20 | |||||||||||||
| 16/20 | Inspired-by | ||||||||||||
| 17/20 | R-b | R-b | R-b | R-b | A-b | R-b | R-b | A-b | |||||
| 18/20 | |||||||||||||
| 19/20 | A-b | A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 13 reviewers.
Cover letter [PATCH v3 00/20] global exec/memory/dma APIs cleanup
This series is inspired from Peter Maydel cleanup patch:
https://www.mail-archive.com/[email protected]/msg680625.html
- Convert 'is_write' argument to boolean
- Use void pointer for blob buffer
- Remove unnecessary casts (Stefan Weil)
- Replace [API]_rw() by [API]_read/write() when is_write is constant
Supersedes: <[email protected]>
Peter Maydell (1):
Avoid address_space_rw() with a constant is_write argument
Philippe Mathieu-Daudé (19):
scripts/git.orderfile: Display Cocci scripts before code modifications
hw: Remove unnecessary cast when calling dma_memory_read()
exec: Let qemu_ram_*() functions take a const pointer argument
exec: Rename ram_ptr variable
exec: Let flatview API take void pointer arguments
exec: Let the address_space API use void pointer arguments hw/net: Avoid casting non-const pointer, use address_space_write() Remove unnecessary cast when using the address_space API
exec: Let the cpu_[physical]_memory API use void pointer arguments Remove unnecessary cast when using the cpu_[physical]_memory API hw/ide/internal: Remove unused DMARestartFunc typedef hw/ide: Let the DMAIntFunc prototype use a boolean 'is_write' argument hw/virtio: Let virtqueue_map_iovec() use a boolean 'is_write' argument hw/virtio: Let vhost_memory_map() use a boolean 'is_write' argument
exec: Let address_space_unmap() use a boolean 'is_write' argument Let address_space_rw() calls pass a boolean 'is_write' argument
exec: Let cpu_[physical]_memory API use a boolean 'is_write' argument Let cpu_[physical]_memory() calls pass a boolean 'is_write' argument Avoid cpu_physical_memory_rw() with a constant is_write argument
scripts/coccinelle/exec_rw_const.cocci | 103 +++++++++++++++++++++++++ include/exec/cpu-all.h | 2 +- include/exec/cpu-common.h | 18 ++--- include/exec/memory.h | 16 ++-- include/hw/ide/internal.h | 3 +- include/sysemu/xen-mapcache.h | 4 +- target/i386/hvf/vmx.h | 7 +- accel/kvm/kvm-all.c | 6 +- dma-helpers.c | 4 +- exec.c | 75 +++++++++--------- hw/arm/boot.c | 6 +- hw/arm/smmu-common.c | 3 +- hw/arm/smmuv3.c | 10 +-- hw/display/exynos4210_fimd.c | 3 +- hw/display/milkymist-tmu2.c | 8 +- hw/display/omap_dss.c | 2 +- hw/display/omap_lcdc.c | 10 +-- hw/display/ramfb.c | 2 +- hw/dma/etraxfs_dma.c | 25 +++--- hw/dma/rc4030.c | 10 +-- hw/dma/xlnx-zdma.c | 11 +-- hw/i386/xen/xen-mapcache.c | 2 +- hw/ide/ahci.c | 2 +- hw/ide/core.c | 2 +- hw/ide/macio.c | 2 +- hw/ide/pci.c | 2 +- hw/misc/pc-testdev.c | 2 +- hw/net/cadence_gem.c | 21 +++-- hw/net/dp8393x.c | 70 +++++++++-------- hw/net/i82596.c | 25 +++--- hw/net/lasi_i82596.c | 5 +- hw/nvram/spapr_nvram.c | 4 +- hw/ppc/pnv_lpc.c | 8 +- hw/ppc/ppc440_uc.c | 6 +- hw/ppc/spapr_hcall.c | 4 +- hw/s390x/css.c | 12 +-- hw/s390x/ipl.c | 2 +- hw/s390x/s390-pci-bus.c | 2 +- hw/s390x/virtio-ccw.c | 2 +- hw/scsi/vmw_pvscsi.c | 8 +- hw/sd/sdhci.c | 15 ++-- hw/virtio/vhost.c | 8 +- hw/virtio/virtio.c | 7 +- hw/xen/xen_pt_graphics.c | 2 +- qtest.c | 52 ++++++------- target/i386/hax-all.c | 6 +- target/i386/hvf/x86_mmu.c | 12 +-- target/i386/whpx-all.c | 2 +- target/s390x/excp_helper.c | 2 +- target/s390x/helper.c | 6 +- target/s390x/mmu_helper.c | 2 +- scripts/git.orderfile | 3 + 52 files changed, 360 insertions(+), 266 deletions(-) create mode 100644 scripts/coccinelle/exec_rw_const.cocci
Signature · 1 line
2.21.1