Skip to content

Clean driver, module and FW versions

Leon Romanovsky netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16net/bond: Delete driver and module versionsdrivers/net/bonding/bond_main.c drivers/net/bonding/bonding_priv.h+3 -50 replies
2/16net/dummy: Ditch driver and module versionsdrivers/net/dummy.c+0 -32 replies
3/16net/3com: Delete driver and module versions from 3com driversdrivers/net/ethernet/3com/3c509.c drivers/net/ethernet/3com/3c515.c drivers/net/ethernet/3com/3c589_cs.c +1 more+3 -130 replies
4/16net/adaptec: Clean driver versionsdrivers/net/ethernet/adaptec/starfire.c+5 -60 replies
5/16net/aeroflex: Clean ethtool_info struct assignmentsdrivers/net/ethernet/aeroflex/greth.c+0 -20 replies
6/16net/agere: Delete unneeded driver versiondrivers/net/ethernet/agere/et131x.c drivers/net/ethernet/agere/et131x.h+0 -20 replies
7/16net/alacritech: Delete driver versiondrivers/net/ethernet/alacritech/slicoss.c+0 -30 replies
8/16net/allwinner: Remove driver versiondrivers/net/ethernet/allwinner/sun4i-emac.c+0 -20 replies
9/16net/alteon: Properly report FW versiondrivers/net/ethernet/alteon/acenic.c+2 -30 replies
10/16net/althera: Delete hardcoded driver versiondrivers/net/ethernet/altera/altera_tse_ethtool.c+0 -10 replies
11/16net/amazon: Ensure that driver version is aligned to the linux kerneldrivers/net/ethernet/amazon/ena/ena_ethtool.c drivers/net/ethernet/amazon/ena/ena_netdev.c drivers/net/ethernet/amazon/ena/ena_netdev.h+2 -272 replies
12/16net/amd: Remove useless driver versiondrivers/net/ethernet/amd/amd8111e.c drivers/net/ethernet/amd/au1000_eth.c drivers/net/ethernet/amd/nmclan_cs.c +5 more+4 -350 replies
13/16net/apm: Remove useless driver version and properly mark lack of FWdrivers/net/ethernet/apm/xgene-v2/ethtool.c drivers/net/ethernet/apm/xgene-v2/main.c drivers/net/ethernet/apm/xgene-v2/main.h +3 more+0 -80 replies
14/16net/aquantia: Delete module versiondrivers/net/ethernet/aquantia/atlantic/aq_cfg.h drivers/net/ethernet/aquantia/atlantic/aq_common.h drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c +2 more+0 -190 replies
15/16net/arc: Delete driver versiondrivers/net/ethernet/arc/emac.h drivers/net/ethernet/arc/emac_arc.c drivers/net/ethernet/arc/emac_main.c +1 more+0 -60 replies
16/16net/atheros: Clean atheros code from driver versiondrivers/net/ethernet/atheros/atl1c/atl1c.h drivers/net/ethernet/atheros/atl1c/atl1c_ethtool.c drivers/net/ethernet/atheros/atl1c/atl1c_main.c +5 more+0 -310 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 00/16] Clean driver, module and FW versions

From: Leon Romanovsky <[email protected]>

Hi,

This is first patchset to netdev (already sent RDMA [1] and arch/um) in attempt to unify the version management for in-tree kernel code. The patches follow already accepted ethtool change [2] to set as a default linux kernel version.

It allows us to remove driver version and present to the users unified picture of driver version, which is similar to default MODULE_VERSION().

As part of this series, I deleted various creative attempts to mark absence of FW. There is no need to set "N/A" in ethtool ->fw_version field and it is enough to do not set it.

1.
The code is compile tested and passes 0-day kbuild.
2.
The proposed changes are based on commit:
2bb07f4e1d86 ("tc-testing: updated tdc tests for basic filter")
3.
WIP branch is [3].

[1] https://lore.kernel.org/linux-rdma/[email protected]/
[2] https://lore.kernel.org/linux-rdma/[email protected]/
[3] https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/log/?h=ethtool

Leon Romanovsky (16):
net/bond: Delete driver and module versions
net/dummy: Ditch driver and module versions
net/3com: Delete driver and module versions from 3com drivers net/adaptec: Clean driver versions
net/aeroflex: Clean ethtool_info struct assignments net/agere: Delete unneeded driver version
net/alacritech: Delete driver version
net/allwinner: Remove driver version
net/alteon: Properly report FW version
net/althera: Delete hardcoded driver version
net/amazon: Ensure that driver version is aligned to the linux kernel net/amd: Remove useless driver version
net/apm: Remove useless driver version and properly mark lack of FW net/aquantia: Delete module version
net/arc: Delete driver version
net/atheros: Clean atheros code from driver version

 drivers/net/bonding/bond_main.c                 |  4 +---
 drivers/net/bonding/bonding_priv.h              |  4 ++--
 drivers/net/dummy.c                             |  3 ---
 drivers/net/ethernet/3com/3c509.c               |  7 +------
 drivers/net/ethernet/3com/3c515.c               |  6 ++----
 drivers/net/ethernet/3com/3c589_cs.c            |  2 --
 drivers/net/ethernet/3com/typhoon.c             |  1 -
 drivers/net/ethernet/adaptec/starfire.c         | 11 +++++------
 drivers/net/ethernet/aeroflex/greth.c           |  2 --
 drivers/net/ethernet/agere/et131x.c             |  1 -
 drivers/net/ethernet/agere/et131x.h             |  1 -
 drivers/net/ethernet/alacritech/slicoss.c       |  3 ---
 drivers/net/ethernet/allwinner/sun4i-emac.c     |  2 --
 drivers/net/ethernet/alteon/acenic.c            |  5 ++---
 .../net/ethernet/altera/altera_tse_ethtool.c    |  1 -
 drivers/net/ethernet/amazon/ena/ena_ethtool.c   |  1 -
 drivers/net/ethernet/amazon/ena/ena_netdev.c    | 17 ++---------------
 drivers/net/ethernet/amazon/ena/ena_netdev.h    | 11 -----------
 drivers/net/ethernet/amd/amd8111e.c             |  5 +----
 drivers/net/ethernet/amd/au1000_eth.c           |  5 -----
 drivers/net/ethernet/amd/nmclan_cs.c            |  9 +++------
 drivers/net/ethernet/amd/pcnet32.c              |  7 -------
 drivers/net/ethernet/amd/sunlance.c             | 10 ----------
 drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c    |  1 -
 drivers/net/ethernet/amd/xgbe/xgbe-main.c       |  1 -
 drivers/net/ethernet/amd/xgbe/xgbe.h            |  1 -
 drivers/net/ethernet/apm/xgene-v2/ethtool.c     |  2 --
 drivers/net/ethernet/apm/xgene-v2/main.c        |  1 -
 drivers/net/ethernet/apm/xgene-v2/main.h        |  1 -
 .../net/ethernet/apm/xgene/xgene_enet_ethtool.c |  2 --
 .../net/ethernet/apm/xgene/xgene_enet_main.c    |  1 -
 .../net/ethernet/apm/xgene/xgene_enet_main.h    |  1 -
 drivers/net/ethernet/aquantia/atlantic/aq_cfg.h |  4 ----
 .../net/ethernet/aquantia/atlantic/aq_common.h  |  1 -
 .../net/ethernet/aquantia/atlantic/aq_ethtool.c |  1 -
 .../net/ethernet/aquantia/atlantic/aq_main.c    |  1 -
 drivers/net/ethernet/aquantia/atlantic/ver.h    | 12 ------------
 drivers/net/ethernet/arc/emac.h                 |  1 -
 drivers/net/ethernet/arc/emac_arc.c             |  2 --
 drivers/net/ethernet/arc/emac_main.c            |  1 -
 drivers/net/ethernet/arc/emac_rockchip.c        |  2 --
 drivers/net/ethernet/atheros/atl1c/atl1c.h      |  1 -
 .../net/ethernet/atheros/atl1c/atl1c_ethtool.c  |  2 --
 drivers/net/ethernet/atheros/atl1c/atl1c_main.c |  5 -----
 drivers/net/ethernet/atheros/atl1e/atl1e.h      |  1 -
 .../net/ethernet/atheros/atl1e/atl1e_ethtool.c  |  2 --
 drivers/net/ethernet/atheros/atl1e/atl1e_main.c |  4 ----
 drivers/net/ethernet/atheros/atlx/atl1.c        |  6 ------
 drivers/net/ethernet/atheros/atlx/atl2.c        | 10 ----------
 49 files changed, 19 insertions(+), 166 deletions(-)
 delete mode 100644 drivers/net/ethernet/aquantia/atlantic/ver.h

--
2.24.1