Skip to content

vt: fix some vt_ioctl races

Eric Biggers linux-serial lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesIn review
  2. v22 patches 5 repliesSuperseded
  3. v11 patch 7 repliesSuperseded

Changes in v3 from the cover letter

- Implemented tty_port_operations::destruct().
- Added comments regarding vt_in_use() locking.

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2vt: vt_ioctl: fix VT_DISALLOCATE freeing in-use virtual consoledrivers/tty/vt/vt.c drivers/tty/vt/vt_ioctl.c+26 -91 reply
2/2vt: vt_ioctl: fix use-after-free in vt_in_use()drivers/tty/vt/vt_ioctl.c+12 -41 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJiri Slaby
1/2A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] vt: fix some vt_ioctl races

Fix VT_DISALLOCATE freeing an in-use virtual console, and fix a use-after-free in vt_in_use().

Changed since v2:
- Implemented tty_port_operations::destruct().
- Added comments regarding vt_in_use() locking.

Changed since v1:
- Made the vc_data be freed via tty_port refcounting.
- Added patch to fix a use-after-free in vt_in_use().

Eric Biggers (2):
vt: vt_ioctl: fix VT_DISALLOCATE freeing in-use virtual console
vt: vt_ioctl: fix use-after-free in vt_in_use()

 drivers/tty/vt/vt.c       | 23 ++++++++++++++++++++++-
 drivers/tty/vt/vt_ioctl.c | 28 ++++++++++++++++------------
 2 files changed, 38 insertions(+), 13 deletions(-)
Signature · 1 line
2.25.2