Skip to content

RFC nvme: core layer metadata/pi support

James Smart linux-nvme 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6nvme: Add ns to nvme_request structdrivers/nvme/host/core.c drivers/nvme/host/nvme.h+3 -01 reply
2/6nvme: make nvme_ns_has_pi accessible to transportsdrivers/nvme/host/core.c drivers/nvme/host/nvme.h+6 -61 reply
3/6nvme: Introduce max_meta_segments ctrl and ops attributedrivers/nvme/host/core.c drivers/nvme/host/nvme.h drivers/nvme/host/pci.c+14 -42 replies
4/6nvme: Add t_flags and pi_blkszs ctrl and ops attributesdrivers/nvme/host/core.c drivers/nvme/host/nvme.h drivers/nvme/host/pci.c+66 -141 reply
5/6nvme: Add pi_flags to nvme_request for transport pi supportdrivers/nvme/host/core.c drivers/nvme/host/nvme.h+52 -51 reply
6/6nvme: Introduce NVME_INLINE_PROT_SG_CNTdrivers/nvme/host/nvme.h+2 -00 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchMax Gurtovoy
1/6
2/6
3/6
4/6
5/6
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC 0/6] nvme: core layer metadata/pi support

This patch set is alternative to the core layer mods proposed by Max Gurtovoy.

This set adds much the same functionality, but does so via transport ops flags that indicate capabilities that are then stamped into the controller. Transports can fine-tune the capabilities on a per-controller basis by tuning the controller flag values. The patches also use different language. Rather than introducing extended lba data terms and naming all metadata as "integrity" data, it keeps things generic as "metadata", that then may or may not contain pi data. It also revises some of the checks in the core layer to better show fabric deltas and options for metadata.

This patch set does not cover the patch adding a fabrics "pi_enable" option. That patch may still be used, but would be implemented differently in that the rdma transport would look for the option, and when set, revise the ctrl->t_flags after calling nvme_init_integrity. The rdma transport patches would also largely not change in function, but would change in the flags and how they would look for items.

This patch set does not address (yet) the nvmet side.

-- james

James Smart (6):
nvme: Add ns to nvme_request struct
nvme: make nvme_ns_has_pi accessible to transports
nvme: Introduce max_meta_segments ctrl and ops attribute
nvme: Add t_flags and pi_blkszs ctrl and ops attributes
nvme: Add pi_flags to nvme_request for transport pi support
nvme: Introduce NVME_INLINE_PROT_SG_CNT

 drivers/nvme/host/core.c | 115 +++++++++++++++++++++++++++++++++++++----------
 drivers/nvme/host/nvme.h |  46 +++++++++++++++++--
 drivers/nvme/host/pci.c  |   7 +++
 3 files changed, 141 insertions(+), 27 deletions(-)
Signature · 7 lines
2.16.4


_______________________________________________
linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme