Skip to content

i2c: i801: Fix iTCO_wdt resource creation if PMC is not present

Mika Westerberg linux-hwmon linux-i2c linux-watchdog lkml 2 versions – Applied

Status from this message: Applied to for-current, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 9 repliesApplied
  2. v13 patches 5 repliesSuperseded

Changes from the previous version from the cover letter

* Call request_region() also for iTCO_vendorsupport
* Drop the core populating ICH_RES_IO_SMI completely from i2c-i801.c

[1] https://lore.kernel.org/linux-hwmon/CAM1AHpQ4196tyD=HhBu-2donSsuogabkfP03v1YF26Q7_BgvgA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org/

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3watchdog: iTCO_wdt: Export vendorsupportdrivers/watchdog/iTCO_vendor.h drivers/watchdog/iTCO_vendor_support.c+11 -73 replies
2/3watchdog: iTCO_wdt: Make ICH_RES_IO_SMI optionaldrivers/watchdog/iTCO_wdt.c+16 -122 replies
3/3i2c: i801: Do not add ICH_RES_IO_SMI for the iTCO_wdt devicedrivers/i2c/busses/i2c-i801.c+12 -332 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchGuenter Roeck
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] i2c: i801: Fix iTCO_wdt resource creation if PMC is not present

Hi all,

This series aims to fix the issue reported by Martin Volf [1] that prevents the nct6775 driver from loading.

I added Fixes tag to the last patch but not stable tag because the other two patches it depends are not really stable material IMO. Please let me know if there is a better way to organize these :)

I tested this on Intel Whiskey Lake based system (CNL derived) and on Comet Lake-V based system (SPT derived and the iTCO_wdt still works and I can see the expected resources in /proc/ioports and /proc/iomem.

The previous version of the patch series can be found here:

https://lore.kernel.org/linux-hwmon/20200225123802.88984-1-mika.westerberg-VuQAYsv1563Yd54FQh9/[email protected]/

Changes from the previous version:

* Call request_region() also for iTCO_vendorsupport
* Drop the core populating ICH_RES_IO_SMI completely from i2c-i801.c

[1] https://lore.kernel.org/linux-hwmon/CAM1AHpQ4196tyD=HhBu-2donSsuogabkfP03v1YF26Q7_BgvgA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org/

Mika Westerberg (3):
watchdog: iTCO_wdt: Export vendorsupport
watchdog: iTCO_wdt: Make ICH_RES_IO_SMI optional
i2c: i801: Do not add ICH_RES_IO_SMI for the iTCO_wdt device

 drivers/i2c/busses/i2c-i801.c          | 45 +++++++-------------------
 drivers/watchdog/iTCO_vendor.h         |  2 ++
 drivers/watchdog/iTCO_vendor_support.c | 16 +++++----
 drivers/watchdog/iTCO_wdt.c            | 28 +++++++++-------
 4 files changed, 39 insertions(+), 52 deletions(-)
Signature · 1 line
2.25.0