Skip to content

Lost key-up interrupt handling for omap4-keypad

Tony Lindgren linux-input linux-omap lkml 5 versions – Applied

Status from this message: Applied, thank you.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest5 patches 15 repliesApplied
  2. v44 patches 6 repliesSuperseded
  3. v33 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v23 patches6 repliesSuperseded
v12 patches3 repliesSuperseded

Changes in v5 from the cover letter

- Rebase on Dmitry's devm patch

- Fix up kernel test robot warnings and mismerge of pm_ops when I rebased from v5.10 to Linux next

- Split up the patches further as suggested by Dmitry

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/5Input: omap4-keypad - disable unused long interruptsdrivers/input/keyboard/omap4-keypad.c+2 -31 reply
2/5Input: omap4-keypad - scan keys in two phases and simplify with bitmaskdrivers/input/keyboard/omap4-keypad.c+46 -233 replies
3/5Input: omap4-keypad - move rest of key scanning to a separate functiondrivers/input/keyboard/omap4-keypad.c+19 -63 replies
4/5Input: omap4-keypad - use PM runtime autosuspenddrivers/input/keyboard/omap4-keypad.c+38 -114 replies
5/5Input: omap4-keypad - implement errata check for lost key-up eventsdrivers/input/keyboard/omap4-keypad.c+30 -04 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCHv5 0/5] Lost key-up interrupt handling for omap4-keypad

Hi,

This series updates omap4-keypad to disable unused long interrupts, and implements the missing parts for the lost key-up interrupt quirk as described in the silicon errata pdf.

These are based on Linux next with the following pending patch applied:

"Input: omap4-keypad - switch to use managed resources"

Regards,

Tony

Changes since v4:

- Rebase on Dmitry's devm patch

- Fix up kernel test robot warnings and mismerge of pm_ops when I rebased from v5.10 to Linux next

- Split up the patches further as suggested by Dmitry

Changes since v3:

- Use PM runtime to check the last pressed key is not stuck

- Simplify probe with devm

Changes since v2:

- Drop bogus level change, that already comes from device tree

- Scan keyboard in two phases and simplify using a bitmask

- Use mod_delayed_work and cancel_delayed_work_sync for the quirk

Tony Lindgren (5):
Input: omap4-keypad - disable unused long interrupts
Input: omap4-keypad - scan keys in two phases and simplify with
bitmask
Input: omap4-keypad - move rest of key scanning to a separate function
Input: omap4-keypad - use PM runtime autosuspend
Input: omap4-keypad - implement errata check for lost key-up events

 drivers/input/keyboard/omap4-keypad.c | 172 ++++++++++++++++++++------
 1 file changed, 132 insertions(+), 40 deletions(-)
Signature · 1 line
2.30.0