Skip to content

drm: subsytem-wide debugfs functions refactor

Wambui Karuga dri-devel intel-gfx linux-arm-msm lkml nouveau 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest17 patches 15 repliesIn review
  2. v121 patches 17 repliesApplied

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17drm/tegra: remove checks for debugfs functions return valuedrivers/gpu/drm/tegra/dc.c drivers/gpu/drm/tegra/drm.c drivers/gpu/drm/tegra/dsi.c +2 more+8 -430 replies
2/17drm/tilcdc: remove check for return value of debugfs functions.drivers/gpu/drm/tilcdc/tilcdc_drv.c+4 -110 replies
3/17drm/v3d: make v3d_debugfs_init() return 0drivers/gpu/drm/v3d/v3d_debugfs.c+4 -30 replies
4/17drm/vc4: remove check of return value of drm_debugfs functionsdrivers/gpu/drm/vc4/vc4_debugfs.c+2 -50 replies
5/17drm/arc: make arcgpu_debugfs_init() return 0.drivers/gpu/drm/arc/arcpgu_drv.c+4 -21 reply
6/17drm/arm: make hdlcd_debugfs_init() return 0drivers/gpu/drm/arm/hdlcd_drv.c+4 -21 reply
7/17drm/etnaviv: remove check for return value of drm_debugfs_create_files()drivers/gpu/drm/etnaviv/etnaviv_drv.c+4 -121 reply
8/17drm/msm: remove checks for return value of drm_debugfs_create_files()drivers/gpu/drm/msm/adreno/a5xx_debugfs.c drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c drivers/gpu/drm/msm/msm_debugfs.c+10 -290 replies
9/17drm/sti: remove use of drm_debugfs functions as return valuesdrivers/gpu/drm/sti/sti_compositor.c drivers/gpu/drm/sti/sti_compositor.h drivers/gpu/drm/sti/sti_crtc.c +12 more+58 -740 replies
10/17drm/vram-helper: make drm_vram_mm_debugfs_init() return 0drivers/gpu/drm/drm_gem_vram_helper.c+4 -69 replies
11/17drm/nouveau: make nouveau_drm_debugfs_init() return 0drivers/gpu/drm/nouveau/nouveau_debugfs.c+8 -120 replies
12/17drm/pl111: make pl111_debugfs_init return 0drivers/gpu/drm/pl111/pl111_debugfs.c+5 -30 replies
13/17drm/omap: remove checks for return value of drm_debugfs functionsdrivers/gpu/drm/omapdrm/omap_debugfs.c+7 -200 replies
14/17drm/i915: have *_debugfs_init() functions return void.drivers/gpu/drm/i915/display/intel_display_debugfs.c drivers/gpu/drm/i915/display/intel_display_debugfs.h drivers/gpu/drm/i915/i915_debugfs.c +1 more+12 -121 reply
15/17drm: make various debugfs_init() functions return 0drivers/gpu/drm/drm_atomic.c drivers/gpu/drm/drm_client.c drivers/gpu/drm/drm_framebuffer.c+14 -90 replies
16/17drm/debugfs: remove checks for return value of drm_debugfs functions.drivers/gpu/drm/drm_debugfs.c include/drm/drm_debugfs.h+14 -350 replies
17/17drm: convert .debugfs_init() hook to return void.drivers/gpu/drm/arc/arcpgu_drv.c drivers/gpu/drm/arm/hdlcd_drv.c drivers/gpu/drm/arm/malidp_drv.c +36 more+58 -1180 replies

Reviews trailers per patch

5 of 17 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchThomas ZimmermannGreg Kroah-HartmanLiviu DudauJani NikulaLucas StachAlexey Brodkin
SeriesR-b
1/17
2/17
3/17
4/17
5/17A-b
6/17A-b
7/17A-b
8/17
9/17
10/17A-b
11/17
12/17
13/17
14/17R-b
15/17
16/17
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/17] drm: subsytem-wide debugfs functions refactor

This series includes work on various debugfs functions both in drm/core and across various drivers in the subsystem.
Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() does not fail and only returns zero. This series therefore removes the left over error handling and checks for its return value across drm drivers.

As a result of these changes, most drm_debugfs functions are converted to return void in this series. This also enables the drm_driver, debugfs_init() hook to be changed to return void.

v2: individual driver patches have been converted to have debugfs functions return 0 instead of void to prevent breaking individual driver builds.
The last patch then converts the .debugfs_hook() and its users across all drivers to return void.

Wambui Karuga (17):
drm/tegra: remove checks for debugfs functions return value drm/tilcdc: remove check for return value of debugfs functions. drm/v3d: make v3d_debugfs_init() return 0
drm/vc4: remove check of return value of drm_debugfs functions drm/arc: make arcgpu_debugfs_init() return 0.
drm/arm: make hdlcd_debugfs_init() return 0
drm/etnaviv: remove check for return value of
drm_debugfs_create_files()
drm/msm: remove checks for return value of drm_debugfs_create_files() drm/sti: remove use of drm_debugfs functions as return values drm/vram-helper: make drm_vram_mm_debugfs_init() return 0 drm/nouveau: make nouveau_drm_debugfs_init() return 0 drm/pl111: make pl111_debugfs_init return 0
drm/omap: remove checks for return value of drm_debugfs functions drm/i915: have *_debugfs_init() functions return void.
drm: make various debugfs_init() functions return 0 drm/debugfs: remove checks for return value of drm_debugfs functions.
drm: convert .debugfs_init() hook to return void.

 drivers/gpu/drm/arc/arcpgu_drv.c              |  7 +--
 drivers/gpu/drm/arm/hdlcd_drv.c               |  7 +--
 drivers/gpu/drm/arm/malidp_drv.c              |  3 +-
 drivers/gpu/drm/drm_atomic.c                  |  8 ++--
 drivers/gpu/drm/drm_client.c                  |  8 ++--
 drivers/gpu/drm/drm_crtc_internal.h           |  2 +-
 drivers/gpu/drm/drm_debugfs.c                 | 45 +++++--------------
 drivers/gpu/drm/drm_framebuffer.c             |  8 ++--
 drivers/gpu/drm/drm_gem_vram_helper.c         | 14 ++----
 drivers/gpu/drm/drm_internal.h                |  2 +-
 drivers/gpu/drm/drm_mipi_dbi.c                |  6 +--
 drivers/gpu/drm/etnaviv/etnaviv_drv.c         | 18 ++------
 .../drm/i915/display/intel_display_debugfs.c  |  8 ++--
 .../drm/i915/display/intel_display_debugfs.h  |  4 +-
 drivers/gpu/drm/i915/i915_debugfs.c           |  8 ++--
 drivers/gpu/drm/i915/i915_debugfs.h           |  4 +-
 drivers/gpu/drm/msm/adreno/a5xx_debugfs.c     | 18 +++-----
 drivers/gpu/drm/msm/adreno/a5xx_gpu.h         |  2 +-
 drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c      | 14 ++----
 drivers/gpu/drm/msm/msm_debugfs.c             | 23 +++-------
 drivers/gpu/drm/msm/msm_debugfs.h             |  2 +-
 drivers/gpu/drm/msm/msm_gpu.h                 |  2 +-
 drivers/gpu/drm/nouveau/nouveau_debugfs.c     | 26 +++++------
 drivers/gpu/drm/nouveau/nouveau_debugfs.h     |  8 ++--
 drivers/gpu/drm/omapdrm/omap_debugfs.c        | 29 +++---------
 drivers/gpu/drm/omapdrm/omap_drv.h            |  2 +-
 drivers/gpu/drm/pl111/pl111_debugfs.c         |  8 ++--
 drivers/gpu/drm/pl111/pl111_drm.h             |  2 +-
 drivers/gpu/drm/qxl/qxl_debugfs.c             | 21 +++------
 drivers/gpu/drm/qxl/qxl_drv.h                 | 13 +++---
 drivers/gpu/drm/qxl/qxl_ttm.c                 |  6 +--
 drivers/gpu/drm/sti/sti_compositor.c          |  6 +--
 drivers/gpu/drm/sti/sti_compositor.h          |  4 +-
 drivers/gpu/drm/sti/sti_crtc.c                |  2 +-
 drivers/gpu/drm/sti/sti_cursor.c              | 14 +++---
 drivers/gpu/drm/sti/sti_drv.c                 | 16 ++-----
 drivers/gpu/drm/sti/sti_dvo.c                 | 13 +++---
 drivers/gpu/drm/sti/sti_gdp.c                 |  7 +--
 drivers/gpu/drm/sti/sti_hda.c                 | 13 +++---
 drivers/gpu/drm/sti/sti_hdmi.c                | 13 +++---
 drivers/gpu/drm/sti/sti_hqvdp.c               | 12 ++---
 drivers/gpu/drm/sti/sti_mixer.c               | 10 ++---
 drivers/gpu/drm/sti/sti_mixer.h               |  2 +-
 drivers/gpu/drm/sti/sti_tvout.c               | 13 +++---
 drivers/gpu/drm/sti/sti_vid.c                 |  8 ++--
 drivers/gpu/drm/sti/sti_vid.h                 |  2 +-
 drivers/gpu/drm/tegra/dc.c                    | 11 +----
 drivers/gpu/drm/tegra/drm.c                   |  8 ++--
 drivers/gpu/drm/tegra/dsi.c                   | 11 +----
 drivers/gpu/drm/tegra/hdmi.c                  | 11 +----
 drivers/gpu/drm/tegra/sor.c                   | 11 +----
 drivers/gpu/drm/tilcdc/tilcdc_drv.c           | 17 ++-----
 drivers/gpu/drm/v3d/v3d_debugfs.c             |  8 ++--
 drivers/gpu/drm/v3d/v3d_drv.h                 |  2 +-
 drivers/gpu/drm/vc4/vc4_debugfs.c             | 11 ++---
 drivers/gpu/drm/vc4/vc4_drv.h                 |  2 +-
 drivers/gpu/drm/virtio/virtgpu_debugfs.c      |  3 +-
 drivers/gpu/drm/virtio/virtgpu_drv.h          |  2 +-
 include/drm/drm_client.h                      |  2 +-
 include/drm/drm_debugfs.h                     | 16 +++----
 include/drm/drm_drv.h                         |  2 +-
 include/drm/drm_gem_vram_helper.h             |  2 +-
 include/drm/drm_mipi_dbi.h                    |  2 +-
 63 files changed, 204 insertions(+), 380 deletions(-)
Signature · 1 line
2.25.1