Skip to content

qapi: Bye-bye Python 2

Markus Armbruster qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 6 repliesIn review
  2. v14 patches 7 repliesSuperseded

Changes in v2 from the cover letter

* PATCH 3: Don't mess up indentation
* PATCH 4: Additionally clean up a pycodestyle-3 "E713 test for membership should be 'not in'"

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4qapi: Inheriting from object is pointless with Python 3, dropscripts/qapi/gen.py scripts/qapi/parser.py scripts/qapi/schema.py +1 more+12 -121 reply
2/4qapi: Drop conditionals for Python 2scripts/qapi/common.py scripts/qapi/gen.py scripts/qapi/parser.py +1 more+4 -201 reply
3/4qapi: Use super() now we have Python 3scripts/qapi/commands.py scripts/qapi/error.py scripts/qapi/events.py +6 more+43 -441 reply
4/4qapi: Brush off some (py)lintscripts/qapi/commands.py scripts/qapi/expr.py scripts/qapi/gen.py +3 more+15 -183 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPhilippe Mathieu-DaudéJohn Snow
1/4R-b R-b
2/4R-b R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] qapi: Bye-bye Python 2

v2:
* PATCH 3: Don't mess up indentation
* PATCH 4: Additionally clean up a pycodestyle-3 "E713 test for membership should be 'not in'"

Markus Armbruster (4):
qapi: Inheriting from object is pointless with Python 3, drop
qapi: Drop conditionals for Python 2
qapi: Use super() now we have Python 3
qapi: Brush off some (py)lint

 scripts/qapi/commands.py       |  6 +--
 scripts/qapi/common.py         |  6 +--
 scripts/qapi/error.py          |  4 +-
 scripts/qapi/events.py         |  4 +-
 scripts/qapi/expr.py           |  3 +-
 scripts/qapi/gen.py            | 27 ++++++-------
 scripts/qapi/introspect.py     |  6 +--
 scripts/qapi/parser.py         | 20 ++++-----
 scripts/qapi/schema.py         | 74 +++++++++++++++++-----------------
 scripts/qapi/source.py         |  4 +-
 scripts/qapi/types.py          |  4 +-
 scripts/qapi/visit.py          |  4 +-
 tests/qapi-schema/test-qapi.py |  6 +--
 13 files changed, 74 insertions(+), 94 deletions(-)
Signature · 1 line
2.21.1