Skip to content

Fix qla2xxx endianness annotations

Bart Van Assche linux-scsi 8 versions – Applied

Status from this message: Applied to 5.8/scsi-queue, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest15 patches 8 repliesApplied
  2. v615 patches 17 repliesSuperseded
  3. v5 posting 2/215 patches 6 repliesSuperseded
Earlier versions · 5
VersionPostedPatchesRepliesStatus
v5 posting 1/211 patches9 repliesSuperseded
v411 patches47 repliesSuperseded
v36 patches2 repliesSuperseded
v26 patches0 repliesSuperseded
v14 patches10 repliesSuperseded

Changes in v7 from the cover letter

- Changed the endianness of qla27xx_fwdt_template.firmware_version from CPU-endian into little endian.

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/15qla2xxx: Fix spelling of a variable namedrivers/scsi/qla2xxx/qla_fw.h drivers/scsi/qla2xxx/qla_init.c+3 -30 replies
2/15qla2xxx: Suppress two recently introduced compiler warningsinclude/trace/events/qla.h+7 -00 replies
3/15qla2xxx: Simplify the functions for dumping firmwaredrivers/scsi/qla2xxx/qla_bsg.c drivers/scsi/qla2xxx/qla_dbg.c drivers/scsi/qla2xxx/qla_def.h +8 more+71 -1560 replies
4/15qla2xxx: Sort BUILD_BUG_ON() statements alphabeticallydrivers/scsi/qla2xxx/qla_os.c+2 -20 replies
5/15qla2xxx: Add more BUILD_BUG_ON() statementsdrivers/scsi/qla2xxx/qla_os.c drivers/scsi/qla2xxx/tcm_qla2xxx.c+72 -00 replies
6/15qla2xxx: Make a gap in struct qla2xxx_offld_chain explicitdrivers/scsi/qla2xxx/qla_dbg.h+1 -00 replies
7/15qla2xxx: Increase the size of struct qla_fcp_prio_cfg to FCP_PRIO_CFG_SIZEdrivers/scsi/qla2xxx/qla_fw.h drivers/scsi/qla2xxx/qla_os.c+3 -10 replies
8/15qla2xxx: Change two hardcoded constants into offsetof() / sizeof() expressionsdrivers/scsi/qla2xxx/qla_fw.h drivers/scsi/qla2xxx/qla_sup.c+2 -30 replies
9/15qla2xxx: Use register names instead of register offsetsdrivers/scsi/qla2xxx/qla_tmpl.c+4 -40 replies
10/15qla2xxx: Fix the code that reads from mailbox registersdrivers/scsi/qla2xxx/qla_def.h drivers/scsi/qla2xxx/qla_init.c drivers/scsi/qla2xxx/qla_iocb.c +5 more+67 -320 replies
11/15qla2xxx: Change {RD,WRT}_REG_*() function names from upper case into lower casedrivers/scsi/qla2xxx/qla_dbg.c drivers/scsi/qla2xxx/qla_def.h drivers/scsi/qla2xxx/qla_init.c +13 more+790 -7910 replies
12/15qla2xxx: Cast explicitly to uint16_t / uint32_tdrivers/scsi/qla2xxx/qla_dbg.c drivers/scsi/qla2xxx/qla_init.c drivers/scsi/qla2xxx/qla_mbx.c +7 more+39 -391 reply
13/15qla2xxx: Use make_handle() instead of open-coding itdrivers/scsi/qla2xxx/qla_isr.c+5 -50 replies
14/15qla2xxx: Fix endianness annotations in header filesdrivers/scsi/qla2xxx/qla_dbg.h drivers/scsi/qla2xxx/qla_def.h drivers/scsi/qla2xxx/qla_fw.h +6 more+1100 -11000 replies
15/15qla2xxx: Fix endianness annotations in source filesdrivers/scsi/qla2xxx/qla_attr.c drivers/scsi/qla2xxx/qla_bsg.c drivers/scsi/qla2xxx/qla_dbg.c +11 more+329 -3196 replies

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchDaniel WagnerHimanshu MadhaniHannes ReineckeArun EasiRoman Bolshakov
1/15R-b R-b R-b R-b R-b
2/15R-b R-b R-b R-b
3/15R-b R-b
4/15R-b R-b R-b R-b
5/15R-b R-b R-b
6/15R-b R-b R-b R-b
7/15R-b R-b R-b
8/15R-b R-b R-b R-b
9/15R-b R-b R-b
10/15R-b R-b R-b
11/15R-b R-b R-b
12/15R-b R-b
13/15R-b R-b R-b R-b
14/15R-b R-b
15/15R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v7 thread

Cover letter [PATCH v7 00/15] Fix qla2xxx endianness annotations

Hi Martin,

This patch series fixes the endianness annotations in the qla2xxx driver. Please consider this patch series for the v5.8 kernel.

Thanks,

Bart.

Changes compared to v6:
- Changed the endianness of qla27xx_fwdt_template.firmware_version from CPU-endian into little endian.

Changes compared to v5:
- Added Reviewed-by tags posted as replies to v4 and v5.

Changes compared to v4:
- Addressed Hannes' and most of Arun's review comments.
- Suppressed a clang warning for the patch that suppresses a gcc warning.
- Included three new patches. Two of these patches compensate for recently introduced changes (broken C=2 build and using register offsets instead of register names) and one new patch to make the last patch in this series easier to read.

Changes compared to v3:
- Included several source code cleanup patches, e.g. to address isssues detected by checkpatch.

Changes compared to v2:
- Removed one BUILD_BUG_ON() statement.

Changes compared to v1:
- Left out the raw_smp_processor_id() patch because it may take time to achieve agreement about this patch.
- Added three patches to this series: two patches for verifying structure size at compile time and one patch for changing function names from upper case to lower case.

Bart Van Assche (15):
qla2xxx: Fix spelling of a variable name
qla2xxx: Suppress two recently introduced compiler warnings
qla2xxx: Simplify the functions for dumping firmware
qla2xxx: Sort BUILD_BUG_ON() statements alphabetically
qla2xxx: Add more BUILD_BUG_ON() statements
qla2xxx: Make a gap in struct qla2xxx_offld_chain explicit
qla2xxx: Increase the size of struct qla_fcp_prio_cfg to
FCP_PRIO_CFG_SIZE
qla2xxx: Change two hardcoded constants into offsetof() / sizeof()
expressions
qla2xxx: Use register names instead of register offsets
qla2xxx: Fix the code that reads from mailbox registers
qla2xxx: Change {RD,WRT}_REG_*() function names from upper case into
lower case
qla2xxx: Cast explicitly to uint16_t / uint32_t
qla2xxx: Use make_handle() instead of open-coding it
qla2xxx: Fix endianness annotations in header files
qla2xxx: Fix endianness annotations in source files

 drivers/scsi/qla2xxx/qla_attr.c    |   3 +-
 drivers/scsi/qla2xxx/qla_bsg.c     |   8 +-
 drivers/scsi/qla2xxx/qla_dbg.c     | 826 +++++++++++++----------------
 drivers/scsi/qla2xxx/qla_dbg.h     | 443 ++++++++--------
 drivers/scsi/qla2xxx/qla_def.h     | 715 +++++++++++++------------
 drivers/scsi/qla2xxx/qla_fw.h      | 768 +++++++++++++--------------
 drivers/scsi/qla2xxx/qla_gbl.h     |  21 +-
 drivers/scsi/qla2xxx/qla_init.c    | 286 +++++-----
 drivers/scsi/qla2xxx/qla_inline.h  |   8 +-
 drivers/scsi/qla2xxx/qla_iocb.c    | 135 ++---
 drivers/scsi/qla2xxx/qla_isr.c     | 237 ++++-----
 drivers/scsi/qla2xxx/qla_mbx.c     | 123 +++--
 drivers/scsi/qla2xxx/qla_mid.c     |   4 +-
 drivers/scsi/qla2xxx/qla_mr.c      | 115 ++--
 drivers/scsi/qla2xxx/qla_mr.h      |  32 +-
 drivers/scsi/qla2xxx/qla_nvme.c    |  16 +-
 drivers/scsi/qla2xxx/qla_nvme.h    |  64 +--
 drivers/scsi/qla2xxx/qla_nx.c      | 163 +++---
 drivers/scsi/qla2xxx/qla_nx.h      |  36 +-
 drivers/scsi/qla2xxx/qla_nx2.c     |  18 +-
 drivers/scsi/qla2xxx/qla_os.c      | 124 +++--
 drivers/scsi/qla2xxx/qla_sup.c     | 323 +++++------
 drivers/scsi/qla2xxx/qla_target.c  | 104 ++--
 drivers/scsi/qla2xxx/qla_target.h  | 232 ++++----
 drivers/scsi/qla2xxx/qla_tmpl.c    |  41 +-
 drivers/scsi/qla2xxx/qla_tmpl.h    |   2 +-
 drivers/scsi/qla2xxx/tcm_qla2xxx.c |  14 +
 include/trace/events/qla.h         |   7 +
 28 files changed, 2454 insertions(+), 2414 deletions(-)