Skip to content

pie: minor improvements

Leslie Monis netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v14 patches 1 replySuperseded

Changes in v2 from the cover letter

- Kept 8 as the argument to prandom_bytes() instead of changing it to 7 as suggested by David Miller.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4pie: use term backlog instead of qleninclude/net/pie.h net/sched/sch_pie.c+16 -160 replies
2/4pie: remove unnecessary type castingnet/sched/sch_pie.c+2 -20 replies
3/4pie: remove pie_vars->accu_prob_overflowsinclude/net/pie.h net/sched/sch_fq_pie.c net/sched/sch_pie.c+7 -200 replies
4/4pie: realign commentinclude/net/pie.h+9 -90 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJakub Kicinski
SeriesR-b
1/4
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net-next v2 0/4] pie: minor improvements

This patch series includes the following minor changes with respect to the PIE/FQ-PIE qdiscs:

- Patch 1 removes some ambiguity by using the term "backlog" instead of "qlen" when referring to the queue length in bytes.
- Patch 2 removes redundant type casting on two expressions.
- Patch 3 removes the pie_vars->accu_prob_overflows variable without affecting the precision in calculations and makes the size of the pie_vars structure exactly 64 bytes.
- Patch 4 realigns a comment affected by a change in patch 3.

Changes from v1 to v2:
- Kept 8 as the argument to prandom_bytes() instead of changing it to 7 as suggested by David Miller.

Leslie Monis (4):
pie: use term backlog instead of qlen
pie: remove unnecessary type casting
pie: remove pie_vars->accu_prob_overflows
pie: realign comment

 include/net/pie.h      | 31 +++++++++++++---------------
 net/sched/sch_fq_pie.c |  1 -
 net/sched/sch_pie.c    | 47 +++++++++++++++++-------------------------
 3 files changed, 33 insertions(+), 46 deletions(-)
Signature · 1 line
2.17.1