Skip to content

net: add missing netlink policies

Jakub Kicinski linux-can linux-wpan netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16devlink: validate length of param valuesnet/core/devlink.c+19 -121 reply
2/16devlink: validate length of region addr/lennet/core/devlink.c+2 -01 reply
3/16fib: add missing attribute validation for tun_idinclude/net/fib_rules.h+1 -01 reply
4/16nl802154: add missing attribute validationnet/ieee802154/nl_policy.c+5 -01 reply
5/16nl802154: add missing attribute validation for dev_typenet/ieee802154/nl_policy.c+1 -02 replies
6/16can: add missing attribute validation for terminationdrivers/net/can/dev.c+1 -01 reply
7/16macsec: add missing attribute validation for portdrivers/net/macsec.c+1 -00 replies
8/16openvswitch: add missing attribute validation for hashnet/openvswitch/datapath.c+1 -01 reply
9/16net: fq: add missing attribute validation for orphan masknet/sched/sch_fq.c+1 -00 replies
10/16net: taprio: add missing attribute validation for txtime delaynet/sched/sch_taprio.c+1 -01 reply
11/16team: add missing attribute validation for port ifindexdrivers/net/team/team.c+1 -01 reply
12/16team: add missing attribute validation for array indexdrivers/net/team/team.c+1 -01 reply
13/16tipc: add missing attribute validation for MTU propertynet/tipc/netlink.c+1 -01 reply
14/16nfc: add missing attribute validation for SE APInet/nfc/netlink.c+1 -00 replies
15/16nfc: add missing attribute validation for deactivate targetnet/nfc/netlink.c+1 -00 replies
16/16nfc: add missing attribute validation for vendor subcommandnet/nfc/netlink.c+2 -00 replies

Reviews trailers per patch

10 of 16 patches have a Reviewed-by or Acked-by.

PatchJiri PirkoStefan SchmidtDavid AhernVinicius Costa GomesOliver HartkoppGreg Rose
1/16R-b
2/16R-b
3/16R-b
4/16A-b
5/16A-b
6/16A-b
7/16
8/16R-b
9/16
10/16R-b
11/16R-b
12/16R-b
13/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v1 thread

Cover letter [PATCH net 00/16] net: add missing netlink policies

Hi!

Recent one-off fixes motivated me to do some grepping for more missing netlink attribute policies. I didn't manage to even produce a KASAN splat with these, but it should be possible with sufficient luck. All the missing policies are pretty trivial (NLA_Uxx).

I've only tested the devlink patches, the rest compiles.

Jakub Kicinski (16):
devlink: validate length of param values
devlink: validate length of region addr/len
fib: add missing attribute validation for tun_id
nl802154: add missing attribute validation
nl802154: add missing attribute validation for dev_type
can: add missing attribute validation for termination
macsec: add missing attribute validation for port
openvswitch: add missing attribute validation for hash
net: fq: add missing attribute validation for orphan mask
net: taprio: add missing attribute validation for txtime delay
team: add missing attribute validation for port ifindex
team: add missing attribute validation for array index
tipc: add missing attribute validation for MTU property
nfc: add missing attribute validation for SE API
nfc: add missing attribute validation for deactivate target
nfc: add missing attribute validation for vendor subcommand

 drivers/net/can/dev.c      |  1 +
 drivers/net/macsec.c       |  1 +
 drivers/net/team/team.c    |  2 ++
 include/net/fib_rules.h    |  1 +
 net/core/devlink.c         | 33 +++++++++++++++++++++------------
 net/ieee802154/nl_policy.c |  6 ++++++
 net/nfc/netlink.c          |  4 ++++
 net/openvswitch/datapath.c |  1 +
 net/sched/sch_fq.c         |  1 +
 net/sched/sch_taprio.c     |  1 +
 net/tipc/netlink.c         |  1 +
 11 files changed, 40 insertions(+), 12 deletions(-)
Signature · 1 line
2.24.1