Skip to content

Fix IPv6 peer route update

Hangbin Liu netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3net/ipv6: need update peer route when modify metricnet/ipv6/addrconf.c+16 -41 reply
2/3net/ipv6: remove the old peer route if change it to a new onenet/ipv6/addrconf.c+17 -41 reply
3/3selftests/net/fib_tests: update addr_metric_test for peer route testingtools/testing/selftests/net/fib_tests.sh+31 -31 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchDavid Ahern
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/3] Fix IPv6 peer route update

Currently we have two issues for peer route update on IPv6.
1. When update peer route metric, we only updated the local one.
2. If peer address changed, we didn't remove the old one and add new one.

The first two patches fixed these issues and the third patch add new tests to cover it.

With the fixes and updated test:
]# ./fib_tests.sh
IPv6 prefix route tests

    TEST: Default metric                                                [ OK ]
    TEST: User specified metric on first device                         [ OK ]
    TEST: User specified metric on second device                        [ OK ]
    TEST: Delete of address on first device                             [ OK ]
    TEST: Modify metric of address                                      [ OK ]
    TEST: Prefix route removed on link down                             [ OK ]
    TEST: Prefix route with metric on link up                           [ OK ]
    TEST: Set metric with peer route on local side                      [ OK ]
    TEST: User specified metric on local address                        [ OK ]
    TEST: Set metric with peer route on peer side                       [ OK ]
    TEST: Modify metric with peer route on local side                   [ OK ]
    TEST: Modify metric with peer route on peer side                    [ OK ]

IPv4 prefix route tests

    TEST: Default metric                                                [ OK ]
    TEST: User specified metric on first device                         [ OK ]
    TEST: User specified metric on second device                        [ OK ]
    TEST: Delete of address on first device                             [ OK ]
    TEST: Modify metric of address                                      [ OK ]
    TEST: Prefix route removed on link down                             [ OK ]
    TEST: Prefix route with metric on link up                           [ OK ]
    TEST: Modify metric of .0/24 address                                [ OK ]
    TEST: Set metric of address with peer route                         [ OK ]
    TEST: Modify metric of address with peer route                      [ OK ]
Tests passed:  22
Tests failed:   0

Hangbin Liu (3):
net/ipv6: need update peer route when modify metric net/ipv6: remove the old peer route if change it to a new one selftests/net/fib_tests: update addr_metric_test for peer route
testing

 net/ipv6/addrconf.c                      | 41 +++++++++++++++++++-----
 tools/testing/selftests/net/fib_tests.sh | 34 ++++++++++++++++++--
 2 files changed, 64 insertions(+), 11 deletions(-)
Signature · 1 line
2.19.2