Skip to content

btrfs: Move generic backref cache build functions to backref.c

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19btrfs: Move backref node/edge/cache structure to backref.hfs/btrfs/backref.h fs/btrfs/relocation.c+100 -910 replies
2/19btrfs: Rename tree_entry to simple_node and export itfs/btrfs/backref.h fs/btrfs/misc.h fs/btrfs/relocation.c+94 -750 replies
3/19btrfs: relocation: Make reloc root search specific for relocation backref cachefs/btrfs/backref.h fs/btrfs/ctree.h fs/btrfs/relocation.c+31 -80 replies
4/19btrfs: relocation: Add backref_cache::pending_edge and backref_cache::useless_node membersfs/btrfs/backref.h fs/btrfs/relocation.c+42 -280 replies
5/19btrfs: relocation: Add backref_cache::fs_info memberfs/btrfs/backref.h fs/btrfs/relocation.c+11 -90 replies
6/19btrfs: Move backref_cache_init() to backref.cfs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/relocation.c+18 -160 replies
7/19btrfs: Move alloc_backref_node() to backref.cfs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/relocation.c+22 -200 replies
8/19btrfs: Move alloc_backref_edge() to backref.cfs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/relocation.c+11 -100 replies
9/19btrfs: Move link_backref_edge() to backref.cfs/btrfs/backref.h fs/btrfs/relocation.c+16 -160 replies
10/19btrfs: Move free_backref_node() and free_backref_edge() to backref.hfs/btrfs/backref.h fs/btrfs/relocation.c+20 -190 replies
11/19btrfs: Move drop_backref_node() and needed facilities to backref.hfs/btrfs/backref.h fs/btrfs/relocation.c+37 -310 replies
12/19btrfs: Rename remove_backref_node() to cleanup_backref_node() and move it to backref.cfs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/relocation.c+51 -470 replies
13/19btrfs: Move backref_cache_cleanup() to backref.cfs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/relocation.c+31 -300 replies
14/19btrfs: Rename backref_tree_panic() to backref_cache_panic(), and move it to backref.cfs/btrfs/backref.h fs/btrfs/relocation.c+19 -220 replies
15/19btrfs: Rename should_ignore_root() to should_ignore_reloc_root() and export itfs/btrfs/ctree.h fs/btrfs/relocation.c+6 -40 replies
16/19btrfs: relocation: Open-code read_fs_root() for handle_one_tree_backref()fs/btrfs/relocation.c+5 -10 replies
17/19btrfs: Rename handle_one_tree_block() to backref_cache_add_one_tree_block() and move it to backref.cfs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/relocation.c+313 -3050 replies
18/19btrfs: relocation: Move the target backref node insert code into finish_upper_links()fs/btrfs/relocation.c+15 -150 replies
19/19btrfs: Rename finish_upper_links() to backref_cache_finish_upper_links() and move it to backref.cfs/btrfs/backref.c fs/btrfs/backref.h fs/btrfs/relocation.c+118 -1160 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/19] btrfs: Move generic backref cache build functions to backref.c

The patchset is based on previous backref_cache_refactor branch, which is further based on misc-next.

The whole series can be fetched from github:
https://github.com/adam900710/linux/tree/backref_cache_code_move

All the patches in previous branch is not touched at all, thus they are not re-sent in this patchset.

Currently there are 3 major parts of build_backref_tree():
- ITERATION
This will do a breadth-first search, starts from the target bytenr, and queue all parents into the backref cache.
The result is a temporary map, which is only single-directional, and involved new backref nodes are not yet inserted into the cache.

- WEAVING
Finish the map to make it bi-directional, and insert new nodes into the cache.

- CLEANUP
Cleanup the useless nodes, either remove it completely or add them into the cache as detached.

For the ITERATION part, there are only limited locations coupled with relocation.
And WEAVING part is completely independent from relocation. While the CLEANUP part, although it has some relocation related code, it's not a big hunk of code after all.

So, this patchset will move the ITERATION part, extracted as backref_cache_add_one_tree_block(), and the WEAVING part, extracted as backref_cache_finish_upper_links(), to backref.c, as the basis for later reuse of backref_cache.

Qu Wenruo (19):
btrfs: Move backref node/edge/cache structure to backref.h
btrfs: Rename tree_entry to simple_node and export it
btrfs: relocation: Make reloc root search specific for relocation
backref cache
btrfs: relocation: Add backref_cache::pending_edge and
backref_cache::useless_node members
btrfs: relocation: Add backref_cache::fs_info member
btrfs: Move backref_cache_init() to backref.c
btrfs: Move alloc_backref_node() to backref.c
btrfs: Move alloc_backref_edge() to backref.c
btrfs: Move link_backref_edge() to backref.c
btrfs: Move free_backref_node() and free_backref_edge() to backref.h
btrfs: Move drop_backref_node() and needed facilities to backref.h
btrfs: Rename remove_backref_node() to cleanup_backref_node() and move
it to backref.c
btrfs: Move backref_cache_cleanup() to backref.c
btrfs: Rename backref_tree_panic() to backref_cache_panic(), and move
it to backref.c
btrfs: Rename should_ignore_root() to should_ignore_reloc_root() and
export it
btrfs: relocation: Open-code read_fs_root() for
handle_one_tree_backref()
btrfs: Rename handle_one_tree_block() to
backref_cache_add_one_tree_block() and move it to backref.c
btrfs: relocation: Move the target backref node insert code into
finish_upper_links()
btrfs: Rename finish_upper_links() to
backref_cache_finish_upper_links() and move it to backref.c

 fs/btrfs/backref.c    | 534 ++++++++++++++++++++++++++
 fs/btrfs/backref.h    | 226 +++++++++++
 fs/btrfs/ctree.h      |   3 +
 fs/btrfs/misc.h       |  54 +++
 fs/btrfs/relocation.c | 870 ++++--------------------------------------
 5 files changed, 892 insertions(+), 795 deletions(-)
Signature · 1 line
2.25.1