hw/scsi/spapr_vscsi: Fix time bomb buffer overflow
Status from this message: Applied to ppc-for-5.0, thanks.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
Changes in v3 from the cover letter
- Fixed typo reported by Greg Kurz
- Addressed Paolo Bonzini review comments as an extra patch
- Added another patch converting a fprintf() call while here
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | hw/scsi/viosrp: Add missing 'hw/scsi/srp.h' includehw/ | +2 | 0 replies | |
| 2/7 | hw/scsi/spapr_vscsi: Use SRP_MAX_IU_LEN instead of sizeof flexible arrayhw/ | +3 | 0 replies | |
| 3/7 | hw/scsi/spapr_vscsi: Simplify a bithw/ | +3 | 0 replies | |
| 4/7 | hw/scsi/spapr_vscsi: Introduce req_iu() helperhw/ | +23 | 0 replies | |
| 5/7 | hw/scsi/spapr_vscsi: Do not mix SRP IU size with DMA buffer sizehw/ hw/ | +5 | 0 replies | |
| 6/7 | hw/scsi/spapr_vscsi: Prevent buffer overflowhw/ | +10 | 0 replies | |
| 7/7 | hw/scsi/spapr_vscsi: Convert debug fprintf() to trace eventhw/ hw/ | +2 | 0 replies |
Reviews trailers per patch
None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Paolo Bonzini |
|---|---|
| Series | R-b |
| 1/7 | |
| 2/7 | |
| 3/7 | |
| 4/7 | |
| 5/7 | |
| 6/7 | |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/7] hw/scsi/spapr_vscsi: Fix time bomb buffer overflow
This series fixes a possible buffer overflow.
Simples patches first (dissociate the buffer holding DMA requests with pointer to SRP Information Unit packets) to clean the issue in the penultimate patch.
v3:
- Fixed typo reported by Greg Kurz
- Addressed Paolo Bonzini review comments as an extra patch
- Added another patch converting a fprintf() call while here
v2:
- Addressed David Gibson review comments
Supersedes: <[email protected]>
Philippe Mathieu-Daudé (7):
hw/scsi/viosrp: Add missing 'hw/scsi/srp.h' include hw/scsi/spapr_vscsi: Use SRP_MAX_IU_LEN instead of sizeof flexible
array
hw/scsi/spapr_vscsi: Simplify a bit hw/scsi/spapr_vscsi: Introduce req_iu() helper hw/scsi/spapr_vscsi: Do not mix SRP IU size with DMA buffer size hw/scsi/spapr_vscsi: Prevent buffer overflow hw/scsi/spapr_vscsi: Convert debug fprintf() to trace event
hw/scsi/viosrp.h | 3 +- hw/scsi/spapr_vscsi.c | 72 +++++++++++++++++++++++++------------------ hw/scsi/trace-events | 1 + 3 files changed, 45 insertions(+), 31 deletions(-)
Signature · 1 line
2.21.1