Skip to content

hw, ui, virtfs-proxy-helper: Reduce QEMU .data/.rodata/.bss footprint

Philippe Mathieu-Daudé qemu-devel qemu-trivial 2 versions – Applied

Status from this message: Applied to my trivial-patches branch.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 14 repliesApplied
  2. v16 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- merged 2 series
- reworked hw/usb/quirks
- added R-b/A-b tags

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/9hw/audio/fmopl: Fix a typo twicehw/audio/fmopl.c+2 -22 replies
2/9hw/audio/fmopl: Move ENV_CURVE to .heap to save 32KiB of .bsshw/audio/fmopl.c+3 -16 replies
3/9hw/audio/intel-hda: Use memory region alias to reduce .rodata by 4.34MBhw/audio/intel-hda.c+10 -140 replies
4/9hw/net/e1000: Add readops/writeops typedefshw/net/e1000.c hw/net/e1000e_core.c+8 -40 replies
5/9hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .datahw/net/e1000.c hw/net/e1000e_core.c+4 -40 replies
6/9hw/usb/quirks: Use smaller types to reduce .rodata by 10KiBhw/usb/quirks.c hw/usb/quirks.h+15 -110 replies
7/9ui/curses: Make control_characters[] array constui/curses.c+1 -11 reply
8/9ui/curses: Move arrays to .heap to save 74KiB of .bssui/curses.c+6 -20 replies
9/9virtfs-proxy-helper: Make the helper_opts[] array constfsdev/virtfs-proxy-helper.c+1 -10 replies

Reviews trailers per patch

6 of 9 patches have a Reviewed-by or Acked-by.

PatchLaurent VivierDmitry FleytmanStefano GarzarellaGreg Kurz
1/9R-b R-b
2/9R-b
3/9
4/9R-b R-b
5/9R-b R-b
6/9
7/9R-b
8/9
9/9R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/9] hw, ui, virtfs-proxy-helper: Reduce QEMU .data/.rodata/.bss footprint

Since v1:
- merged 2 series
- reworked hw/usb/quirks
- added R-b/A-b tags

This series reduce the footprint of the QEMU binary:
.bss: 106KiB (moved to .heap)
.data: 1MiB
.rodata: 4.34MiB
(sizes on x86_64 building with -Os)

The elf-dissector tool [1] [2] helped to notice the big array.

[1] https://phabricator.kde.org/source/elf-dissector/
[2] https://www.volkerkrause.eu/2019/06/22/elf-dissector-aarch64-support.html
[heap equivalent tool working with QEMU: https://github.com/KDE/heaptrack]

Supersedes: <[email protected]>
Supersedes: <[email protected]>

Philippe Mathieu-Daudé (9):
hw/audio/fmopl: Fix a typo twice
hw/audio/fmopl: Move ENV_CURVE to .heap to save 32KiB of .bss hw/audio/intel-hda: Use memory region alias to reduce .rodata by

    4.34MB

hw/net/e1000: Add readops/writeops typedefs hw/net/e1000: Move macreg[] arrays to .rodata to save 1MiB of .data hw/usb/quirks: Use smaller types to reduce .rodata by 10KiB ui/curses: Make control_characters[] array const ui/curses: Move arrays to .heap to save 74KiB of .bss
virtfs-proxy-helper: Make the helper_opts[] array const

 hw/usb/quirks.h             | 22 +++++++++++++---------
 fsdev/virtfs-proxy-helper.c |  2 +-
 hw/audio/fmopl.c            |  8 +++++---
 hw/audio/intel-hda.c        | 24 ++++++++++--------------
 hw/net/e1000.c              |  6 ++++--
 hw/net/e1000e_core.c        |  6 ++++--
 hw/usb/quirks.c             |  4 ++--
 ui/curses.c                 | 10 +++++++---
 8 files changed, 46 insertions(+), 36 deletions(-)
Signature · 1 line
2.21.1