Skip to content

scsi: ufs: some cleanups and make the delay for host enabling customizable

Stanley Chu linux-arm-kernel linux-mediatek linux-scsi lkml 7 versions – Applied

Status from this message: Applied to 5.7/scsi-queue. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest7 patches 4 repliesApplied
  2. v67 patches 6 repliesSuperseded
  3. v58 patches 4 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v48 patches1 replySuperseded
v38 patches0 repliesSuperseded
v28 patches3 repliesSuperseded
v14 patches4 repliesSuperseded

Changes in v7 from the cover letter

- Fix patch #3 "scsi: ufs: introduce common delay function" (Bart Van Assche)
- Remove "can_sleep" related changes.
- Limit the usage of common delay function, for example, if delay time is fixed and larger than 10 us, using introduced common delay function is not required.
- Other related changes according to patch #3 changes

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/7scsi: ufs: fix uninitialized tx_lanes in ufshcd_disable_tx_lcc()drivers/scsi/ufs/ufshcd.c+1 -10 replies
2/7scsi: ufs: use an enum for host capabilitiesdrivers/scsi/ufs/ufshcd.h+37 -281 reply
3/7scsi: ufs: introduce common and flexible delay functiondrivers/scsi/ufs/ufshcd.c drivers/scsi/ufs/ufshcd.h+13 -02 replies
4/7scsi: ufs-mediatek: use common delay function for required placesdrivers/scsi/ufs/ufs-mediatek.c+2 -130 replies
5/7scsi: ufs: allow customized delay for host enablingdrivers/scsi/ufs/ufshcd.c drivers/scsi/ufs/ufshcd.h+3 -10 replies
6/7scsi: ufs: make HCE polling more compact to improve initialization latencydrivers/scsi/ufs/ufshcd.c+2 -20 replies
7/7scsi: ufs-mediatek: customize the delay for host enablingdrivers/scsi/ufs/ufs-mediatek.c drivers/scsi/ufs/ufs-mediatek.h+35 -90 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchAvri AltmanAsutosh DasCan GuoBean Huo
1/7R-b R-b R-b
2/7R-b R-b R-b R-b
3/7R-b R-b
4/7R-b
5/7R-b R-b
6/7R-b R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/7] scsi: ufs: some cleanups and make the delay for host enabling customizable

v6 -> v7
- Fix patch #3 "scsi: ufs: introduce common delay function" (Bart Van Assche)
- Remove "can_sleep" related changes.
- Limit the usage of common delay function, for example, if delay time is fixed and larger than 10 us, using introduced common delay function is not required.
- Other related changes according to patch #3 changes

v5 -> v6
- Drop patch #2 "scsi: ufs: remove init_prefetch_data in struct ufs_hba" in v5 because Can Guo has similar cleanup earlier in patch "scsi: ufs: Do not rely on prefetched data"

v4 -> v5
- Fix patch #7: Fix typo "initializatoin" in title

v3 -> v4
- In patch #8, fix incorrect condition of customized delay for host enabling

v2 -> v3
- Remove /arch/arm64/configs/defconfig chnage because it is for local test only

v1 -> v2
- Add patch #1 "scsi: ufs: fix uninitialized tx_lanes in ufshcd_disable_tx_lcc"
- Remove struct ufs_init_prefetch in patch #2 "scsi: ufs: remove init_prefetch_data in struct ufs_hba"
- Introduce common delay function in patch #4
- Replace all delay places by common delay function in ufs-mediatek in patch #5
- Use common delay function instead for host enabling delay in patch #6
- Add patch #7 "scsi: ufs: make HCE polling more compact to improve initializatoin latency"
- In patch #8, customize the delay in ufs_mtk_hce_enable_notify callback instead of ufs_mtk_init (Avri Altman)

Stanley Chu (7):
scsi: ufs: fix uninitialized tx_lanes in ufshcd_disable_tx_lcc()
scsi: ufs: use an enum for host capabilities
scsi: ufs: introduce common and flexible delay function
scsi: ufs-mediatek: use common delay function for required places
scsi: ufs: allow customized delay for host enabling
scsi: ufs: make HCE polling more compact to improve initialization
latency
scsi: ufs-mediatek: customize the delay for host enabling

 drivers/scsi/ufs/ufs-mediatek.c | 58 +++++++++++++++++-----------
 drivers/scsi/ufs/ufs-mediatek.h |  1 +
 drivers/scsi/ufs/ufshcd.c       | 21 +++++++++--
 drivers/scsi/ufs/ufshcd.h       | 67 +++++++++++++++++++--------------
 4 files changed, 93 insertions(+), 54 deletions(-)
Signature · 1 line
2.18.0