block: Relax restrictions for blockdev-snapshot
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 8 repliesIn review
- v14 patches 1 replySuperseded
Changes in v2 from the cover letter
- Added a fix and test case for iothreads [Peter]
- Added a blockdev-snapshot feature flag to indicate that it's usable for attaching a backing chain to an overlay that is already in write-only use (e.g. as a mirror target) [Peter]
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | block: Make bdrv_get_cumulative_perm() publicblock.c include/ | +5 | 1 reply | |
| 2/7 | block: Relax restrictions for blockdev-snapshotblockdev.c tests/ | +10 | 2 replies | |
| 3/7 | iotests: Fix run_job() with use_log=Falsetests/ | +4 | 1 reply | |
| 4/7 | iotests: Test mirror with temporarily disabled target backing filetests/ tests/ | +53 | 1 reply | |
| 5/7 | block: Fix cross-AioContext blockdev-snapshotblock.c blockdev.c | +1 | 1 reply | |
| 6/7 | iotests: Add iothread cases to 155tests/ tests/ | +25 | 1 reply | |
| 7/7 | qapi: Add '@allow-write-only-overlay' feature for 'blockdev-snapshot'qapi/ | +8 | 0 replies |
Reviews trailers per patch
5 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Peter Krempa |
|---|---|
| 1/7 | R-b |
| 2/7 | R-b T-b |
| 3/7 | R-b |
| 4/7 | R-b |
| 5/7 | T-b |
| 6/7 | R-b |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/7] block: Relax restrictions for blockdev-snapshot
This series allows libvirt to fix a regression that its switch from drive-mirror to blockdev-mirror caused: It currently requires that the backing chain of the target image is already available when the mirror operation is started.
In reality, the backing chain may only be copied while the operation is in progress, so the backing file of the target image needs to stay disabled until the operation completes and should be attached only at that point. Without this series, we don't have a supported API to attach the backing file at that later point.
v2:
- Added a fix and test case for iothreads [Peter]
- Added a blockdev-snapshot feature flag to indicate that it's usable for attaching a backing chain to an overlay that is already in write-only use (e.g. as a mirror target) [Peter]
Kevin Wolf (6):
block: Make bdrv_get_cumulative_perm() public
block: Relax restrictions for blockdev-snapshot
iotests: Fix run_job() with use_log=False
iotests: Test mirror with temporarily disabled target backing file
block: Fix cross-AioContext blockdev-snapshot
iotests: Add iothread cases to 155
Peter Krempa (1):
qapi: Add '@allow-write-only-overlay' feature for 'blockdev-snapshot'
qapi/block-core.json | 9 +++- include/block/block_int.h | 3 ++ block.c | 7 ++- blockdev.c | 30 ++++-------- tests/qemu-iotests/iotests.py | 5 +- tests/qemu-iotests/085.out | 4 +- tests/qemu-iotests/155 | 88 +++++++++++++++++++++++++++++------ tests/qemu-iotests/155.out | 4 +- 8 files changed, 104 insertions(+), 46 deletions(-)
Signature · 1 line
2.20.1