drm: Convert drivers to drm_simple_encoder_init()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest22 patches 22 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/22 | drm/arc: Use simple encoderdrivers/ drivers/ | +5 | 2 replies | |
| 2/22 | drm/atmel-hlcdc: Use simple encoderdrivers/ | +4 | 1 reply | |
| 3/22 | drm/exynos: Use simple encoderdrivers/ drivers/ drivers/ +2 more | +10 | 1 reply | |
| 4/22 | drm/fsl-dcu: Use simple encoderdrivers/ | +3 | 0 replies | |
| 5/22 | drm/gma500: Use simple encoderdrivers/ drivers/ drivers/ +10 more | +22 | 2 replies | |
| 6/22 | drm/hisilicon/kirin: Use simple encoderdrivers/ | +2 | 0 replies | |
| 7/22 | drm/i2c/tda998x: Use simple encoderdrivers/ | +3 | 0 replies | |
| 8/22 | drm/imx: Use simple encoderdrivers/ drivers/ drivers/ +3 more | +8 | 0 replies | |
| 9/22 | drm/ingenic: Use simple encoderdrivers/ | +3 | 0 replies | |
| 10/22 | drm/mediatek: Use simple encoderdrivers/ drivers/ | +6 | 2 replies | |
| 11/22 | drm/rcar-du: Use simple encoderdrivers/ | +3 | 0 replies | |
| 12/22 | drm/rockchip: Use simple encoderdrivers/ drivers/ drivers/ +5 more | +19 | 0 replies | |
| 13/22 | drm/shmobile: Use simple encoderdrivers/ | +3 | 0 replies | |
| 14/22 | drm/sun4i: Use simple encoderdrivers/ drivers/ drivers/ +3 more | +17 | 0 replies | |
| 15/22 | drm/tegra: Use simple encoderdrivers/ drivers/ drivers/ +3 more | +11 | 0 replies | |
| 16/22 | drm/tidss: Use simple encoderdrivers/ | +3 | 1 reply | |
| 17/22 | drm/tilcdc: Use simple encoderdrivers/ drivers/ | +5 | 1 reply | |
| 18/22 | drm/vc4: Use simple encoderdrivers/ drivers/ drivers/ +1 more | +11 | 1 reply | |
| 19/22 | drm/virtgpu: Use simple encoderdrivers/ | +2 | 0 replies | |
| 20/22 | drm/vkms: Use simple encoderdrivers/ | +2 | 3 replies | |
| 21/22 | drm/writeback: Use simple encoderdrivers/ | +3 | 0 replies | |
| 22/22 | drm/zte: Use simple encoderdrivers/ drivers/ drivers/ | +6 | 0 replies |
Reviews trailers per patch
8 of 22 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Eric Anholt | Daniel Vetter | Laurent Pinchart | Jyri Sarha | Sam Ravnborg | Matthias Brugger | CK Hu |
|---|---|---|---|---|---|---|---|
| Series | A-b | R-b | A-b | ||||
| 1/22 | A-b | ||||||
| 2/22 | R-b | ||||||
| 3/22 | A-b | ||||||
| 4/22 | |||||||
| 5/22 | A-b | ||||||
| 6/22 | |||||||
| 7/22 | |||||||
| 8/22 | |||||||
| 9/22 | |||||||
| 10/22 | R-b | A-b | |||||
| 11/22 | |||||||
| 12/22 | |||||||
| 13/22 | |||||||
| 14/22 | |||||||
| 15/22 | |||||||
| 16/22 | A-b | ||||||
| 17/22 | A-b | ||||||
| 18/22 | A-b | ||||||
| 19/22 | |||||||
| 20/22 | |||||||
| 21/22 | |||||||
| 22/22 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.
Cover letter [PATCH 00/22] drm: Convert drivers to drm_simple_encoder_init()
A call to drm_simple_encoder_init() initializes an encoder without further functionality. It only provides the destroy callback to cleanup the encoder's state. Only few drivers implement more sophisticated encoders than that. Most drivers implement such a simple encoder and can use drm_simple_encoder_init() instead.
The patchset converts drivers where the encoder's instance is embedded in a larger data structure. The driver releases the memory during cleanup. Each patch replaces drm_encoder_init() with drm_simple_encoder_init() and removes the (now unused) driver's encoder functions.
While the patchset is fairly large, the indiviual patches are self- contained and can be merged independently from each other. The simple-encoder functionality is currently in drm-misc-next, where these patches could go as well.
Future directions: There's another common case where the driver calls kzalloc() plus drm_encoder_init(). Such drivers are not handled by this patchset. The plan here is to use a simple encoder with either managed memory allocation (once it's merged), or embed the encoder in a larger data structure and drop kzalloc() entirely.
The patchset has been compile-tested on x86-64, aarch64 and arm.
Thomas Zimmermann (22):
drm/arc: Use simple encoder
drm/atmel-hlcdc: Use simple encoder
drm/exynos: Use simple encoder
drm/fsl-dcu: Use simple encoder
drm/gma500: Use simple encoder
drm/hisilicon/kirin: Use simple encoder
drm/i2c/tda998x: Use simple encoder
drm/imx: Use simple encoder
drm/ingenic: Use simple encoder
drm/mediatek: Use simple encoder
drm/rcar-du: Use simple encoder
drm/rockchip: Use simple encoder
drm/shmobile: Use simple encoder
drm/sun4i: Use simple encoder
drm/tegra: Use simple encoder
drm/tidss: Use simple encoder
drm/tilcdc: Use simple encoder
drm/vc4: Use simple encoder
drm/virtgpu: Use simple encoder
drm/vkms: Use simple encoder
drm/writeback: Use simple encoder
drm/zte: Use simple encoder
drivers/gpu/drm/arc/arcpgu_hdmi.c | 10 +++------- drivers/gpu/drm/arc/arcpgu_sim.c | 8 ++------ .../gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 12 ++++-------- drivers/gpu/drm/drm_writeback.c | 10 +++------- drivers/gpu/drm/exynos/exynos_dp.c | 8 ++------ drivers/gpu/drm/exynos/exynos_drm_dpi.c | 8 ++------ drivers/gpu/drm/exynos/exynos_drm_dsi.c | 8 ++------ drivers/gpu/drm/exynos/exynos_drm_vidi.c | 8 ++------ drivers/gpu/drm/exynos/exynos_hdmi.c | 8 ++------ drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 14 +++----------- drivers/gpu/drm/gma500/cdv_intel_crt.c | 14 +++----------- drivers/gpu/drm/gma500/cdv_intel_dp.c | 16 +++------------- drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 4 ++-- drivers/gpu/drm/gma500/cdv_intel_lvds.c | 17 +++-------------- drivers/gpu/drm/gma500/mdfld_dsi_dpi.c | 7 +++---- drivers/gpu/drm/gma500/mdfld_output.h | 1 - drivers/gpu/drm/gma500/mdfld_tmd_vid.c | 6 ------ drivers/gpu/drm/gma500/mdfld_tpo_vid.c | 6 ------ drivers/gpu/drm/gma500/oaktrail_hdmi.c | 14 ++------------ drivers/gpu/drm/gma500/oaktrail_lvds.c | 5 +++-- drivers/gpu/drm/gma500/psb_intel_drv.h | 1 - drivers/gpu/drm/gma500/psb_intel_lvds.c | 18 +++--------------- drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c | 5 ----- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 8 ++------ drivers/gpu/drm/i2c/tda998x_drv.c | 14 +++----------- drivers/gpu/drm/imx/dw_hdmi-imx.c | 8 ++------ drivers/gpu/drm/imx/imx-drm-core.c | 6 ------ drivers/gpu/drm/imx/imx-drm.h | 1 - drivers/gpu/drm/imx/imx-ldb.c | 8 ++------ drivers/gpu/drm/imx/imx-tve.c | 8 ++------ drivers/gpu/drm/imx/parallel-display.c | 8 ++------ drivers/gpu/drm/ingenic/ingenic-drm.c | 9 +++------ drivers/gpu/drm/mediatek/mtk_dpi.c | 14 +++----------- drivers/gpu/drm/mediatek/mtk_dsi.c | 14 +++----------- drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 14 +++----------- .../gpu/drm/rockchip/analogix_dp-rockchip.c | 9 +++------ drivers/gpu/drm/rockchip/cdn-dp-core.c | 9 +++------ .../gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 8 ++------ drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 8 ++------ drivers/gpu/drm/rockchip/inno_hdmi.c | 8 ++------ drivers/gpu/drm/rockchip/rk3066_hdmi.c | 8 ++------ drivers/gpu/drm/rockchip/rockchip_lvds.c | 10 +++------- drivers/gpu/drm/rockchip/rockchip_rgb.c | 8 ++------ drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 14 +++----------- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 12 +++--------- drivers/gpu/drm/sun4i/sun4i_lvds.c | 12 +++--------- drivers/gpu/drm/sun4i/sun4i_rgb.c | 17 +++-------------- drivers/gpu/drm/sun4i/sun4i_tv.c | 17 +++-------------- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 12 +++--------- drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c | 8 ++------ drivers/gpu/drm/tegra/drm.h | 2 -- drivers/gpu/drm/tegra/dsi.c | 10 +++------- drivers/gpu/drm/tegra/hdmi.c | 9 +++------ drivers/gpu/drm/tegra/output.c | 6 +----- drivers/gpu/drm/tegra/rgb.c | 8 ++------ drivers/gpu/drm/tegra/sor.c | 8 ++------ drivers/gpu/drm/tidss/tidss_encoder.c | 10 +++------- drivers/gpu/drm/tilcdc/tilcdc_external.c | 10 +++------- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 8 ++------ drivers/gpu/drm/vc4/vc4_dpi.c | 8 ++------ drivers/gpu/drm/vc4/vc4_dsi.c | 15 +++------------ drivers/gpu/drm/vc4/vc4_hdmi.c | 17 ++++------------- drivers/gpu/drm/vc4/vc4_vec.c | 8 ++------ drivers/gpu/drm/virtio/virtgpu_display.c | 8 ++------ drivers/gpu/drm/vkms/vkms_output.c | 8 ++------ drivers/gpu/drm/zte/zx_hdmi.c | 8 ++------ drivers/gpu/drm/zte/zx_tvenc.c | 8 ++------ drivers/gpu/drm/zte/zx_vga.c | 8 ++------ 68 files changed, 151 insertions(+), 488 deletions(-)